[blink-dev] Intent to Ship: Updated dialog initial focus algorithm

2023-01-18 Thread Joey Arhar
Contact emailsjar...@chromium.org Specificationhttps://github.com/whatwg/html/pull/8199 Summary Some changes are being made to which element is selected to get focus when a dialog element is opened: 1. Make the dialog focusing steps look at keyboard focusable elements instead of any focusable el

Re: [blink-dev] Intent to Ship: Updated dialog initial focus algorithm

2023-01-24 Thread Rick Byers
Looks like showing dialog elements is at around 0.04% of page loads, so that's an upper bound of the compat risk here, right? The severity of breakage for focus no

Re: [blink-dev] Intent to Ship: Updated dialog initial focus algorithm

2023-01-24 Thread Philip Jägenstedt
Is https://github.com/whatwg/html/pull/8199 blocked mainly on implementer interest? Do other browsers exactly match the behavior before this spec change, or is it more complicated than that? What I'm getting at is whether we have confidence that we'll have eventual interop on the new behavior. On

Re: [blink-dev] Intent to Ship: Updated dialog initial focus algorithm

2023-01-24 Thread Joey Arhar
> Is https://github.com/whatwg/html/pull/8199 blocked mainly on implementer interest? Yes it looks that way > Do other browsers exactly match the behavior before this spec change, or is it more complicated than that? What I'm getting at is whether we have confidence that we'll have eventual inter

Re: [blink-dev] Intent to Ship: Updated dialog initial focus algorithm

2023-01-25 Thread Yoav Weiss
LGTM2 for the reasons Rick pointed out. On Wednesday, January 25, 2023 at 6:42:39 AM UTC+1 Joey Arhar wrote: > Is https://github.com/whatwg/html/pull/8199 blocked mainly on implementer interest? Yes it looks that way > Do other browsers exactly match the behavior before this spec change, or is

Re: [blink-dev] Intent to Ship: Updated dialog initial focus algorithm

2023-01-26 Thread Joey Arhar
The HTML spec PR has been merged: https://github.com/whatwg/html/pull/8199#event-8362454584 Firefox has given a positive signal: https://github.com/mozilla/standards-positions/issues/734#issuecomment-1404755193 > It won't be hard for us to change course if the discussion with other vendors would c

Re: [blink-dev] Intent to Ship: Updated dialog initial focus algorithm

2023-02-01 Thread Chris Harrelson
LGTM3 On Thu, Jan 26, 2023 at 10:54 AM Joey Arhar wrote: > The HTML spec PR has been merged: > https://github.com/whatwg/html/pull/8199#event-8362454584 > Firefox has given a positive signal: > https://github.com/mozilla/standards-positions/issues/734#issuecomment-1404755193 > > > It won't be ha