Re: [blink-dev] Intent to Ship: WebGPU: separate Read-only depth-stencil

2024-01-18 Thread Manuel Rego Casasnovas
LGTM3 On 18/01/2024 02:26, Mike Taylor wrote: LGTM2 On 1/17/24 7:45 PM, Chris Harrelson wrote: LGTM1 (as noted in the other intent, tests are needed but we aren't blocking approval on them in this case) On Wed, Jan 10, 2024 at 11:02 AM Corentin Wallez wrote: Hey Rick, The spec

Re: [blink-dev] Intent to Ship: WebGPU: separate Read-only depth-stencil

2024-01-17 Thread Mike Taylor
LGTM2 On 1/17/24 7:45 PM, Chris Harrelson wrote: LGTM1 (as noted in the other intent, tests are needed but we aren't blocking approval on them in this case) On Wed, Jan 10, 2024 at 11:02 AM Corentin Wallez wrote: Hey Rick, The spec PRs for all of these intents are landed but

Re: [blink-dev] Intent to Ship: WebGPU: separate Read-only depth-stencil

2024-01-17 Thread Chris Harrelson
LGTM1 (as noted in the other intent, tests are needed but we aren't blocking approval on them in this case) On Wed, Jan 10, 2024 at 11:02 AM Corentin Wallez wrote: > Hey Rick, > > The spec PRs for all of these intents are landed but you're correct that > all the tests are. Tests aren't blocked,

Re: [blink-dev] Intent to Ship: WebGPU: separate Read-only depth-stencil

2024-01-10 Thread Corentin Wallez
Hey Rick, The spec PRs for all of these intents are landed but you're correct that all the tests are. Tests aren't blocked, they just need someone to get to it (myself for this particular feature) and we won't turn the feature on until they are finished. I didn't realize that LGTMs waited on

Re: [blink-dev] Intent to Ship: WebGPU: separate Read-only depth-stencil

2024-01-10 Thread Rick Byers
Hi Corentin, This looks minor and probably pretty easy. But we do normally like to see spec PRs and tests land (or have a discussion around why they're blocked) before approving. Thoughts? Rick On Fri, Jan 5, 2024 at 8:18 AM Corentin Wallez wrote: > Contact emailscwal...@google.com > >

[blink-dev] Intent to Ship: WebGPU: separate Read-only depth-stencil

2024-01-05 Thread Corentin Wallez
Contact emailscwal...@google.com ExplainerNone Specificationhttps://github.com/gpuweb/gpuweb/pull/4331 Summary Functionality added to the WebGPU/WGSL spec after its first shipment in a browser. Loosens a restriction where using readonly depth-stencil attachments in a render pass required both