Re: [blink-dev] Intent to Ship: jitterBufferTarget

2024-02-15 Thread Daniel Bratell
LGTM3 but don't forget to verify that the chromestatus NAs for security and privacy are eventually confirmed. (I don't see how it could not be, but they are experts) /Daniel On 2024-02-14 19:19, Chris Harrelson wrote: LGTM2 On Wed, Feb 14, 2024 at 9:03 AM Yoav Weiss (@Shopify) wrote:

Re: [blink-dev] Intent to Ship: jitterBufferTarget

2024-02-14 Thread Chris Harrelson
LGTM2 On Wed, Feb 14, 2024 at 9:03 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > LGTM1 > > Thanks for aligning us on an interoperable name!! > > On Wednesday, February 14, 2024 at 4:37:25 PM UTC+1 Henrik Boström wrote: > >> From a code owner and W3C participant's perspective, I'm ve

Re: [blink-dev] Intent to Ship: jitterBufferTarget

2024-02-14 Thread Yoav Weiss (@Shopify)
LGTM1 Thanks for aligning us on an interoperable name!! On Wednesday, February 14, 2024 at 4:37:25 PM UTC+1 Henrik Boström wrote: > From a code owner and W3C participant's perspective, I'm very happy that > we're finally aligning our attribute name with the spec + Firefox' > implementation. Th

Re: [blink-dev] Intent to Ship: jitterBufferTarget

2024-02-14 Thread Henrik Boström
>From a code owner and W3C participant's perspective, I'm very happy that we're finally aligning our attribute name with the spec + Firefox' implementation. Thank you Eldar! (Ultimately we should deprecate and remove the old attribute name, but not until this has been shipped for a long time.)

Re: [blink-dev] Intent to Ship: jitterBufferTarget

2024-02-13 Thread Mike Taylor
Thanks! I had intended to reply that it's very simple to add a runtime enabled feature to IDL, but it's been a busy day. :) On 2/13/24 3:57 PM, Eldar Rello wrote: >Can we add a flag? https://chromium.googlesource.com/chromium/src/+/main/docs/flag_guarding_guidelines.md >(Or someone can expl

Re: [blink-dev] Intent to Ship: jitterBufferTarget

2024-02-13 Thread Eldar Rello
>Can we add a flag? https://chromium.googlesource.com/chromium/src/+/main/docs/flag_guarding_guidelines.md >(Or someone can explain why that's difficult and the risk is low here...). I made it as a runtime enabled feature now. On Monday, February 12, 2024 at 10:50:18 PM UTC+2 Eldar Rello wrot

Re: [blink-dev] Intent to Ship: jitterBufferTarget

2024-02-12 Thread Eldar Rello
On Monday, February 12, 2024 at 4:53:50 PM UTC+2 mike...@chromium.org wrote: On 2/12/24 6:36 AM, Eldar Rello wrote: Contact emails eldar...@gmail.com Explainer None Specification https://w3c.github.io/webrtc-extensions/#dom-rtcrtpreceiver-jitterbuffertarget Summary JitterBufferTarget attr

Re: [blink-dev] Intent to Ship: jitterBufferTarget

2024-02-12 Thread Mike Taylor
We also need to flip the various review gates on the chromestatus entry (privacy, security, enterprise... etc.). If you're working with someone at Google on this feature, perhaps they could assist? On 2/12/24 9:53 AM, Mike Taylor wrote: On 2/12/24 6:36 AM, Eldar Rello wrote: Contac

Re: [blink-dev] Intent to Ship: jitterBufferTarget

2024-02-12 Thread Mike Taylor
On 2/12/24 6:36 AM, Eldar Rello wrote: Contact emails eldar.re...@gmail.com Explainer None Specification https://w3c.github.io/webrtc-extensions/#dom-rtcrtpreceiver-jitterbuffertarget Summary JitterBufferTarget attribute allows applications to specify a

[blink-dev] Intent to Ship: jitterBufferTarget

2024-02-12 Thread Eldar Rello
Contact emailseldar.re...@gmail.com ExplainerNone Specification https://w3c.github.io/webrtc-extensions/#dom-rtcrtpreceiver-jitterbuffertarget Summary JitterBufferTarget attribute allows applications to specify a target duration of time in milliseconds of media for the RTCRtpReceiver's jitter b