Re: [blink-dev] Intent to implement and ship: blocking=render on inline scripts

2024-01-10 Thread Daniel Bratell
On 2024-01-10 18:27, Noam Rosenthal wrote: On Wed, Jan 10, 2024 at 5:25 PM Michal Mocny wrote: On Wed, Jan 10, 2024 at 10:55 AM Noam Rosenthal wrote: Great, perhaps the best way forward is with a flag that's starting as "stable" from the get go and we can later r

Re: [blink-dev] Intent to implement and ship: blocking=render on inline scripts

2024-01-10 Thread Noam Rosenthal
On Wed, Jan 10, 2024 at 5:25 PM Michal Mocny wrote: > > > On Wed, Jan 10, 2024 at 10:55 AM Noam Rosenthal > wrote: > >> >> >> On Wed, Jan 10, 2024 at 3:47 PM Rick Byers wrote: >> >>> Thanks Noam, LGTM2 >>> >>> Q: Since this is a trivial fix, does it need to be behind a flag? Either way is

Re: [blink-dev] Intent to implement and ship: blocking=render on inline scripts

2024-01-10 Thread 'Michal Mocny' via blink-dev
On Wed, Jan 10, 2024 at 10:55 AM Noam Rosenthal wrote: > > > On Wed, Jan 10, 2024 at 3:47 PM Rick Byers wrote: > >> Thanks Noam, LGTM2 >> >> Q: Since this is a trivial fix, does it need to be behind a flag? Either >>> way is fine with me. The current CL has it behind a new flag. >> >> >> I guess

Re: [blink-dev] Intent to implement and ship: blocking=render on inline scripts

2024-01-10 Thread Yoav Weiss
LGTM3 On Wednesday, January 10, 2024 at 4:47:46 PM UTC+1 Rick Byers wrote: > Thanks Noam, LGTM2 > > Q: Since this is a trivial fix, does it need to be behind a flag? Either >> way is fine with me. The current CL has it behind a new flag. > > > I guess technically it's a new platform API so our g

Re: [blink-dev] Intent to implement and ship: blocking=render on inline scripts

2024-01-10 Thread Noam Rosenthal
On Wed, Jan 10, 2024 at 3:47 PM Rick Byers wrote: > Thanks Noam, LGTM2 > > Q: Since this is a trivial fix, does it need to be behind a flag? Either >> way is fine with me. The current CL has it behind a new flag. > > > I guess technically it's a new platform API so our guidelines >

Re: [blink-dev] Intent to implement and ship: blocking=render on inline scripts

2024-01-10 Thread Rick Byers
Thanks Noam, LGTM2 Q: Since this is a trivial fix, does it need to be behind a flag? Either > way is fine with me. The current CL has it behind a new flag. I guess technically it's a new platform API so our guidelines

Re: [blink-dev] Intent to implement and ship: blocking=render on inline scripts

2024-01-10 Thread Daniel Bratell
LGTM1 - I agree that this is small enough to just proceed. /Daniel On 2024-01-10 16:40, Noam Rosenthal wrote: On Wed, Jan 10, 2024 at 3:32 PM Rick Byers wrote: Hi Noam, This seems pretty trivial to me. The spec change is trivial and presumably any review feedback will only be ed

Re: [blink-dev] Intent to implement and ship: blocking=render on inline scripts

2024-01-10 Thread Noam Rosenthal
Q: Since this is a trivial fix, does it need to be behind a flag? Either way is fine with me. The current CL has it behind a new flag. On Wed, Jan 10, 2024 at 3:40 PM Noam Rosenthal wrote: > > > On Wed, Jan 10, 2024 at 3:32 PM Rick Byers wrote: > >> Hi Noam, >> This seems pretty trivial to me.

Re: [blink-dev] Intent to implement and ship: blocking=render on inline scripts

2024-01-10 Thread Noam Rosenthal
On Wed, Jan 10, 2024 at 3:32 PM Rick Byers wrote: > Hi Noam, > This seems pretty trivial to me. The spec change is trivial and presumably > any review feedback will only be editorial (not functional), so I'm OK not > blocking approval on the spec PR landing. But could you get a WPTs > implemented

Re: [blink-dev] Intent to implement and ship: blocking=render on inline scripts

2024-01-10 Thread Rick Byers
Hi Noam, This seems pretty trivial to me. The spec change is trivial and presumably any review feedback will only be editorial (not functional), so I'm OK not blocking approval on the spec PR landing. But could you get a WPTs implemented and at least ready to land (eg. along with the implementation

[blink-dev] Intent to implement and ship: blocking=render on inline scripts

2024-01-08 Thread Noam Rosenthal
Contact emailsnrosent...@chromium.org ExplainerNone (this is a small change to an existing feature) Specificationhttps://github.com/whatwg/html/pull/10035 Summary Currently