Re: [blink-dev] Re: Intent to Ship: Clipboard: Preserve PNG metadata

2021-09-07 Thread Marijn Kruisselbrink
I clarified the currently spec'ed behavior around image sanitization in https://github.com/w3c/clipboard-apis/pull/156. That should make explicit the current behavior of Safari and Firefox, and be in match the proposed changes for Chrome in this Intent. On Wed, Sep 1, 2021 at 10:47 AM Anupam Snigd

Re: [blink-dev] Re: Intent to Ship: Clipboard: Preserve PNG metadata

2021-09-08 Thread Yoav Weiss
Thank you!! *LGTM2* On Tue, Sep 7, 2021 at 11:31 PM Marijn Kruisselbrink wrote: > I clarified the currently spec'ed behavior around image sanitization in > https://github.com/w3c/clipboard-apis/pull/156. That should make explicit > the current behavior of Safari and Firefox, and be in match the

Re: [blink-dev] Re: Intent to Ship: Clipboard: Preserve PNG metadata

2021-09-08 Thread Mike West
LGTM3. Thanks for following up on this. -mike On Wed, Sep 8, 2021 at 9:19 AM Yoav Weiss wrote: > Thank you!! > > *LGTM2* > > On Tue, Sep 7, 2021 at 11:31 PM Marijn Kruisselbrink > wrote: > >> I clarified the currently spec'ed behavior around image sanitization in >> https://github.com/w3c/cli

Re: [blink-dev] Re: Intent to Ship: Clipboard: Preserve PNG metadata

2021-08-18 Thread Marijn Kruisselbrink
While I agree that it would be nice for the clipboard API to better specify what sanitization is and isn't done, do note that this change merely brings us in line with other existing implementations. I.e. both Safari and Firefox already ship the behavior we're proposing to ship with here as well. h

Re: [blink-dev] Re: Intent to Ship: Clipboard: Preserve PNG metadata

2021-08-18 Thread Yoav Weiss
Changing the spec to explicitly say that no sanitization is to be done on input would be good. I agree that aligning behavior with other implementers is the right thing to do, but we need to document that behavior. Can y'all please file a spec PR to that effect? On Wed, Aug 18, 2021 at 10:53 PM Ma

Re: [blink-dev] Re: Intent to Ship: Clipboard: Preserve PNG metadata

2021-08-26 Thread 'Mike West' via blink-dev
Friendly ping to Yoav's question. I would also like to see some sort of hook in the spec that made this mechanism explicit. I think this is a reasonable change to ship, I just want to ensure we lock in reasonable behavior at the spec level. Is that something y'all can take care of? Thanks! -mike

Re: [blink-dev] Re: Intent to Ship: Clipboard: Preserve PNG metadata

2021-08-31 Thread Anupam Snigdha
I can probably add something to this discussion. In this thread, we are discussing about making the sanitization process more explicit in async clipboard APIs spec during read & write. We have proposed the HTML sanitization behavior here

Re: [blink-dev] Re: Intent to Ship: Clipboard: Preserve PNG metadata

2021-09-01 Thread 'Austin Sullivan' via blink-dev
I just chimed in on the GitHub thread you linked. It's not entirely related, since this change is simply putting us in line with other browsers and we want to reflect this newly consistent behavior in the spec, while the HTML sanitization changes seem like they'll require a bit more discussion and

Re: [blink-dev] Re: Intent to Ship: Clipboard: Preserve PNG metadata

2021-09-01 Thread Anupam Snigdha
Thanks Austin! I think you are right that HTML changes would require more discussion so the spec updates for that can be done separately. SVG will probably depend on the outcome of that discussion as it uses the same sanitization procedure as HTML. I can update the spec to reflect the current behav