Re: [blink-dev] Re: Intent to Ship: FedCM extensions: Error API and Auto-Selected Flag API

LGTM3 On Mon, Oct 30, 2023 at 7:35 PM Rick Byers wrote: > Thanks Mike. LGTM2 > > On Mon, Oct 30, 2023 at 12:21 PM Mike Taylor > wrote: > >> I'd like to remove my condition around my LGTM - I was able to reach out >> to Ben offline to confirm that he's roughly in favor of the proposed >>

Re: [blink-dev] Re: Intent to Ship: FedCM extensions: Error API and Auto-Selected Flag API

Thanks Mike. LGTM2 On Mon, Oct 30, 2023 at 12:21 PM Mike Taylor wrote: > I'd like to remove my condition around my LGTM - I was able to reach out > to Ben offline to confirm that he's roughly in favor of the proposed > additions. Given that, I don't think we should block on reviews >

Re: [blink-dev] Re: Intent to Ship: FedCM extensions: Error API and Auto-Selected Flag API

I'd like to remove my condition around my LGTM - I was able to reach out to Ben offline to confirm that he's roughly in favor of the proposed additions. Given that, I don't think we should block on reviews (acknowledging a private chat is not an official position or statement of support).

Re: [blink-dev] Re: Intent to Ship: FedCM extensions: Error API and Auto-Selected Flag API

However, even for WHATWG specs we have in the past blocked approval until spec PRs landed in cases where the only blocker was editorial review. This appears to be a similar situation. On Fri, Oct 27, 2023 at 2:17 PM Rick Byers wrote: > FedCM has decided to follow a WHATWG-like working mode >

Re: [blink-dev] Re: Intent to Ship: FedCM extensions: Error API and Auto-Selected Flag API

FedCM has decided to follow a WHATWG-like working mode where normative PRs land only with 2+ implementer support. Given that reviews were requested almost 2 months ago, and the blink launch process is designed not to stall indefinitely on consensus, I

Re: [blink-dev] Re: Intent to Ship: FedCM extensions: Error API and Auto-Selected Flag API

Thanks Nicolás and Yi. LGTM1 % the PRs landing before this ships, and assuming Mozilla does not have feedback that materially changes the API shape. If that's the case, can you report back? thanks, Mike On 10/26/23 10:27 AM, Nicolás Peña wrote: For the record, we did request reviews: here

Re: [blink-dev] Re: Intent to Ship: FedCM extensions: Error API and Auto-Selected Flag API

For the record, we did request reviews: here and here . I'll ask to see if they can be added to the set of users from whom we can 'request review' in GitHub

Re: [blink-dev] Re: Intent to Ship: FedCM extensions: Error API and Auto-Selected Flag API

We sync’d with @bvandersloot-mozilla in FedIdCG [1] and they have confirmed that it’s on their list. [1] https://github.com/fedidcg/meetings/blob/main/2023/2023-10-02-notes.md#notes On Wed, Oct 25, 2023 at 6:51 PM Mike Taylor wrote: > On 10/25/23 4:14

Re: [blink-dev] Re: Intent to Ship: FedCM extensions: Error API and Auto-Selected Flag API

On 10/25/23 4:14 PM, Yi Gu wrote: Thanks Yoav for the review! > It'd be useful to write a short (inline?) explainer here outlining what this does and how it'd look like. Specifically, would we start throwing on errors in scenarios that silently failed before? For the Error API, it allows

[blink-dev] Re: Intent to Ship: FedCM extensions: Error API and Auto-Selected Flag API

Thanks Yoav for the review! > It'd be useful to write a short (inline?) explainer here outlining what this does and how it'd look like. Specifically, would we start throwing on errors in scenarios that silently failed before? For the Error API, it allows IdP to signal to the browser about the

[blink-dev] Re: Intent to Ship: FedCM extensions: Error API and Auto-Selected Flag API

On Monday, October 23, 2023 at 3:03:59 PM UTC+2 blink-dev wrote: Contact emails y...@chromium.org Explainer https://github.com/fedidcg/FedCM/issues/488 It'd be useful to write a short (inline?) explainer here outlining what this does and how it'd look like. Specifically, would we start