[blink-dev] Re: Intent to Ship: Fenced Frames

2023-06-21 Thread Alex Russell
Hey all, I'm not going to weigh in on if this should ship right now, but I want to express some disappointment that this design seems to be launching without a way to load from a bundle and a flag for removing the ability to load from the network. We have a lot of use-cases that would benefit f

Re: [blink-dev] Re: Intent to Ship: Fenced Frames

2023-06-21 Thread Chris Harrelson
LGTM1 Thank you for thoroughly working through all the design and specification steps for this feature. Glad to see some positive signals from the TAG about the fundamental design in particular. I agree that Alex's comments are good to answer and investigate for future work, but also they aren't

Re: [blink-dev] Re: Intent to Ship: Fenced Frames

2023-06-21 Thread Rick Byers
LGTM2 On Wed, Jun 21, 2023 at 11:46 AM Chris Harrelson wrote: > LGTM1 > > Thank you for thoroughly working through all the design and specification > steps for this feature. Glad to see some positive signals from the TAG > about the fundamental design in particular. > > I agree that Alex's comme

Re: [blink-dev] Re: Intent to Ship: Fenced Frames

2023-06-21 Thread Mike Taylor
LGTM3 On 6/21/23 11:53 AM, Rick Byers wrote: LGTM2 On Wed, Jun 21, 2023 at 11:46 AM Chris Harrelson wrote: LGTM1 Thank you for thoroughly working through all the design and specification steps for this feature. Glad to see some positive signals from the TAG about the fundam

Re: [blink-dev] Re: Intent to Ship: Fenced Frames

2023-06-21 Thread Joshua Bell
Just a quick note on spec maturity: as spec mentor, I did a thorough review of the spec text, and noted many issues - all small - which have been addressed. As the feature introduces a privacy boundary between two documents with very sensitive one-way control, it is non-trivial but the design is w

Re: [blink-dev] Re: Intent to Ship: Fenced Frames

2023-06-21 Thread Shivani Sharma
Thanks all! (Response inline) On Wed, Jun 21, 2023 at 12:19 PM Joshua Bell wrote: > Just a quick note on spec maturity: as spec mentor, I did a thorough > review of the spec text, and noted many issues - all small - which have > been addressed. As the feature introduces a privacy boundary betw