LGTM3
On 1/17/24 3:40 PM, Yoav Weiss wrote:
LGTM2
On Wed, Jan 17, 2024 at 9:04 PM Corentin Wallez
wrote:
Thanks a lot!
On Wed, Jan 17, 2024 at 8:11 PM Chris Harrelson
wrote:
Got it, thanks for clarifying and the quick response!
The API owners reviewed today
LGTM2
On Wed, Jan 17, 2024 at 9:04 PM Corentin Wallez
wrote:
> Thanks a lot!
>
> On Wed, Jan 17, 2024 at 8:11 PM Chris Harrelson
> wrote:
>
>> Got it, thanks for clarifying and the quick response!
>>
>> The API owners reviewed today and we're comfortable with not blocking our
>> LGTMs on
Thanks a lot!
On Wed, Jan 17, 2024 at 8:11 PM Chris Harrelson
wrote:
> Got it, thanks for clarifying and the quick response!
>
> The API owners reviewed today and we're comfortable with not blocking our
> LGTMs on landing the tests, since your team is committed to adding them
> before shipping.
Got it, thanks for clarifying and the quick response!
The API owners reviewed today and we're comfortable with not blocking our
LGTMs on landing the tests, since your team is committed to adding them
before shipping.
On Wed, Jan 17, 2024 at 8:53 AM Corentin Wallez
wrote:
> Thanks! Tests for
Thanks! Tests for other intents are still WIP, though it'd be nice to get
the LGTMs so we don't need to come back once they are :) We require tests
to be complete (and passing!) in our own process before shipping anyway.
On Wed, Jan 17, 2024 at 5:49 PM Chris Harrelson
wrote:
> Great - LGTM1!
>
Great - LGTM1!
Does your comment about tests also apply to the other intents?
On Wed, Jan 17, 2024 at 8:46 AM Corentin Wallez
wrote:
> API owners, PTAL: the tests have been implemented, and all review boxes
> are green!
>
> On Friday, January 5, 2024 at 2:17:56 PM UTC+1 Corentin Wallez wrote:
API owners, PTAL: the tests have been implemented, and all review boxes are
green!
On Friday, January 5, 2024 at 2:17:56 PM UTC+1 Corentin Wallez wrote:
> Contact emailscwal...@google.com
>
> ExplainerNone
>
> Specification
>
