Re: [blink-dev] Intent to Ship: Web Authentication API: JSON serialization methods

2024-08-07 Thread Daniel Bratell
LGTM3 /Daniel On 2024-08-07 07:38, Yoav Weiss (@Shopify) wrote: LGTM2 On Wed, Aug 7, 2024 at 2:14 AM Domenic Denicola wrote: LGTM1 On Wed, Aug 7, 2024 at 5:41 AM 'Martin Kreichgauer' via blink-dev wrote: The WPTs should be passing in Firefox now [1

Re: [blink-dev] Intent to Ship: Web Authentication API: JSON serialization methods

2024-08-06 Thread Yoav Weiss (@Shopify)
LGTM2 On Wed, Aug 7, 2024 at 2:14 AM Domenic Denicola wrote: > LGTM1 > > On Wed, Aug 7, 2024 at 5:41 AM 'Martin Kreichgauer' via blink-dev < > blink-dev@chromium.org> wrote: > >> The WPTs should be passing in Firefox now [1 >>

Re: [blink-dev] Intent to Ship: Web Authentication API: JSON serialization methods

2024-08-06 Thread Domenic Denicola
LGTM1 On Wed, Aug 7, 2024 at 5:41 AM 'Martin Kreichgauer' via blink-dev < blink-dev@chromium.org> wrote: > The WPTs should be passing in Firefox now [1 > ] > [

Re: [blink-dev] Intent to Ship: Web Authentication API: JSON serialization methods

2024-08-06 Thread 'Martin Kreichgauer' via blink-dev
The WPTs should be passing in Firefox now [1 ] [2

Re: [blink-dev] Intent to Ship: Web Authentication API: JSON serialization methods

2024-07-26 Thread Yoav Weiss (@Shopify)
Friendly reminder that this is blocked on addressing Domenic's feedback RE the WPTs :) On Wednesday, July 17, 2024 at 8:26:22 PM UTC+2 mart...@google.com wrote: > Work is underway to enable WebAuthn broadly on WebView. As far as I'm > aware, that work hasn't quite roll out yet due to some depen

Re: [blink-dev] Intent to Ship: Web Authentication API: JSON serialization methods

2024-07-17 Thread 'Martin Kreichgauer' via blink-dev
Work is underway to enable WebAuthn broadly on WebView. As far as I'm aware, that work hasn't quite roll out yet due to some dependency on the Android side. I'll ask the people working on that to ensure they update the MDN compat table once we know a minimum version. Once WebAuthn is available in

Re: [blink-dev] Intent to Ship: Web Authentication API: JSON serialization methods

2024-07-17 Thread Yoav Weiss (@Shopify)
On Sat, Jul 13, 2024 at 1:42 AM 'Martin Kreichgauer' via blink-dev < blink-dev@chromium.org> wrote: > Contact emailsmarti...@google.com > > Explainer > https://github.com/w3c/webauthn/wiki/Explainer:-JSON-Serialization-Methods > > Specificationhttps://w3c.github.io/webauthn/#publickeycredential >

Re: [blink-dev] Intent to Ship: Web Authentication API: JSON serialization methods

2024-07-16 Thread Domenic Denicola
On Wed, Jul 17, 2024 at 7:20 AM Martin Kreichgauer wrote: > On Mon, Jul 15, 2024 at 8:04 PM Domenic Denicola > wrote: > >> One request: the use of static method syntax for all three methods, when >> only 2 are static, is pretty confusing. It'd be ideal to update the >> explainer and ChromeStatus

Re: [blink-dev] Intent to Ship: Web Authentication API: JSON serialization methods

2024-07-16 Thread 'Martin Kreichgauer' via blink-dev
On Mon, Jul 15, 2024 at 8:04 PM Domenic Denicola wrote: > One request: the use of static method syntax for all three methods, when > only 2 are static, is pretty confusing. It'd be ideal to update the > explainer and ChromeStatus entry to make it clearer which methods are > static methods (Public

Re: [blink-dev] Intent to Ship: Web Authentication API: JSON serialization methods

2024-07-15 Thread Domenic Denicola
One request: the use of static method syntax for all three methods, when only 2 are static, is pretty confusing. It'd be ideal to update the explainer and ChromeStatus entry to make it clearer which methods are static methods (PublicKeyCredential.parseCreationOptionsFromJSON(), PublicKeyCredential.

Re: [blink-dev] Intent to Ship: Web Authentication API: JSON serialization methods

2024-07-15 Thread 'Martin Kreichgauer' via blink-dev
Done: https://github.com/WebKit/standards-positions/issues/373. Also added to the chromestatus entry. On Mon, Jul 15, 2024 at 9:48 AM Daniel Clark wrote: > Could you request WebKit’s position for this? > https://github.com/WebKit/standards-positions/issues/ > > > > -- Dan > > > > *From:* 'Martin

RE: [blink-dev] Intent to Ship: Web Authentication API: JSON serialization methods

2024-07-15 Thread 'Daniel Clark' via blink-dev
Could you request WebKit’s position for this? https://github.com/WebKit/standards-positions/issues/ -- Dan From: 'Martin Kreichgauer' via blink-dev Sent: Friday, July 12, 2024 4:42 PM To: blink-dev Subject: [blink-dev] Intent to Ship: Web Authentication API: JSON serialization methods Contac