Re: [blink-dev] Intent to Ship: Allow Cross-Origin Subframes to Send Automatic Beacons

2024-01-24 Thread Daniel Bratell
LGTM3 /Daniel On 2024-01-24 11:45, Yoav Weiss (@Shopify) wrote: LGTM2 On Tuesday, January 23, 2024 at 11:17:35 AM UTC+1 Mike Taylor wrote: Thanks Liam. This seems fine to me given that both parties need to opt in. LGTM1 On 1/22/24 6:10 PM, Liam Brady wrote: Hi Mike,

Re: [blink-dev] Intent to Ship: Allow Cross-Origin Subframes to Send Automatic Beacons

2024-01-24 Thread Yoav Weiss (@Shopify)
LGTM2 On Tuesday, January 23, 2024 at 11:17:35 AM UTC+1 Mike Taylor wrote: > Thanks Liam. This seems fine to me given that both parties need to opt in. > > LGTM1 > On 1/22/24 6:10 PM, Liam Brady wrote: > > Hi Mike, > > "crossOrigin=true" is just a typo. "crossOrigin" was the original naming >

Re: [blink-dev] Intent to Ship: Allow Cross-Origin Subframes to Send Automatic Beacons

2024-01-23 Thread Mike Taylor
Thanks Liam. This seems fine to me given that both parties need to opt in. LGTM1 On 1/22/24 6:10 PM, Liam Brady wrote: Hi Mike, "crossOrigin=true" is just a typo. "crossOrigin" was the original naming convention for "crossOriginExposed". It was renamed during code review, but I forgot to

Re: [blink-dev] Intent to Ship: Allow Cross-Origin Subframes to Send Automatic Beacons

2024-01-22 Thread 'Liam Brady' via blink-dev
Hi Mike, "crossOrigin=true" is just a typo. "crossOrigin" was the original naming convention for "crossOriginExposed". It was renamed during code review, but I forgot to update the I2S wording to match that. We chose to not go with Permissions-Policy for a few reasons. First is that for

Re: [blink-dev] Intent to Ship: Allow Cross-Origin Subframes to Send Automatic Beacons

2024-01-19 Thread Mike Taylor
Hi Liam, On 1/16/24 3:49 PM, 'Liam Brady' via blink-dev wrote: Contact emails lbr...@google.com , shivani...@chromium.org , jkar...@chromium.org Explainer(s)