[Apache Bloodhound] #289: Create Ticket and Preview buttons are hidden on the Create New Ticket page

2012-12-07 Thread Apache Bloodhound
#289: Create Ticket and Preview buttons are hidden on the Create New Ticket page
---+---
 Reporter:  rjollos|  Owner:  nobody
 Type:  defect | Status:  new
 Priority:  major  |  Milestone:  Release 4
Component:  ui design  |Version:  0.2.0
 Keywords: |
---+---
 With r1417813, the **Preview** and **Create ticket** buttons are hidden
 under the ''draft'' image.

 [[Image(HiddenButtons.png)]]

 The issue does not seem to be present in the release running on this site
 (0.2.0). The attached patch fixes the issue. Please review, since my
 knowledge of CSS is very minimal.

 [[Image(VisibleButtons.png)]]

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/289
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #275: Selecting action in ticket modify section hides action radio buttons when doing preview

2012-12-07 Thread Apache Bloodhound
#275: Selecting action in ticket modify section hides action radio buttons when
doing preview
+
  Reporter:  jure   |  Owner:  nobody
  Type:  defect | Status:  new
  Priority:  major  |  Milestone:
 Component:  dashboard  |Version:
Resolution: |   Keywords:
+

Comment (by rjollos):

 I'm probably not understanding the issue, because I can't reproduce. This
 ticket is a ''new defect'', but when I select a radio button in the
 workflow actions, the ''accept'' radio button doesn't disappear. I've also
 tested with r1418204 of the trunk.

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/275#comment:1
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #146: Inline editing of objects

2012-12-07 Thread Apache Bloodhound
#146: Inline editing of objects
--+
  Reporter:  jdreimann|  Owner:  olemis
  Type:  enhancement  | Status:  accepted
  Priority:  critical |  Milestone:  Release 4
 Component:  dashboard|Version:
Resolution:   |   Keywords:  inplace bheditable
--+

Comment (by olemis):

 The new approach to in-place editing in ticket view is not compatible with
 jEditable afaics . Hence I've built everything from scratch . Attached
 patches against theme plugin add the following features :

   1. Enhanced ticket fields list updated according to responsive mockups
   2. Enhanced scroll spy nav bar implemented with Bootstrap button groups
  like sketched in responsive mockups
   3. Modify ticket section is gone
   4. On clicking Modify Ticket button in scroll spy nav bar , ticket view
  enters editable state (suggested by jure)

 Patches should be applied against bloodhound_theme @ r1418195 in the
 following order :

 {{{
 #!sh

 $ hg qapplied
 t146/t146_r1418195_scrollspy_btn.diff
 t146/t146_r1418195_ticket_header.diff
 t146/t146_r1418195_inplace_ticket_fields.diff

 }}}

 Issues found so far :

   1. In editable state scroll spy does not activate nav item accurately.
  This happens because heights are different (e.g. wiki toolbar added
  on top of some textarea elements , etc ...) to the values when
  scroll spy was installed.

 ... /me figuring out how to fix .

 After all this ticket view will look like shown below in view mode ...

 [[Image(bh_theme_x_86_ticket_responsive_view_state.png, width=600)]]

 ... and in editable mode ...

 [[Image(bh_theme_x_87_ticket_responsive_edit_state.png, width=600)]]

 Still there are many open questions :

   1. What happens after ticket enters editable state ?
   2. What about workflow actions now that Modify Ticket section is gone?
   3. Should description, keywords and summary be put into editable
  as well (... IMO they should , I'm just looking for
  confirmation ...) ?

 Feedback is welcome .

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:27
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #140: User-defined dashboard contents.

2012-12-07 Thread Apache Bloodhound
#140: User-defined dashboard contents.
-+-
  Reporter:  olemis  |  Owner:
  Type:  | Status:  new
  enhancement|  Milestone:
  Priority:  minor   |Version:
 Component:  dashboard   |   Keywords:  dashboard configuration database
Resolution:  |  markup preferences admin
-+-
Changes (by olemis):

 * owner:  franco =
 * status:  assigned = new


-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/140#comment:9
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #287: Hide theme engine administration panels

2012-12-07 Thread Apache Bloodhound
#287: Hide theme engine administration panels
--+--
  Reporter:  rjollos  |  Owner:  rjollos
  Type:  enhancement  | Status:  accepted
  Priority:  trivial  |  Milestone:
 Component:  plugins  |Version:
Resolution:   |   Keywords:
--+--

Comment (by rjollos):

 My thinking is similar to comment:5. Let's hide things from the admin
 panel that we don't want to support at this point. Later on, we may choose
 to support themes, and can then add proper BH templates for the theme
 engine administration panels.

 I interpret rules as ''command line switches'' for `setup_bloodhound.py`.
 If that is how it was meant, I think a switch would serve little purpose
 for this case, but could be useful for other cases.

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/287#comment:6
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


svn commit: r1418213 - /incubator/bloodhound/trunk/installer/bloodhound_setup.py

2012-12-07 Thread rjollos
Author: rjollos
Date: Fri Dec  7 08:18:04 2012
New Revision: 1418213

URL: http://svn.apache.org/viewvc?rev=1418213view=rev
Log:
Refs #287: Hide the theme engine administration panels

Modified:
incubator/bloodhound/trunk/installer/bloodhound_setup.py

Modified: incubator/bloodhound/trunk/installer/bloodhound_setup.py
URL: 
http://svn.apache.org/viewvc/incubator/bloodhound/trunk/installer/bloodhound_setup.py?rev=1418213r1=1418212r2=1418213view=diff
==
--- incubator/bloodhound/trunk/installer/bloodhound_setup.py (original)
+++ incubator/bloodhound/trunk/installer/bloodhound_setup.py Fri Dec  7 
08:18:04 2012
@@ -60,7 +60,8 @@ BASE_CONFIG = {'components': {'bhtheme.*
   'bhdashboard.*': 'enabled',
   'multiproduct.*': 'enabled',
   'permredirect.*': 'enabled',
-  'themeengine.*': 'enabled',
+  'themeengine.api.*': 'enabled',
+  'themeengine.web_ui.*': 'enabled',
   'bhsearch.*': 'disabled',
   'trac.ticket.web_ui.ticketmodule': 'disabled',
   'trac.ticket.report.reportmodule': 'disabled',




Re: [Apache Bloodhound] #287: Hide theme engine administration panels

2012-12-07 Thread Apache Bloodhound
#287: Hide theme engine administration panels
--+-
  Reporter:  rjollos  |  Owner:  rjollos
  Type:  enhancement  | Status:  closed
  Priority:  trivial  |  Milestone:
 Component:  plugins  |Version:
Resolution:  fixed|   Keywords:
--+-
Changes (by rjollos):

 * status:  accepted = closed
 * resolution:   = fixed


Comment:

 Fixes in r1418213.

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/287#comment:7
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


svn commit: r1418224 - /incubator/bloodhound/trunk/bloodhound_multiproduct/tests/model.py

2012-12-07 Thread rjollos
Author: rjollos
Date: Fri Dec  7 08:55:11 2012
New Revision: 1418224

URL: http://svn.apache.org/viewvc?rev=1418224view=rev
Log:
Refs #105, #280: Fix test cases broken by move of 
`multiproduct.model.MultiProductEnvironmentProvider` to 
`multiproduct.api.MultiProductSystem` in r1352503.

Modified:
incubator/bloodhound/trunk/bloodhound_multiproduct/tests/model.py

Modified: incubator/bloodhound/trunk/bloodhound_multiproduct/tests/model.py
URL: 
http://svn.apache.org/viewvc/incubator/bloodhound/trunk/bloodhound_multiproduct/tests/model.py?rev=1418224r1=1418223r2=1418224view=diff
==
--- incubator/bloodhound/trunk/bloodhound_multiproduct/tests/model.py (original)
+++ incubator/bloodhound/trunk/bloodhound_multiproduct/tests/model.py Fri Dec  
7 08:55:11 2012
@@ -26,7 +26,7 @@ from sqlite3 import OperationalError
 from trac.test import EnvironmentStub
 from trac.core import TracError
 from multiproduct.model import Product
-from multiproduct.model import MultiProductEnvironmentProvider
+from multiproduct.api import MultiProductSystem
 
 class ProductTestCase(unittest.TestCase):
 Unit tests covering the Product model
@@ -34,9 +34,9 @@ class ProductTestCase(unittest.TestCase)
 self.env = EnvironmentStub(enable=['trac.*', 'multiproduct.*'])
 self.env.path = tempfile.mkdtemp('bh-product-tempenv')
 
-self.envprovider = MultiProductEnvironmentProvider(self.env)
+self.mpsystem = MultiProductSystem(self.env)
 try:
-self.envprovider.upgrade_environment(self.env.db_transaction)
+self.mpsystem.upgrade_environment(self.env.db_transaction)
 except OperationalError:
 # table remains but database version is deleted
 pass
@@ -57,10 +57,10 @@ class ProductTestCase(unittest.TestCase)
 tests that select can search Products by fields
 
 p2_data = {'prefix':'tp2',
-   'name':'test project',
+   'name':'test project 2',
'description':'a different test project'}
 p3_data = {'prefix':'tp3',
-   'name':'test project',
+   'name':'test project 3',
'description':'test project'}
 
 product2 = Product(self.env)
@@ -74,9 +74,9 @@ class ProductTestCase(unittest.TestCase)
 products = list(Product.select(self.env, where={'prefix':'tp'}))
 self.assertEqual(1, len(products))
 products = list(Product.select(self.env, where={'name':'test 
project'}))
-self.assertEqual(3, len(products))
+self.assertEqual(1, len(products))
 products = list(Product.select(self.env, where={'prefix':'tp3',
-'name':'test 
project'}))
+'name':'test project 
3'}))
 self.assertEqual(1, len(products))
 
 def test_update(self):




Re: [Apache Bloodhound] #105: Merge components in Multiproduct plugin

2012-12-07 Thread Apache Bloodhound
#105: Merge components in Multiproduct plugin
---+-
  Reporter:  olemis|  Owner:  nobody
  Type:  defect| Status:  closed
  Priority:  major |  Milestone:  RC1 for initial release
 Component:  multiproduct  |Version:
Resolution:  fixed |   Keywords:
---+-

Comment (by rjollos):

 In r1352503, `multiproduct.model.MultiProductEnvironmentProvider` was
 moved/renamed to `multiproduct.api.MultiProductSystem`, but the unit tests
 were not updated. The unit tests were updated in r1418224 (see #280).

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/105#comment:7
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin

2012-12-07 Thread Apache Bloodhound
#280: Move multiproduct.model.ModelBase to dashboard plugin
---+
  Reporter:  olemis|  Owner:  franco
  Type:  enhancement   | Status:  accepted
  Priority:  trivial   |  Milestone:
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  database model testing
---+

Comment (by rjollos):

 I haven't seen the previous discussion in which it was decided to move
 common components to dashboard, but my initial impression is that it
 doesn't make much more sense to have them in dashboard than in
 multiproduct. I had a brief discussion about this with gjm this evening,
 and we both think it might make sense to move the components to a new
 `bloodhound_core` directory. I  also think that `ModelBase.py` should be
 in `model.py` rather than `db.py`. My understanding is that only the
 schema and environment upgrade hooks should be in `db.py`.

 I've committed the fixes for the test cases in r1418224. Thank you franco
 and olemis! I look forward to hearing your comments on these other issues.

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:5
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


[Apache Bloodhound] New user registration: test

2012-12-07 Thread Apache Bloodhound
New user registration for user test

--
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker



Re: [Apache Bloodhound] #290: upgrade issues.apache.org/bloodhound to 0.3.0

2012-12-07 Thread Apache Bloodhound
#290: upgrade issues.apache.org/bloodhound to 0.3.0
+--
  Reporter:  gjm|  Owner:  gjm
  Type:  task   | Status:  accepted
  Priority:  major  |  Milestone:
 Component:  siteadmin  |Version:
Resolution: |   Keywords:
+--
Changes (by gjm):

 * status:  new = accepted


-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/290#comment:1
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #217: Make Bloodhound's layout responsive

2012-12-07 Thread Apache Bloodhound
#217: Make Bloodhound's layout responsive
-+-
  Reporter:  jdreimann   |  Owner:  matevzb
  Type:  | Status:  assigned
  enhancement|  Milestone:
  Priority:  major   |Version:
 Component:  ui design   |   Keywords:  ui, responsive, bootstrap, mobile,
Resolution:  |  tablet, desktop
-+-
Changes (by jdreimann):

 * owner:  nobody = matevzb
 * status:  new = assigned


-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/217#comment:5
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #217: Make Bloodhound's layout responsive

2012-12-07 Thread Apache Bloodhound
#217: Make Bloodhound's layout responsive
-+-
  Reporter:  jdreimann   |  Owner:  matevzb
  Type:  | Status:  assigned
  enhancement|  Milestone:
  Priority:  major   |Version:
 Component:  ui design   |   Keywords:  ui, responsive, bootstrap, mobile,
Resolution:  |  tablet, desktop
-+-
Description changed by jdreimann:

Old description:

 I believe we should utilise Bootstrap's
 [http://twitter.github.com/bootstrap/scaffolding.html#responsive great
 tools for responsive layouts] to make Bloodhound fully responsive to make
 it display better on mobile phone and tablet type devices.

 [https://www.dropbox.com/s/c7hlp2n01ntwqfa/Bloodhound%20responsive%20ticket%20layout.png
 Mockup of a responsive view of the Ticket page]

 This will likely be a very big, long term project, and as such I believe
 we need to make a conscious effort to make it more manageable by keeping
 it in a 'beta' state even while Bloodhound itself matures, more on that
 in the following tickets:
 - Add responsive layout beta opt-in as an Admin setting
 - Show 'Responsive layout beta' at the top of relevant pages

 I also believe we should track this in an unscheduled Milestone
 independent of our normal release process.

New description:

 I believe we should utilise Bootstrap's
 [http://twitter.github.com/bootstrap/scaffolding.html#responsive great
 tools for responsive layouts] to make Bloodhound fully responsive to make
 it display better on mobile phone and tablet type devices.

 
[https://www.dropbox.com/s/c7hlp2n01ntwqfa/Bloodhound%20responsive%20ticket%20layout.png
 Original mockup of a responsive view of the Ticket page]

 [https://svn.apache.org/repos/asf/incubator/bloodhound/trunk/doc/html-
 templates/ticket.html HTML mockup]

 This will likely be a very big, long term project, and as such I believe
 we need to make a conscious effort to make it more manageable by keeping
 it in a 'beta' state even while Bloodhound itself matures, more on that in
 the following tickets:
 - Add responsive layout beta opt-in as an Admin setting
 - Show 'Responsive layout beta' at the top of relevant pages

 I also believe we should track this in an unscheduled Milestone
 independent of our normal release process.

--

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/217#comment:6
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #217: Make Bloodhound's layout responsive

2012-12-07 Thread Apache Bloodhound
#217: Make Bloodhound's layout responsive
-+-
  Reporter:  jdreimann   |  Owner:  matevzb
  Type:  | Status:  assigned
  enhancement|  Milestone:
  Priority:  major   |Version:
 Component:  ui design   |   Keywords:  ui, responsive, bootstrap, mobile,
Resolution:  |  tablet, desktop
-+-

Comment (by olemis):

 I didn't notice . There are two related patches written for #146 . I
 developed them to start with in-place editing web UI . Please review
 attachment:t146_r1418195_ticket_header.diff:ticket:146 and
 attachment:t146_r1418195_scrollspy_btn.diff:ticket:146

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/217#comment:7
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


[Apache Bloodhound] #291: Impossible to reply some comments in i.a.o after #290

2012-12-07 Thread Apache Bloodhound
#291: Impossible to reply some comments in i.a.o after #290
---+
Reporter:  olemis  |   Owner:  nobody
Type:  defect  |  Status:  new
Priority:  major   |   Component:  ui design
 Version:  |  Resolution:
---+


-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/291
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


[Apache Bloodhound] #292: Preview panel overlaps add comment box (i.a.o) - after #167

2012-12-07 Thread Apache Bloodhound
#292: Preview panel overlaps add comment box (i.a.o) - after #167
---+
Reporter:  olemis  |   Owner:  nobody
Type:  defect  |  Status:  new
Priority:  major   |   Component:  ui design
 Version:  |  Resolution:
---+


-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/292
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


[Apache Bloodhound] #293: footer whitelabelling results in footer specifying different apache projects

2012-12-07 Thread Apache Bloodhound
#293: footer whitelabelling results in footer specifying different apache
projects
---+
Reporter:  gjm |   Owner:  nobody
Type:  defect  |  Status:  new
Priority:  major   |   Component:  dashboard
 Version:  |  Resolution:
---+


-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/293
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #293: footer whitelabelling results in footer specifying different apache projects

2012-12-07 Thread Apache Bloodhound
#293: footer whitelabelling results in footer specifying different apache
projects
+
  Reporter:  gjm|  Owner:  nobody
  Type:  defect | Status:  new
  Priority:  major  |  Milestone:
 Component:  dashboard  |Version:
Resolution: |   Keywords:
+
Description changed by gjm:

Old description:



New description:

 {{{
 #!html
 a href=http://www.apache.org/;ApachesupTM/sup/a
 }}}
 is appearing as hardcoded in the footer.

--

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/293#comment:1
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin

2012-12-07 Thread Apache Bloodhound
#280: Move multiproduct.model.ModelBase to dashboard plugin
---+
  Reporter:  olemis|  Owner:  franco
  Type:  enhancement   | Status:  accepted
  Priority:  trivial   |  Milestone:
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  database model testing
---+

Comment (by olemis):

 Replying to [comment:5 rjollos]:
  I haven't seen the previous discussion in which it was decided to move
 common components to dashboard,

 There's no such record since that was one of the first decisions we made
 about Bloodhound . I'm not even sure we had neither mailing lists setup
 nor even project page at the time .

  but my initial impression is that it doesn't make much more sense to
 have them in dashboard than in multiproduct.
  I had a brief discussion about this with gjm this evening, and we both
 think it might make sense to move the components to a new
 `bloodhound_core` directory.

 At the time there was no much time to create and manage a new
 bloohound_core directory that noone knew what'd happen with it in the
 future . After considering both options we decided that shared assets
 would be placed in dashboard because all other plugins already depended
 upon it (for widgets).

  I  also think that `ModelBase.py` should be in `model.py` rather than
 `db.py`. My understanding is that only the schema and environment upgrade
 hooks should be in `db.py`.
 

 +1

  I've committed the fixes for the test cases in r1418224. Thank you
 franco and olemis!

 A big thank you for taking the the time to review and commit .
 :)

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:6
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin

2012-12-07 Thread Apache Bloodhound
#280: Move multiproduct.model.ModelBase to dashboard plugin
---+
  Reporter:  olemis|  Owner:
  Type:  enhancement   | Status:  new
  Priority:  trivial   |  Milestone:
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  database model testing
---+
Changes (by olemis):

 * owner:  franco =
 * status:  accepted = new


-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:7
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin

2012-12-07 Thread Apache Bloodhound
#280: Move multiproduct.model.ModelBase to dashboard plugin
---+
  Reporter:  olemis|  Owner:  olemis
  Type:  enhancement   | Status:  assigned
  Priority:  trivial   |  Milestone:
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  database model testing
---+
Changes (by olemis):

 * owner:   = olemis
 * status:  new = assigned


-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:8
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #146: Inline editing of objects

2012-12-07 Thread Apache Bloodhound
#146: Inline editing of objects
--+
  Reporter:  jdreimann|  Owner:  olemis
  Type:  enhancement  | Status:  accepted
  Priority:  critical |  Milestone:  Release 4
 Component:  dashboard|Version:
Resolution:   |   Keywords:  inplace bheditable
--+

Comment (by gjm):

 Replying to [comment:27 olemis]:
1. What happens after ticket enters editable state ?
 after edits we clearly need a Submit Changes button and a cancel button.
 Submission and cancelling probably imply a change back to the non-editable
 state so perhaps we need a revert button that only resets the fields as
 well?
2. What about workflow actions now that Modify Ticket section is gone?
 We still need the modify ticket area for that until there is an
 alternative solution for workflow.
3. Should description, keywords and summary be put into editable
   as well (... IMO they should , I'm just looking for
   confirmation ...) ?
 Yes.. until otherwise noted, we will require that.

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:28
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #146: Inline editing of objects

2012-12-07 Thread Apache Bloodhound
#146: Inline editing of objects
--+
  Reporter:  jdreimann|  Owner:  olemis
  Type:  enhancement  | Status:  accepted
  Priority:  critical |  Milestone:  Release 4
 Component:  dashboard|Version:
Resolution:   |   Keywords:  inplace bheditable
--+

Comment (by jdreimann):

 Replying to [comment:28 gjm]:
  Replying to [comment:27 olemis]:
 1. What happens after ticket enters editable state ?
  after edits we clearly need a Submit Changes button and a cancel button.
 Submission and cancelling probably imply a change back to the non-editable
 state so perhaps we need a revert button that only resets the fields as
 well?

 I think Submit button and a Cancel button (with `btn-link` class to show
 it's a secondary action) will be enough.

 2. What about workflow actions now that Modify Ticket section is
 gone?
  We still need the modify ticket area for that until there is an
 alternative solution for workflow.

 What stops us from workflow simply being a dropdown of options? `review,
 resolve, info request` etc.

 3. Should description, keywords and summary be put into editable
as well (... IMO they should , I'm just looking for
confirmation ...) ?
  Yes.. until otherwise noted, we will require that.
 +1

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:29
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #146: Inline editing of objects

2012-12-07 Thread Apache Bloodhound
#146: Inline editing of objects
--+
  Reporter:  jdreimann|  Owner:  olemis
  Type:  enhancement  | Status:  accepted
  Priority:  critical |  Milestone:  Release 4
 Component:  dashboard|Version:
Resolution:   |   Keywords:  inplace bheditable
--+

Comment (by gjm):

 Replying to [comment:29 jdreimann]:
  Replying to [comment:28 gjm]:
   Replying to [comment:27 olemis]:
  1. What happens after ticket enters editable state ?
   after edits we clearly need a Submit Changes button and a cancel
 button. Submission and cancelling probably imply a change back to the non-
 editable state so perhaps we need a revert button that only resets the
 fields as well?
 
  I think Submit button and a Cancel button (with `btn-link` class to show
 it's a secondary action) will be enough.

 Fair enough.. certainly good enough for now

 
  2. What about workflow actions now that Modify Ticket section is
 gone?
   We still need the modify ticket area for that until there is an
 alternative solution for workflow.
 
  What stops us from workflow simply being a dropdown of options? `review,
 resolve, info request` etc.

 I was thinking a similar way but the control is a little more complicated
 in needing a second input to change assignment for some actions. I don't
 know if there would be more cases to take into account with plugins that
 extend the functionality of course.

  3. Should description, keywords and summary be put into editable
 as well (... IMO they should , I'm just looking for
 confirmation ...) ?
   Yes.. until otherwise noted, we will require that.
  +1

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/146#comment:30
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin

2012-12-07 Thread Apache Bloodhound
#280: Move multiproduct.model.ModelBase to dashboard plugin
---+
  Reporter:  olemis|  Owner:  franco
  Type:  enhancement   | Status:  review
  Priority:  trivial   |  Milestone:
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  database model testing
---+
Changes (by franco):

 * status:  accepted = review


Comment:

 Until further discussion takes place, and it get to be finally decided if
 creating the new bloodhound_core directory, I have submitted two new
 revisions:
 [https://bitbucket.org/jose_angel_franco/bloodhound-
 dashboard/commits/9e3ae4c54bb8b93844088559686804a6]
 
[https://bitbucket.org/jose_angel_franco/bloodhound_multiproduct/commits/d39109663a717d7743109507fb22d335]
 moving ModelBase to model.py as accurately observed by rjollos.

 I pass the solution to revision state, you can grab the diffs here:

 
[https://bitbucket.org/jose_angel_franco/bloodhound_multiproduct/compare/t280_move_modelbase_to_dashboard..default]

 [https://bitbucket.org/jose_angel_franco/bloodhound-
 dashboard/compare/t280_move_modelbase_to_dashboard..default]

 Best regards,

 Franco
 Best regards,
 Franco.

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:10
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #292: Preview panel and modify ticket overlap add comment box (i.a.o) - after #167 (was: Preview panel overlaps add comment box (i.a.o) - after #167)

2012-12-07 Thread Apache Bloodhound
#292: Preview panel and modify ticket overlap add comment box (i.a.o) - after
#167
+
  Reporter:  olemis |  Owner:  nobody
  Type:  defect | Status:  new
  Priority:  major  |  Milestone:
 Component:  ui design  |Version:
Resolution: |   Keywords:
+

Old description:



New description:

 This issue is happening when ticket is already created and dynamic preview
 is rendered . After further insight , it consists of some panels
 overlaping on top of each other .

--

Comment (by olemis):

 #289 seems to be similar . I didn't understand very well what it was about
 so I created a separate ticket since I spotted the issue under different
 circumstances . Besides the problem is not just related to preview box ,
 it also affects modify ticket section ,  and other panels . So maybe we
 can use this ticket to check everything is ok under these particular
 circumstances .

 If they both are essentially the same issue then mark this ticket as
 duplicate . Otherwise , let's fix bugs in here .

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/292#comment:1
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #289: Create Ticket and Preview buttons are hidden on the Create New Ticket page

2012-12-07 Thread Apache Bloodhound
#289: Create Ticket and Preview buttons are hidden on the Create New Ticket page
+---
  Reporter:  rjollos|  Owner:  nobody
  Type:  defect | Status:  new
  Priority:  major  |  Milestone:  Release 4
 Component:  ui design  |Version:  0.2.0
Resolution: |   Keywords:
+---

Comment (by olemis):

 the exact version should be 0.3.0 . cmiiw

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/289#comment:2
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin

2012-12-07 Thread Apache Bloodhound
#280: Move multiproduct.model.ModelBase to dashboard plugin
---+
  Reporter:  olemis|  Owner:  franco
  Type:  enhancement   | Status:  review
  Priority:  trivial   |  Milestone:
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  database model testing
---+

Comment (by rjollos):

 Replying to [comment:6 olemis]:
  At the time there was no much time to create and manage a new
 bloohound_core directory that noone knew what'd happen with it in the
 future . After considering both options we decided that shared assets
 would be placed in dashboard because all other plugins already depended
 upon it (for widgets).

 Yeah, I understand. Been there ;)

 This ticket might not be the best place to tackle such a major
 reorganization. I'm also wondering if all of the `bloodhound_*` plugins
 should become a single plugin, so that we can have a single `setup.py` and
 a directory structure like:
 {{{
 bloodhound/model.py
 bloodhound/dashboard
 bloodhound/search
 }}}
 This would in some ways mirror the directory structure of Trac. Are there
 reasons we wouldn't want to do this?

 Im inclined to commit Franco's latest patch and leave these
 reorganization issues for another ticket.

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:11
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin

2012-12-07 Thread Apache Bloodhound
#280: Move multiproduct.model.ModelBase to dashboard plugin
---+
  Reporter:  olemis|  Owner:  franco
  Type:  enhancement   | Status:  review
  Priority:  trivial   |  Milestone:
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  database model testing
---+

Comment (by rjollos):

 Replying to [comment:10 franco]:
  Until further discussion takes place, and it get to be finally decided
 if creating the new bloodhound_core directory, I have submitted two new
 revisions:

 Thanks for the quick follow-up. Just a quick hint - to make the ticket
 comments a bit more readable, try using the following markup `[url
 label]`, where in this case label is the first 6 characters of the hash.
 That way we get nice inline links like:
 
[https://bitbucket.org/jose_angel_franco/bloodhound_multiproduct/commits/d39109663a717d7743109507fb22d335
 d39109].

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:12
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #280: Move multiproduct.model.ModelBase to dashboard plugin

2012-12-07 Thread Apache Bloodhound
#280: Move multiproduct.model.ModelBase to dashboard plugin
---+
  Reporter:  olemis|  Owner:  franco
  Type:  enhancement   | Status:  review
  Priority:  trivial   |  Milestone:
 Component:  multiproduct  |Version:
Resolution:|   Keywords:  database model testing
---+

Comment (by gjm):

 This is all fair comment. I am a little averse to making two changes where
 one would do but I can compromise on that for now.

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/280#comment:13
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #292: Preview panel and modify ticket overlap add comment box (i.a.o) - after #167

2012-12-07 Thread Apache Bloodhound
#292: Preview panel and modify ticket overlap add comment box (i.a.o) - after
#167
+
  Reporter:  olemis |  Owner:  nobody
  Type:  defect | Status:  new
  Priority:  major  |  Milestone:
 Component:  ui design  |Version:
Resolution: |   Keywords:
+

Comment (by olemis):

 Replying to [comment:2 rjollos]:
  Replying to [comment:1 olemis]:
   If they both are essentially the same issue then mark this ticket as
 duplicate . Otherwise , let's fix bugs in here .
 
  Works for me.

 good to know
 :)

  This has a fairly significant issue on usability,

 +1

  so it would be good to get the issue fixed soon.

 I'll take a look at it asap .

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/292#comment:3
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker


Re: [Apache Bloodhound] #292: Preview panel and modify ticket overlap add comment box (i.a.o) - after #167

2012-12-07 Thread Apache Bloodhound
#292: Preview panel and modify ticket overlap add comment box (i.a.o) - after
#167
+---
  Reporter:  olemis |  Owner:  olemis
  Type:  defect | Status:  accepted
  Priority:  critical   |  Milestone:  Release 4
 Component:  ui design  |Version:
Resolution: |   Keywords:
+---
Changes (by olemis):

 * owner:  nobody = olemis
 * priority:  major = critical
 * status:  new = accepted
 * cc: olemis+bh@… (added)
 * milestone:   = Release 4


Comment:

 I barely can see workflow actions ... but after a lot of fighting , I can
 finally accept this ticket .

-- 
Ticket URL: https://issues.apache.org/bloodhound/ticket/292#comment:4
Apache Bloodhound https://issues.apache.org/bloodhound/
The Apache Bloodhound (incubating) issue tracker