[jira] [Updated] (BOOKKEEPER-399) Let hub server could configure write quorum from ack quorum.

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-399: - Attachment: BOOKKEEPER-399.diff attach a patch to let hub server could configure write quorum

[jira] [Updated] (BOOKKEEPER-463) Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread Fangmin Lv (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Fangmin Lv updated BOOKKEEPER-463: -- Attachment: BOOKKEEPER-463.patch Provide a new patch according to Sijie and Flavio's sugges

Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread Fangmin Lv
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/ --- (Updated Nov. 29, 2012, 7:05 a.m.) Review request for bookkeeper. Changes

[jira] [Commented] (BOOKKEEPER-351) asyncAddEntry should not throw an exception

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506261#comment-13506261 ] Sijie Guo commented on BOOKKEEPER-351: -- [~merlimat] Is there any updates about th

[jira] [Commented] (BOOKKEEPER-389) add documentation for message filter.

2012-11-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506260#comment-13506260 ] Hadoop QA commented on BOOKKEEPER-389: -- Testing JIRA BOOKKEEPER-389 WARNING: Run

[jira] [Updated] (BOOKKEEPER-49) bookkeeper - parallel async read same entry of same ledger will fail

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-49?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-49: Fix Version/s: (was: 4.2.0) 4.3.0 > bookkeeper - parallel async read

[jira] [Commented] (BOOKKEEPER-49) bookkeeper - parallel async read same entry of same ledger will fail

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506256#comment-13506256 ] Sijie Guo commented on BOOKKEEPER-49: - In order to fix this issue, I think we need

[jira] [Commented] (BOOKKEEPER-410) Hedwig client should remove message handler while closing subscription

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506255#comment-13506255 ] Sijie Guo commented on BOOKKEEPER-410: -- I think after BOOKKEEPER-70, we had stopD

[jira] [Updated] (BOOKKEEPER-389) add documentation for message filter.

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-389: - Attachment: BOOKKEEPER-389.patch Attach a patch to document message filter features.

[jira] [Commented] (BOOKKEEPER-457) Create a format command for Hedwig to cleanup its metadata.

2012-11-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506219#comment-13506219 ] Hadoop QA commented on BOOKKEEPER-457: -- Testing JIRA BOOKKEEPER-457 WARNING: Run

Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread Fangmin Lv
> On Nov. 28, 2012, 6:10 p.m., fpj wrote: > > bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java, > > line 103 > > > > > > all the cases I've seen in this patch use ANY version, so

Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread Fangmin Lv
> On Nov. 27, 2012, 4:33 a.m., Sijie Guo wrote: > > bookkeeper-server/src/main/java/org/apache/bookkeeper/meta/AbstractZkLedgerManager.java, > > line 429 > > > > > > since AbstractZkLedgerManager is an abstract class,

Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread Fangmin Lv
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/#review13817 --- bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAnd

Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread Fangmin Lv
> On Nov. 28, 2012, 6:10 p.m., fpj wrote: > > bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java, > > line 87 > > > > > > what are the case(s) in which end would be -1? Sor

Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread Fangmin Lv
> On Nov. 28, 2012, 5:28 p.m., fpj wrote: > > here are some minor comments about the patch. I still want to think a bit > > more about the high-level approach taken here, though. Thanks Flavio, I will change the comments and method name according to your proposal, if there are problems about h

Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread Fangmin Lv
> On Nov. 27, 2012, 4:33 a.m., Sijie Guo wrote: > > great work, Fangmin. The patch looks good. Just had some minor comments, > > mostly about names and interface. Thanks sijie, will change the name and interface according to your comments. > On Nov. 27, 2012, 4:33 a.m., Sijie Guo wrote: > > b

[jira] [Updated] (BOOKKEEPER-457) Create a format command for Hedwig to cleanup its metadata.

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sijie Guo updated BOOKKEEPER-457: - Attachment: BOOKKEEPER-457.patch Attach a new patch addressing Ivan's comments.

[jira] [Commented] (BOOKKEEPER-249) Revisit garbage collection algorithm in Bookie server

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506136#comment-13506136 ] Sijie Guo commented on BOOKKEEPER-249: -- {quote} Let me give an example to illustr

[jira] [Commented] (BOOKKEEPER-464) Provide an improved GC algorithm

2012-11-28 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505906#comment-13505906 ] Flavio Junqueira commented on BOOKKEEPER-464: - Thanks, Sijie. I added a co

[jira] [Commented] (BOOKKEEPER-249) Revisit garbage collection algorithm in Bookie server

2012-11-28 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505905#comment-13505905 ] Flavio Junqueira commented on BOOKKEEPER-249: - Here is a thought for deali

[jira] [Commented] (BOOKKEEPER-464) Provide an improved GC algorithm

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505739#comment-13505739 ] Sijie Guo commented on BOOKKEEPER-464: -- {quote} If a bookie starts replicating a

Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread fpj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/#review13823 --- a few more comments. bookkeeper-server/src/main/java/org/apache/boo

[jira] [Commented] (BOOKKEEPER-482) Precommit is reporting findbugs errors in trunk

2012-11-28 Thread Sijie Guo (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505719#comment-13505719 ] Sijie Guo commented on BOOKKEEPER-482: -- ah, sorry, I missed this ticket. [~ikelly

Re: Review Request: Refactor garbage collection code for ease to plugin different GC algorithm.

2012-11-28 Thread fpj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/8141/#review13805 --- here are some minor comments about the patch. I still want to think a

[jira] [Resolved] (BOOKKEEPER-486) BOOKKEEPER-440 introduced 1 findbugs warning.

2012-11-28 Thread Ivan Kelly (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly resolved BOOKKEEPER-486. --- Resolution: Duplicate > BOOKKEEPER-440 introduced 1 findbugs warning. > -

[jira] [Reopened] (BOOKKEEPER-486) BOOKKEEPER-440 introduced 1 findbugs warning.

2012-11-28 Thread Ivan Kelly (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly reopened BOOKKEEPER-486: --- > BOOKKEEPER-440 introduced 1 findbugs warning. > ---

[jira] [Resolved] (BOOKKEEPER-486) BOOKKEEPER-440 introduced 1 findbugs warning.

2012-11-28 Thread Ivan Kelly (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Kelly resolved BOOKKEEPER-486. --- Resolution: Fixed > BOOKKEEPER-440 introduced 1 findbugs warning. > -

[jira] [Commented] (BOOKKEEPER-464) Provide an improved GC algorithm

2012-11-28 Thread Flavio Junqueira (JIRA)
[ https://issues.apache.org/jira/browse/BOOKKEEPER-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505487#comment-13505487 ] Flavio Junqueira commented on BOOKKEEPER-464: - Unless I'm misunderstanding

Build failed in Jenkins: bookkeeper-trunk #826

2012-11-28 Thread Apache Jenkins Server
See -- Started by timer Building remotely on ubuntu5 in workspace hudson.util.IOException2: remote file operation failed: