Re: Review Request 17895: BOOKKEEPER-582: protobuf support for bookkeeper

> On April 23, 2014, 10:22 a.m., Ivan Kelly wrote: > > bookkeeper-server/src/main/proto/BookkeeperProtocol.proto, line 80 > > > > > > This would be better served with a boolean. protobuf will keep it > > compact. > >

Re: Review Request 17895: BOOKKEEPER-582: protobuf support for bookkeeper

> On April 23, 2014, 10:22 a.m., Ivan Kelly wrote: > > ok. let me step back. how bad is the current protocol? if no, why we keep arguing on this? as those changes will break our system, then I don't see the value of contributing our patches back to the community. - Sijie --