[jira] [Commented] (BOOKKEEPER-582) Make bookie and client use protobuf for requests (non-wire part)

[ https://issues.apache.org/jira/browse/BOOKKEEPER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002777#comment-14002777 ] Sijie Guo commented on BOOKKEEPER-582: -- replies your comments, [~rakeshr] > Make

[jira] [Comment Edited] (BOOKKEEPER-582) Make bookie and client use protobuf for requests (non-wire part)

[ https://issues.apache.org/jira/browse/BOOKKEEPER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002777#comment-14002777 ] Sijie Guo edited comment on BOOKKEEPER-582 at 5/20/14 4:14 AM: -

Re: Review Request 17895: BOOKKEEPER-582: protobuf support for bookkeeper

> On April 23, 2014, 10:22 a.m., Ivan Kelly wrote: > > bookkeeper-server/src/main/proto/BookkeeperProtocol.proto, line 33 > > > > > > This should certainly not be an enum. Otherwise we need to bump the > > protocol ver

Re: Review Request 17895: BOOKKEEPER-582: protobuf support for bookkeeper

> On April 24, 2014, 12:19 p.m., Ivan Kelly wrote: > > bookkeeper-server/src/main/proto/BookkeeperProtocol.proto, line 81 > > > > > > ledgerId and entryId should be optional in all requests. It may be the > > case, tha

[jira] [Commented] (BOOKKEEPER-582) Make bookie and client use protobuf for requests (non-wire part)

[ https://issues.apache.org/jira/browse/BOOKKEEPER-582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001708#comment-14001708 ] Rakesh R commented on BOOKKEEPER-582: - Hi, Protobuf changes is very nice improveme

Re: Review Request 17895: BOOKKEEPER-582: protobuf support for bookkeeper

> On April 24, 2014, 12:19 p.m., Ivan Kelly wrote: > > bookkeeper-server/src/main/proto/BookkeeperProtocol.proto, line 81 > > > > > > ledgerId and entryId should be optional in all requests. It may be the > > case, tha

Re: Review Request 17895: BOOKKEEPER-582: protobuf support for bookkeeper

> On April 23, 2014, 10:22 a.m., Ivan Kelly wrote: > > bookkeeper-server/src/main/proto/BookkeeperProtocol.proto, line 33 > > > > > > This should certainly not be an enum. Otherwise we need to bump the > > protocol ver