[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14193777#comment-14193777
]
Rakesh R commented on BOOKKEEPER-634:
-
Thanks [~fpj] for the reminder. Unfortunate
[
https://issues.apache.org/jira/browse/BOOKKEEPER-789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159581#comment-14159581
]
Rakesh R commented on BOOKKEEPER-789:
-
+1 lgtm
> Update README to reflect bookkee
[
https://issues.apache.org/jira/browse/BOOKKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159579#comment-14159579
]
Rakesh R commented on BOOKKEEPER-589:
-
bq.I would follow what Ivan Kelly suggested
[
https://issues.apache.org/jira/browse/BOOKKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14159108#comment-14159108
]
Rakesh R commented on BOOKKEEPER-589:
-
I failed to see {{Incompatible change}} fie
[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14156087#comment-14156087
]
Rakesh R commented on BOOKKEEPER-634:
-
[~hustlmsp], [~iv...@yahoo-inc.com] thanks
[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154484#comment-14154484
]
Rakesh R commented on BOOKKEEPER-634:
-
Adding a note - If the new algo doesn't fit
[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14154466#comment-14154466
]
Rakesh R commented on BOOKKEEPER-634:
-
Attached a patch based on yesterday's propo
[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-634:
Attachment: 002-BOOKKEEPER-634-rename-bookieid-in-ledger.patch
> Provide admin tool to rename bo
[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14152886#comment-14152886
]
Rakesh R commented on BOOKKEEPER-634:
-
Thank you for the patience. I'd like to do
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151932#comment-14151932
]
Rakesh R commented on BOOKKEEPER-773:
-
Thank you [~iv...@yahoo-inc.com], [~hustlms
[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151499#comment-14151499
]
Rakesh R commented on BOOKKEEPER-634:
-
Ah! typo in my previous comment.
+1 movin
[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151440#comment-14151440
]
Rakesh R commented on BOOKKEEPER-634:
-
bq.btw, I think we stuck on these two ticke
[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14151166#comment-14151166
]
Rakesh R commented on BOOKKEEPER-634:
-
bq.why couldn't me just print how many ledg
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14150777#comment-14150777
]
Rakesh R commented on BOOKKEEPER-773:
-
Attached new patch. Here 2.3 steps has been
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-773:
Attachment: 011-BOOKKEEPER-773-rename-bookieid.patch
> Provide admin tool to rename bookie ident
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14145927#comment-14145927
]
Rakesh R commented on BOOKKEEPER-773:
-
*Diff*
a) Added 2.3. Verification steps bef
[
https://issues.apache.org/jira/browse/BOOKKEEPER-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144888#comment-14144888
]
Rakesh R commented on BOOKKEEPER-787:
-
Thanks [~iv...@yahoo-inc.com] for the discu
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144887#comment-14144887
]
Rakesh R commented on BOOKKEEPER-773:
-
Created BOOKKEEPER-787 for making Cookie im
[
https://issues.apache.org/jira/browse/BOOKKEEPER-787?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-787:
Attachment: BOOKKEEPER-787.patch
> Modify Cookie by removing 'znodeVersion' state/field
> --
[
https://issues.apache.org/jira/browse/BOOKKEEPER-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144630#comment-14144630
]
Rakesh R commented on BOOKKEEPER-787:
-
Thanks [~iv...@yahoo-inc.com] for the quick
[
https://issues.apache.org/jira/browse/BOOKKEEPER-787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14144599#comment-14144599
]
Rakesh R commented on BOOKKEEPER-787:
-
Thanks Ivan for the new idea. Let me try to
Rakesh R created BOOKKEEPER-787:
---
Summary: Modify Cookie by removing 'znodeVersion' state/field
Key: BOOKKEEPER-787
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-787
Project: Bookkeeper
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142946#comment-14142946
]
Rakesh R commented on BOOKKEEPER-773:
-
bq.I don't know what is the difference betw
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142923#comment-14142923
]
Rakesh R commented on BOOKKEEPER-773:
-
bq.2. I don't understand why you need a cop
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142377#comment-14142377
]
Rakesh R commented on BOOKKEEPER-773:
-
Attached new patch with the following chang
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-773:
Attachment: 010-BOOKKEEPER-773-rename-bookieid.patch
> Provide admin tool to rename bookie ident
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14142200#comment-14142200
]
Rakesh R commented on BOOKKEEPER-773:
-
Thanks Ivan, Sijie. Attached new patch with
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-773:
Attachment: 009-BOOKKEEPER-773-rename-bookieid.patch
> Provide admin tool to rename bookie ident
[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14138774#comment-14138774
]
Rakesh R commented on BOOKKEEPER-634:
-
Hi, Since I wrongly clubbed ledger_rename p
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-773:
Attachment: 008-BOOKKEEPER-773-rename-bookieid.patch
> Provide admin tool to rename bookie ident
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-773:
Attachment: 007-BOOKKEEPER-773-rename-bookieid.patch
> Provide admin tool to rename bookie ident
[
https://issues.apache.org/jira/browse/BOOKKEEPER-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137251#comment-14137251
]
Rakesh R commented on BOOKKEEPER-783:
-
There is one minor
[comment|https://issues
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-782:
Attachment: BOOKKEEPER-782.patch
> Use builder pattern for Cookie
>
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137213#comment-14137213
]
Rakesh R commented on BOOKKEEPER-782:
-
Awsome!. Thanks for the clear explanation.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-782:
Attachment: BOOKKEEPER-782.patch
> Use builder pattern for Cookie
>
[
https://issues.apache.org/jira/browse/BOOKKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137193#comment-14137193
]
Rakesh R commented on BOOKKEEPER-784:
-
{{testBookKeeperAdmin}} also has similar pr
[
https://issues.apache.org/jira/browse/BOOKKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R reassigned BOOKKEEPER-784:
---
Assignee: (was: Rakesh R)
> BookKeeperCloseTest#testLedgerCheck is failing intermitte
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14137166#comment-14137166
]
Rakesh R commented on BOOKKEEPER-782:
-
[~iv...@yahoo-inc.com] My bad, I didn't get
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136861#comment-14136861
]
Rakesh R commented on BOOKKEEPER-782:
-
bq.what you suggested before should be ok.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136852#comment-14136852
]
Rakesh R commented on BOOKKEEPER-784:
-
bq.This wouldn't change the fact that what
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136000#comment-14136000
]
Rakesh R commented on BOOKKEEPER-782:
-
Attached another patch
- used #generateCoo
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-782:
Attachment: BOOKKEEPER-782.patch
> Use builder pattern for Cookie
>
[
https://issues.apache.org/jira/browse/BOOKKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135369#comment-14135369
]
Rakesh R commented on BOOKKEEPER-784:
-
bq.the slowing of the bookie should avoid t
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14135333#comment-14135333
]
Rakesh R commented on BOOKKEEPER-782:
-
FYI, BOOKKEEPER-773 also has similar requir
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134961#comment-14134961
]
Rakesh R commented on BOOKKEEPER-782:
-
bq.as I commented before, we shouldn't have
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-782:
Attachment: BOOKKEEPER-782.patch
> Use builder pattern for Cookie
>
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14134127#comment-14134127
]
Rakesh R commented on BOOKKEEPER-782:
-
Thanks [~iv...@yahoo-inc.com]. Attached new
[
https://issues.apache.org/jira/browse/BOOKKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R reassigned BOOKKEEPER-784:
---
Assignee: Rakesh R
> BookKeeperCloseTest#testLedgerCheck is failing intermittently
>
[
https://issues.apache.org/jira/browse/BOOKKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14133125#comment-14133125
]
Rakesh R commented on BOOKKEEPER-784:
-
After analyzing the below exception, there
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14132566#comment-14132566
]
Rakesh R commented on BOOKKEEPER-782:
-
Attached new patch, here renamed 'CookieBui
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-782:
Attachment: BOOKKEEPER-782.patch
> Use builder pattern for Cookie
>
[
https://issues.apache.org/jira/browse/BOOKKEEPER-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131353#comment-14131353
]
Rakesh R commented on BOOKKEEPER-784:
-
I ran locally several times without any iss
Rakesh R created BOOKKEEPER-784:
---
Summary: BookKeeperCloseTest#testLedgerCheck is failing
intermittently
Key: BOOKKEEPER-784
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-784
Project: Bookkeeper
[
https://issues.apache.org/jira/browse/BOOKKEEPER-783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131236#comment-14131236
]
Rakesh R commented on BOOKKEEPER-783:
-
Could you rename the test method as now it
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14131160#comment-14131160
]
Rakesh R commented on BOOKKEEPER-782:
-
Thanks [~hustlmsp]. Please review.
> Use b
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-782:
Attachment: BOOKKEEPER-782.patch
> Use builder pattern for Cookie
>
[
https://issues.apache.org/jira/browse/BOOKKEEPER-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129942#comment-14129942
]
Rakesh R commented on BOOKKEEPER-775:
-
[Build-718
MultipleThreadReadTest#test1Led
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129898#comment-14129898
]
Rakesh R commented on BOOKKEEPER-773:
-
Thanks [~hustlmsp] for your time and quick
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-773:
Attachment: 006-BOOKKEEPER-773-rename-bookieid.patch
> Provide admin tool to rename bookie ident
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129852#comment-14129852
]
Rakesh R commented on BOOKKEEPER-782:
-
+Note:+ Cookie#setInstanceId() will return
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-782:
Attachment: BOOKKEEPER-782.patch
> Use builder pattern for Cookie
>
[
https://issues.apache.org/jira/browse/BOOKKEEPER-782?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-782:
Issue Type: Sub-task (was: Improvement)
Parent: BOOKKEEPER-639
> Use builder pattern fo
Rakesh R created BOOKKEEPER-782:
---
Summary: Use builder pattern for Cookie
Key: BOOKKEEPER-782
URL: https://issues.apache.org/jira/browse/BOOKKEEPER-782
Project: Bookkeeper
Issue Type: Improveme
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129730#comment-14129730
]
Rakesh R commented on BOOKKEEPER-773:
-
bq. otw I've to first iterate over all the
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129711#comment-14129711
]
Rakesh R commented on BOOKKEEPER-773:
-
bq.you pulled all ledgers into a list, whic
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14129694#comment-14129694
]
Rakesh R commented on BOOKKEEPER-773:
-
bq. This tool should focus on real producti
[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128246#comment-14128246
]
Rakesh R commented on BOOKKEEPER-634:
-
bq.The way that you get whole ledgers into
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14128244#comment-14128244
]
Rakesh R commented on BOOKKEEPER-773:
-
bq. If it is a blocker, then we should hold
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-773:
Attachment: 005-BOOKKEEPER-773-rename-bookieid.patch
> Provide admin tool to rename bookie ident
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-773:
Attachment: (was: 005-BOOKKEEPER-773-rename-bookieid.rar)
> Provide admin tool to rename boo
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-773:
Attachment: 005-BOOKKEEPER-773-rename-bookieid.rar
> Provide admin tool to rename bookie identif
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14125036#comment-14125036
]
Rakesh R commented on BOOKKEEPER-773:
-
I've tried an approach and attached the sam
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-773:
Attachment: 004-BOOKKEEPER-773-rename-bookieid.patch
> Provide admin tool to rename bookie ident
[
https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124413#comment-14124413
]
Rakesh R commented on BOOKKEEPER-736:
-
Thank you [~hustlmsp]. Nice work;-)
> Stat
[
https://issues.apache.org/jira/browse/BOOKKEEPER-778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-778:
Component/s: bookkeeper-client
> Flake in TestTryReadLastConfirmed
> ---
[
https://issues.apache.org/jira/browse/BOOKKEEPER-589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-589:
Component/s: Documentation
> Release notes update for non-BC changes
> -
[
https://issues.apache.org/jira/browse/BOOKKEEPER-778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-778:
Labels: tests (was: )
> Flake in TestTryReadLastConfirmed
> -
>
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124410#comment-14124410
]
Rakesh R commented on BOOKKEEPER-773:
-
If I understood your point correctly, shoul
[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14124404#comment-14124404
]
Rakesh R commented on BOOKKEEPER-634:
-
Thanks for the reminder [~hustlmsp]. As per
[
https://issues.apache.org/jira/browse/BOOKKEEPER-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119957#comment-14119957
]
Rakesh R commented on BOOKKEEPER-776:
-
Adding one thought: its good to check any c
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14119941#comment-14119941
]
Rakesh R commented on BOOKKEEPER-773:
-
I failed to see a way to define '-ledger' a
[
https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110935#comment-14110935
]
Rakesh R commented on BOOKKEEPER-736:
-
bq. I don't like the idea to mark every thi
[
https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110504#comment-14110504
]
Rakesh R commented on BOOKKEEPER-736:
-
There is a nice way to to differentiate thi
[
https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110451#comment-14110451
]
Rakesh R commented on BOOKKEEPER-736:
-
bq. please consider tests.
Tests can be mod
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110389#comment-14110389
]
Rakesh R commented on BOOKKEEPER-773:
-
Thanks Sijie for the feedback. I'll rebase
[
https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14110379#comment-14110379
]
Rakesh R commented on BOOKKEEPER-736:
-
bq.The way to keep a default constructor wi
[
https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14108833#comment-14108833
]
Rakesh R commented on BOOKKEEPER-736:
-
Make sense +1.
> Stats for AutoRecovery
>
[
https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14105737#comment-14105737
]
Rakesh R commented on BOOKKEEPER-736:
-
bq. rereplicate op stats already has a coun
[
https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098979#comment-14098979
]
Rakesh R commented on BOOKKEEPER-736:
-
bq. the stats of re-replication already giv
[
https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14098208#comment-14098208
]
Rakesh R commented on BOOKKEEPER-736:
-
bq. I don't know if NumUrLedgers, NumRerepl
[
https://issues.apache.org/jira/browse/BOOKKEEPER-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088873#comment-14088873
]
Rakesh R commented on BOOKKEEPER-774:
-
Good catch. +1 lgtm
> Flaky test
> org.ap
[
https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14088815#comment-14088815
]
Rakesh R commented on BOOKKEEPER-736:
-
Yeah, I agree the config items can be ignor
[
https://issues.apache.org/jira/browse/BOOKKEEPER-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087591#comment-14087591
]
Rakesh R commented on BOOKKEEPER-736:
-
[~hustlmsp] thanks for the patch. Could you
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14087336#comment-14087336
]
Rakesh R commented on BOOKKEEPER-773:
-
Thanks [~fpj] for the comments.
bq.I'm curi
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14083634#comment-14083634
]
Rakesh R commented on BOOKKEEPER-773:
-
[~hustlmsp] I've reworked and attached new
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-773:
Attachment: 003-BOOKKEEPER-773-rename-bookieid-in-cookies.patch
> Provide admin tool to rename
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14080832#comment-14080832
]
Rakesh R commented on BOOKKEEPER-773:
-
Thanks [~hustlmsp] for the reviews. After s
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-773:
Attachment: 002-BOOKKEEPER-773-rename-bookieid-in-cookies.patch
> Provide admin tool to rename
[
https://issues.apache.org/jira/browse/BOOKKEEPER-773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14074392#comment-14074392
]
Rakesh R commented on BOOKKEEPER-773:
-
I'm attaching a patch which exposes _rename
[
https://issues.apache.org/jira/browse/BOOKKEEPER-634?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rakesh R updated BOOKKEEPER-634:
Attachment: 001-BOOKKEEPER-634-rename-bookieid-in-ledger.patch
Attached new patch, just adding
1 - 100 of 755 matches
Mail list logo
