[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13407092#comment-13407092
]
Hudson commented on BOOKKEEPER-294:
---
Integrated in bookkeeper-trunk #592 (See
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13405726#comment-13405726
]
Ivan Kelly commented on BOOKKEEPER-294:
---
The tests don't check out for this.
In
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13405039#comment-13405039
]
Ivan Kelly commented on BOOKKEEPER-294:
---
I discussed this with Flavio last week,
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13405041#comment-13405041
]
Ivan Kelly commented on BOOKKEEPER-294:
---
Patch looks good. However, could you
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13405050#comment-13405050
]
Rakesh R commented on BOOKKEEPER-294:
-
Thanks Ivan. Latest patch addressing the
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13405114#comment-13405114
]
Ivan Kelly commented on BOOKKEEPER-294:
---
Latest patch looks good to me. +1. Will
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401208#comment-13401208
]
Rakesh R commented on BOOKKEEPER-294:
-
@Sijie
Could you please review the latest
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401270#comment-13401270
]
Rakesh R commented on BOOKKEEPER-294:
-
@Flavio
bq.After a comment from Ivan, I
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401279#comment-13401279
]
Flavio Junqueira commented on BOOKKEEPER-294:
-
Hi Rakesh, Check please the
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401324#comment-13401324
]
Flavio Junqueira commented on BOOKKEEPER-294:
-
My preference is 3 with no
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13401900#comment-13401900
]
Sijie Guo commented on BOOKKEEPER-294:
--
{quote}
+1 for wait/sleep solution.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13398479#comment-13398479
]
Rakesh R commented on BOOKKEEPER-294:
-
Attached latest patch.
Here I just done
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295545#comment-13295545
]
Uma Maheswara Rao G commented on BOOKKEEPER-294:
{quote}
I simply
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295588#comment-13295588
]
Rakesh R commented on BOOKKEEPER-294:
-
bq. Swapping these around is a good idea.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13296068#comment-13296068
]
Sijie Guo commented on BOOKKEEPER-294:
--
+1 for swapping.
Not
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13296108#comment-13296108
]
Sijie Guo commented on BOOKKEEPER-294:
--
If newBookie(conf) is I/O-intensive,
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294826#comment-13294826
]
Rakesh R commented on BOOKKEEPER-294:
-
Thanks Uma for pointing out. Since it helps
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294854#comment-13294854
]
Sijie Guo commented on BOOKKEEPER-294:
--
the patch is good except one place
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294906#comment-13294906
]
Uma Maheswara Rao G commented on BOOKKEEPER-294:
{quote}
my preference
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295017#comment-13295017
]
Ivan Kelly commented on BOOKKEEPER-294:
---
-1 on this approach.
We add a
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295020#comment-13295020
]
Uma Maheswara Rao G commented on BOOKKEEPER-294:
Abrupt kill (kill -9
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295029#comment-13295029
]
Ivan Kelly commented on BOOKKEEPER-294:
---
yes, kill -9 will skip shutdown hook,
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295028#comment-13295028
]
Flavio Junqueira commented on BOOKKEEPER-294:
-
bq. I agree to keep the
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295044#comment-13295044
]
Flavio Junqueira commented on BOOKKEEPER-294:
-
bq. If just the shutdown
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295050#comment-13295050
]
Ivan Kelly commented on BOOKKEEPER-294:
---
Yup, if the znode is still there, then
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295059#comment-13295059
]
Uma Maheswara Rao G commented on BOOKKEEPER-294:
@Flavio
{quote}
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295069#comment-13295069
]
Ivan Kelly commented on BOOKKEEPER-294:
---
{quote}
Cookies will guard from fake
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295086#comment-13295086
]
Rakesh R commented on BOOKKEEPER-294:
-
Thanks a lot Ivan for the good point.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295105#comment-13295105
]
Flavio Junqueira commented on BOOKKEEPER-294:
-
bq. As we thought before,
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295355#comment-13295355
]
Sijie Guo commented on BOOKKEEPER-294:
--
{quote}
you would have nothing to protect
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295366#comment-13295366
]
Sijie Guo commented on BOOKKEEPER-294:
--
{code}
$ bookkeeper-server/bin/bookkeeper
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295434#comment-13295434
]
Uma Maheswara Rao G commented on BOOKKEEPER-294:
{code}
I think we
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13295460#comment-13295460
]
Rakesh R commented on BOOKKEEPER-294:
-
Thanks everyone. If I understand the
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294219#comment-13294219
]
Flavio Junqueira commented on BOOKKEEPER-294:
-
I think this is included in
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294254#comment-13294254
]
Rakesh R commented on BOOKKEEPER-294:
-
Yeah. On bookie start up, it will delete
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294260#comment-13294260
]
Flavio Junqueira commented on BOOKKEEPER-294:
-
Right, I should have looked
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294268#comment-13294268
]
Flavio Junqueira commented on BOOKKEEPER-294:
-
Let me add another comment.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294280#comment-13294280
]
Sijie Guo commented on BOOKKEEPER-294:
--
I think we could do this assumption.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294311#comment-13294311
]
Rakesh R commented on BOOKKEEPER-294:
-
Thanks all. I have uploaded patch by
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294310#comment-13294310
]
Rakesh R commented on BOOKKEEPER-294:
-
Thanks all. I have uploaded patch by
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294360#comment-13294360
]
Rakesh R commented on BOOKKEEPER-294:
-
Thanks Flavio for the review.
Hope you are
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294462#comment-13294462
]
Rakesh R commented on BOOKKEEPER-294:
-
Oh! You meant zookeeper server will first
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294506#comment-13294506
]
Flavio Junqueira commented on BOOKKEEPER-294:
-
Yes, that's what I meant.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294512#comment-13294512
]
Rakesh R commented on BOOKKEEPER-294:
-
I didn't think about the ZK ordered
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294546#comment-13294546
]
Rakesh R commented on BOOKKEEPER-294:
-
:) Thanks, it looks more cleaner now.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13294808#comment-13294808
]
Uma Maheswara Rao G commented on BOOKKEEPER-294:
+1 from me as well.
46 matches
Mail list logo