[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13452915#comment-13452915
]
Vinay commented on BOOKKEEPER-300:
--
Thanks, Sijie for the review and commit, also Uma
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13449531#comment-13449531
]
Uma Maheswara Rao G commented on BOOKKEEPER-300:
+1 for the patch,
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13450373#comment-13450373
]
Hudson commented on BOOKKEEPER-300:
---
Integrated in bookkeeper-trunk #695 (See
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448553#comment-13448553
]
Uma Maheswara Rao G commented on BOOKKEEPER-300:
{code}
if (null !=
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448615#comment-13448615
]
Sijie Guo commented on BOOKKEEPER-300:
--
I don't like the style to pass a watcher
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448740#comment-13448740
]
Uma Maheswara Rao G commented on BOOKKEEPER-300:
@Vinay,
some minor
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447580#comment-13447580
]
Uma Maheswara Rao G commented on BOOKKEEPER-300:
Thank a lot, Vinay
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447592#comment-13447592
]
Uma Maheswara Rao G commented on BOOKKEEPER-300:
I have had gone
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447607#comment-13447607
]
Vinay commented on BOOKKEEPER-300:
--
Hi Uma,
Thanks for the Review and Suggestions for
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447620#comment-13447620
]
Sijie Guo commented on BOOKKEEPER-300:
--
{quote}
in createNewLMFactory
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447623#comment-13447623
]
Uma Maheswara Rao G commented on BOOKKEEPER-300:
Yes, Sijie. Just seen
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447624#comment-13447624
]
Vinay commented on BOOKKEEPER-300:
--
Hi Uma, here are some of the clarifications on
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13448028#comment-13448028
]
Uma Maheswara Rao G commented on BOOKKEEPER-300:
Thanks a lot, Vinay
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447289#comment-13447289
]
Sijie Guo commented on BOOKKEEPER-300:
--
ah, seems the patch has been a bit older.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13447478#comment-13447478
]
Vinay commented on BOOKKEEPER-300:
--
Yes Sijie,
I will post the re-based patch in
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442444#comment-13442444
]
Sijie Guo commented on BOOKKEEPER-300:
--
{code}
But, any way if the bookie started
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13442956#comment-13442956
]
Vinay commented on BOOKKEEPER-300:
--
@Sijie, thanks for the review.
{quote}It might
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439405#comment-13439405
]
Vinay commented on BOOKKEEPER-300:
--
Hi @Sijie,
{quote}What happened if a version 3
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439432#comment-13439432
]
Sijie Guo commented on BOOKKEEPER-300:
--
{quote}
BookieShell javadoc is saying
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439436#comment-13439436
]
Vinay commented on BOOKKEEPER-300:
--
You mean to say, if instanceid present in
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439598#comment-13439598
]
Sijie Guo commented on BOOKKEEPER-300:
--
{code}
+String instanceId =
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439639#comment-13439639
]
Vinay commented on BOOKKEEPER-300:
--
Thanks Sijie. I got it. Just need to make sure in
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13438503#comment-13438503
]
Vinay commented on BOOKKEEPER-300:
--
{quote}for layoutVersion 3, should not have
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13438729#comment-13438729
]
Sijie Guo commented on BOOKKEEPER-300:
--
{quote}
of-course, for layoutVersion 3
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13439272#comment-13439272
]
Rakesh R commented on BOOKKEEPER-300:
-
@Sijie
bq.BTW, for Bookie format, it would
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13437896#comment-13437896
]
Sijie Guo commented on BOOKKEEPER-300:
--
@Vinay, thanks for the patch. please
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13414863#comment-13414863
]
Vinay commented on BOOKKEEPER-300:
--
Thanks Siji for the detailed information and
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13415081#comment-13415081
]
Vinay commented on BOOKKEEPER-300:
--
One small doubt here. Since we are adding one
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13415129#comment-13415129
]
Sijie Guo commented on BOOKKEEPER-300:
--
@Vinay,
Cookie
It would be better to
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13414586#comment-13414586
]
Sijie Guo commented on BOOKKEEPER-300:
--
{quote}
I think format should just take
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13413880#comment-13413880
]
Uma Maheswara Rao G commented on BOOKKEEPER-300:
Thanks a lot, Vinay
[
https://issues.apache.org/jira/browse/BOOKKEEPER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13396547#comment-13396547
]
Rakesh R commented on BOOKKEEPER-300:
-
Format command would be similar as follows:
32 matches
Mail list logo
