[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539257#comment-13539257
]
Fangmin Lv commented on BOOKKEEPER-463:
---
@Flavio, @Ivan, @Sijie
Really appreciat
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539221#comment-13539221
]
Hudson commented on BOOKKEEPER-463:
---
Integrated in bookkeeper-trunk2 #8 (See
[https
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13539185#comment-13539185
]
Sijie Guo commented on BOOKKEEPER-463:
--
looks good to me. +1. will commit it.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538704#comment-13538704
]
Flavio Junqueira commented on BOOKKEEPER-463:
-
great, all trailing spaces
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538675#comment-13538675
]
Hadoop QA commented on BOOKKEEPER-463:
--
Testing JIRA BOOKKEEPER-463
Patch
[BOO
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538546#comment-13538546
]
Hadoop QA commented on BOOKKEEPER-463:
--
Testing JIRA BOOKKEEPER-463
Patch
[BOO
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538299#comment-13538299
]
Sijie Guo commented on BOOKKEEPER-463:
--
{quote}
Sure, but this case is particular
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538296#comment-13538296
]
Sijie Guo commented on BOOKKEEPER-463:
--
{quote}
Say that getChildrenInSingleNode
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13538271#comment-13538271
]
Flavio Junqueira commented on BOOKKEEPER-463:
-
bq. for most of interfaces,
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13536852#comment-13536852
]
Sijie Guo commented on BOOKKEEPER-463:
--
1. Created BOOKKEEPER-521 tracking the is
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535847#comment-13535847
]
Flavio Junqueira commented on BOOKKEEPER-463:
-
Most of my comments were ju
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13535688#comment-13535688
]
Sijie Guo commented on BOOKKEEPER-463:
--
{code}
We have both a meta package and me
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13534909#comment-13534909
]
Flavio Junqueira commented on BOOKKEEPER-463:
-
Here are some comments and
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532318#comment-13532318
]
Hadoop QA commented on BOOKKEEPER-463:
--
Testing JIRA BOOKKEEPER-463
Patch
[000
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532284#comment-13532284
]
Jiannan Wang commented on BOOKKEEPER-463:
-
Okay, I'll have a look the patch.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530014#comment-13530014
]
Flavio Junqueira commented on BOOKKEEPER-463:
-
[~lvfangmin] You may have m
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529968#comment-13529968
]
Fangmin Lv commented on BOOKKEEPER-463:
---
Hi sijie, actually the metastore based
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529765#comment-13529765
]
Fangmin Lv commented on BOOKKEEPER-463:
---
Ok, I will follow up what you're concer
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529717#comment-13529717
]
Sijie Guo commented on BOOKKEEPER-463:
--
one minor comment about this patch. I fou
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529651#comment-13529651
]
Fangmin Lv commented on BOOKKEEPER-463:
---
Thanks sijie, I will rebase on the new
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529632#comment-13529632
]
Sijie Guo commented on BOOKKEEPER-463:
--
[~lvfangmin] seems that the latest patch
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13529493#comment-13529493
]
Hadoop QA commented on BOOKKEEPER-463:
--
Testing JIRA BOOKKEEPER-463
Patch
[BOO
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13510929#comment-13510929
]
Hadoop QA commented on BOOKKEEPER-463:
--
Testing JIRA BOOKKEEPER-463
Patch
[BOO
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508462#comment-13508462
]
Sijie Guo commented on BOOKKEEPER-463:
--
After this jira, I would generate the doc
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13508461#comment-13508461
]
Sijie Guo commented on BOOKKEEPER-463:
--
I think this refactor could be done in 4.
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507176#comment-13507176
]
Hadoop QA commented on BOOKKEEPER-463:
--
Testing JIRA BOOKKEEPER-463
WARNING: Run
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505156#comment-13505156
]
Sijie Guo commented on BOOKKEEPER-463:
--
I would suggest this jira should go for 4
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504534#comment-13504534
]
Hadoop QA commented on BOOKKEEPER-463:
--
Testing JIRA BOOKKEEPER-463
WARNING: Run
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504380#comment-13504380
]
Fangmin Lv commented on BOOKKEEPER-463:
---
Thanks sijie, I will reply on the code
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13504368#comment-13504368
]
Sijie Guo commented on BOOKKEEPER-463:
--
[~lvfangmin] The patch looks good. I had
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501665#comment-13501665
]
Fangmin Lv commented on BOOKKEEPER-463:
---
@Yixue
Thanks for your command, I have
[
https://issues.apache.org/jira/browse/BOOKKEEPER-463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13501295#comment-13501295
]
Yixue (Andrew) Zhu commented on BOOKKEEPER-463:
---
The patch to
'bookkeep
32 matches
Mail list logo
