Re: [boost] Re: Formal Review: fixed-point decimal library

2003-07-21 Thread Jens Maurer
Bill Seymour wrote: > - A second, which instantiates all the output-related templates, > writes some interesting values like numeric_limits::min() > and tests the correct operations of the I/O manipulators and > rounding modes (as arguments to operator<<), locales, and narrow > and wide str

[boost] Re: Formal Review: fixed-point decimal library

2003-07-17 Thread Bill Seymour
Paul Bristow wrote: > > Overall I vote to accept this in the Boost library. > Thanks. > > There are some warnings using 'strict' which are probably > cast avoidable: > > fixed_decimal.hpp(442) : warning C4389: '==' : signed/unsigned mismatch > fixed_decimal.hpp(446) : warning C4018: '<' : signed/

[boost] Re: Formal Review: fixed-point decimal library

2003-07-15 Thread Fernando Cacciola
Bill, Bill Seymour <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > I've upload fixdec23.zip to the Yahoo files section. > > I made some changes that Jens suggested to allow compiling with > Comeau and gcc; and I've made the is_bounded and is_modulo fixes > that Fernando suggested alo

[boost] Re: Formal Review: fixed-point decimal library

2003-07-15 Thread Bill Seymour
I've upload fixdec23.zip to the Yahoo files section. I made some changes that Jens suggested to allow compiling with Comeau and gcc; and I've made the is_bounded and is_modulo fixes that Fernando suggested along with interoperatability with unsigned as well as int. Fernando, I think that max_sca

[boost] Re: Formal Review: fixed-point decimal library

2003-07-15 Thread Fernando Cacciola
Hi Bill, Yes, 'precision' is what I meant. I used the term' digits' because that's what is used for 'numeric_limits<>', but I much prefer 'precision'. There is one thing I noticed though that I'd like you to confirm: Because of the implementation (a normalized rep with two separate int_type member

[boost] Re: Formal Review: fixed-point decimal library

2003-07-15 Thread Bill Seymour
Fernando Cacciola wrote: > > OK. > So, correct me if I'm wrong: > For any given decimal with some int_type, a 'digits' constant is > associated with it which comes from numeric_limits::digits10. > This constant identifies the maxium number of digits (in both the > whole and fractional parts) that a

[boost] Re: Formal Review: fixed-point decimal library

2003-07-15 Thread Fernando Cacciola
Hi Bill, Bill Seymour <[EMAIL PROTECTED]> wrote in message news:[EMAIL PROTECTED] > Fernando, > > Thanks for your input. > > The "scale" really is intended to be the number of decimal digits > to the right of the decimal point; so, yes, if int_type on your > system is 64 bits, and if you specify a

[boost] Re: Formal Review: fixed-point decimal library

2003-07-15 Thread Bill Seymour
Fernando, Thanks for your input. The "scale" really is intended to be the number of decimal digits to the right of the decimal point; so, yes, if int_type on your system is 64 bits, and if you specify a scale of 18, then no /whole/ decimal digits will be allowed to the left of the point. (You mig

[boost] Re: Formal Review: fixed-point decimal library

2003-07-14 Thread Fernando Cacciola
Hi, this is my review of the Fixed-Point Decimal Library. I cannot vote as it is now. I will vote subject to the resolution of the 'scale' issue I explain below: Problems with 'scale': == To understand it, I wrote the following function which just creates two decimals given a