Re: [Bridge] 2.6.36-rc7: net/bridge causes temporary network I/O lockups [2]

2010-10-19 Thread Herbert Xu
On Mon, Oct 18, 2010 at 10:37:40PM +0200, Patrick Ringl wrote: > > Anything else I could possibly provide? :-) Yes, testing :) First of all I'd like to rule out (or in) the IPv6 query code, which is clearly generating a bogus packet (wrong payload_len). So can you apply this patch and see if it

Re: [Bridge] [PATCH] net: make ctl_path local and const

2010-10-19 Thread Changli Gao
On Wed, Oct 20, 2010 at 12:59 PM, Joe Perches wrote: > > Not using static requires the compiler to emit > initialization code for any use of the routine > that otherwise would only be done once. > If the code isn't performance critical, I think we can afford. Otherwise, we have to reserve the mem

Re: [Bridge] [PATCH] net: make ctl_path local and const

2010-10-19 Thread Changli Gao
On Wed, Oct 20, 2010 at 11:28 AM, Joe Perches wrote: > > At least some objects are smaller with static. > > $ size net/appletalk/sysctl_net_atalk.o.* >   text    data     bss     dec     hex filename >    324     236      48     608     260 > net/appletalk/sysctl_net_atalk.o.withstatic >    344  

Re: [Bridge] [PATCH] net: make ctl_path local and const

2010-10-19 Thread Changli Gao
On Wed, Oct 20, 2010 at 11:01 AM, Joe Perches wrote: > On Wed, 2010-10-20 at 10:54 +0800, Changli Gao wrote: >> Signed-off-by: Changli Gao > [] >> diff --git a/net/appletalk/sysctl_net_atalk.c >> b/net/appletalk/sysctl_net_atalk.c >> index 04e9c0d..b92f269 100644 >> --- a/net/appletalk/sysctl_ne

[Bridge] [PATCH] net: make ctl_path local and const

2010-10-19 Thread Changli Gao
Signed-off-by: Changli Gao --- net/appletalk/sysctl_net_atalk.c| 12 ++-- net/ax25/sysctl_net_ax25.c | 11 +-- net/bridge/br_netfilter.c | 13 +++-- net/dccp/sysctl.c | 14 +++--- net/decnet/sysctl_ne

Re: [Bridge] Giving enslaved interface an IP?

2010-10-19 Thread Thomas Taranowski
Thanks Stephen, ebtables looks like what I eventually need. I was able to resolve my short term problem by aliasing br0, and giving it a 192.168.10.1/24 address, so it receives traffic on both subnets. That seems to resolve the issue nicely. Thomas Taranowski Certified netburner consultant bari