Re: [Bridge] [PATCH] bridge: Fix possibly wrong MLD queries' ethernet source address

2011-03-22 Thread David Miller
From: Linus Lüssing Date: Tue, 22 Mar 2011 22:40:32 +0100 > The ipv6_dev_get_saddr() is currently called with an uninitialized > destination address. Although in tests it usually seemed to nevertheless > always fetch the right source address, there seems to be a possible race > condition. > > Th

Re: [Bridge] build breakage due to br_multicast.c referencing ipv6_dev_get_saddr()

2011-03-22 Thread Linus Lüssing
> One unrelated other observation with this change of yours: > daddr is an input argument to ipv6_dev_get_saddr(), yet > it gets initialized only after the function was called. Is that > really correct? Hmm, that wasn't intentional. I tested that again and so far I still always got the right source

[Bridge] [PATCH] bridge: Fix possibly wrong MLD queries' ethernet source address

2011-03-22 Thread Linus Lüssing
The ipv6_dev_get_saddr() is currently called with an uninitialized destination address. Although in tests it usually seemed to nevertheless always fetch the right source address, there seems to be a possible race condition. Therefore this commit changes this, first setting the destination address