Re: [Bridge] [PATCH] bridge: return value for br_stp_recalculate_bridge_id()

2011-03-30 Thread Stephen Hemminger
On Wed, 30 Mar 2011 14:23:27 +0800 Dongdong Deng dongdong.d...@windriver.com wrote: Return 'false' for user has set a mac addr case in br_stp_recalculate_bridge_id() function. and this could address the following build warning: net/bridge/br_stp_if.c: In function

Re: [Bridge] [PATCH] bridge: mcast snooping, fix IPv6 MLD checksum calculation

2011-03-30 Thread David Miller
From: Linus Lüssing linus.luess...@web.de Date: Sun, 27 Mar 2011 08:27:23 +0200 In contrast to IGMP, the MLDv1/2 message checksum needs to include an IPv6 pseudo-header in the calculations (see RFC2710, section 3.3; RFC3810, section 5.1.2). The multicast snooping feature of the bridge code

Re: [Bridge] [PATCH] bridge: mcast snooping, fix length check of snooped MLDv1/2

2011-03-30 Thread David Miller
From: Linus Lüssing linus.luess...@web.de Date: Sun, 27 Mar 2011 08:27:24 +0200 len = ntohs(ip6h-payload_len) does not include the length of the ipv6 header itself, which the rest of this function assumes, though. This leads to a length check less restrictive as it should be in the

Re: [Bridge] 802.1q tagging broken when used with bridging in 2.6.38

2011-03-30 Thread Benny Amorsen
igor serebryany igo...@moomers.org writes: now, i want to assign eth0 to a bridge brctl addbr xenbr0 ifconfig xenbr0 up brctl addif xenbr0 eth0 I may be misunderstanding your topology, but I would have expected that you would want to brctl addif xenbr0 eth0.234? It is unusual to bridge an

Re: [Bridge] 802.1q tagging broken when used with bridging in 2.6.38

2011-03-30 Thread Igor Serebryany
On Wed, Mar 30, 2011 at 04:46:46PM +0200, Benny Amorsen wrote: now, i want to assign eth0 to a bridge brctl addbr xenbr0 ifconfig xenbr0 up brctl addif xenbr0 eth0 I may be misunderstanding your topology, but I would have expected that you would want to brctl addif xenbr0 eth0.234?

Re: [Bridge] [PATCH] BRIDGE: As per 802.1D clause 9.3.4 Added support to prevent processing port's own BPDU (If a loopback condition exists)

2011-03-30 Thread Stephen Hemminger
On Wed, 30 Mar 2011 21:03:36 +0530 Sasikanth V sasikanth@gmail.com wrote: Signed-off-by: Sasikanth V sasikanth@gmail.com --- net/bridge/br_private.h |1 + net/bridge/br_stp.c | 20 ++-- net/bridge/br_stp_if.c|2 ++ net/bridge/br_stp_timer.c |

Re: [Bridge] 802.1q tagging broken when used with bridging in 2.6.38

2011-03-30 Thread Igor Serebryany
On Tue, Mar 29, 2011 at 03:18:44PM -0400, Andy Gospodarek wrote: I have no idea what version Igor was using before. Even if Igor's upgrade as not from 2.6.37, this sounds like a regression. I am using debian, and in Sid the kernel versions go from 2.6.32 to 2.6.37. I had a chance to test

Re: [Bridge] [PATCH] BRIDGE: As per 802.1D clause 9.3.4 Added support to prevent processing port's own BPDU (If a loopback condition exists)

2011-03-30 Thread Sasikanth V
On Wed, Mar 30, 2011 at 9:55 PM, Stephen Hemminger shemmin...@vyatta.comwrote: On Wed, 30 Mar 2011 21:03:36 +0530 Sasikanth V sasikanth@gmail.com wrote: Signed-off-by: Sasikanth V sasikanth@gmail.com --- net/bridge/br_private.h |1 + net/bridge/br_stp.c | 20