[Bridge] [PATCH] bridge: Module use count must be updated as bridges are created/destroyed

2011-04-29 Thread Jan Beulich
Otherwise 'modprobe -r' on a module having a dependency on bridge will implicitly unload bridge, bringing down all connectivity that was using bridges. Signed-off-by: Jan Beulich jbeul...@novell.com Cc: Jeff Mahoney je...@suse.com --- net/bridge/br_if.c |9 + 1 file changed, 9

Re: [Bridge] [PATCH] bridge: Module use count must be updated as bridges are created/destroyed

2011-04-29 Thread Jan Beulich
On 29.04.11 at 09:25, David Miller da...@davemloft.net wrote: From: Jan Beulich jbeul...@novell.com Date: Fri, 29 Apr 2011 08:21:14 +0100 Otherwise 'modprobe -r' on a module having a dependency on bridge will implicitly unload bridge, bringing down all connectivity that was using bridges.

Re: [Bridge] [PATCH] bridge: Module use count must be updated as bridges are created/destroyed

2011-04-29 Thread Jan Beulich
On 29.04.11 at 10:10, David Miller da...@davemloft.net wrote: From: Jan Beulich jbeul...@novell.com Date: Fri, 29 Apr 2011 08:41:10 +0100 You talk of rmmod on the very module, but the issue is about modprobe -r on a dependent module. I cannot believe you consider it correct that *implicit*

Re: [Bridge] [PATCH] bridge: Module use count must be updated as bridges are created/destroyed

2011-04-29 Thread Jan Beulich
On 29.04.11 at 10:44, David Miller da...@davemloft.net wrote: From: Jan Beulich jbeul...@novell.com Date: Fri, 29 Apr 2011 09:31:27 +0100 On 29.04.11 at 10:10, David Miller da...@davemloft.net wrote: From: Jan Beulich jbeul...@novell.com Date: Fri, 29 Apr 2011 08:41:10 +0100 You talk of

Re: [Bridge] [PATCH] bridge: Module use count must be updated as bridges are created/destroyed

2011-04-29 Thread Stephen Hemminger
On Fri, 29 Apr 2011 00:25:30 -0700 (PDT) David Miller da...@davemloft.net wrote: From: Jan Beulich jbeul...@novell.com Date: Fri, 29 Apr 2011 08:21:14 +0100 Otherwise 'modprobe -r' on a module having a dependency on bridge will implicitly unload bridge, bringing down all connectivity that

Re: [Bridge] [PATCH] bridge: Module use count must be updated as bridges are created/destroyed

2011-04-29 Thread Jan Beulich
On 29.04.11 at 18:05, Jon Masters jonat...@jonmasters.org wrote: On Fri, 2011-04-29 at 13:08 +0200, Michal Marek wrote: On 29.4.2011 11:09, Jan Beulich wrote: On 29.04.11 at 10:44, David Millerda...@davemloft.net wrote: Nothing on the system should be hitting modules with unload requests

[Bridge] no wireless interfaces?

2011-04-29 Thread jharvell+lists.bri...@dogpad.net
I tried to bridge a wireless interface to a wired Ethernet interface, and it failed with Operation not supported. Looking at the kernel code, it seems like this is intentional. I noticed the following in br_add_if: /* No bridging devices that dislike that (e.g. wireless) */ if

Re: [Bridge] no wireless interfaces?

2011-04-29 Thread Stephen Hemminger
On Fri, 29 Apr 2011 11:36:28 -0500 jharvell+lists.bri...@dogpad.net jharvell+lists.bri...@dogpad.net wrote: I tried to bridge a wireless interface to a wired Ethernet interface, and it failed with Operation not supported. Looking at the kernel code, it seems like this is intentional. I

Re: [Bridge] [PATCH] bridge: Module use count must be updated as bridges are created/destroyed

2011-04-29 Thread Michal Marek
On 29.4.2011 11:09, Jan Beulich wrote: On 29.04.11 at 10:44, David Millerda...@davemloft.net wrote: From: Jan Beulichjbeul...@novell.com Date: Fri, 29 Apr 2011 09:31:27 +0100 On 29.04.11 at 10:10, David Millerda...@davemloft.net wrote: From: Jan Beulichjbeul...@novell.com Date: Fri, 29

[Bridge] no wireless interfaces?

2011-04-29 Thread Joe Harvell
I tried to bridge a wireless interface to a wired Ethernet interface, and it failed with Operation not supported. Looking at the kernel code, it seems like this is intentional. I noticed the following in br_add_if: /* No bridging devices that dislike that (e.g. wireless) */ if

Re: [Bridge] [PATCH] bridge: Module use count must be updated as bridges are created/destroyed

2011-04-29 Thread Jon Masters
On Fri, 2011-04-29 at 13:08 +0200, Michal Marek wrote: On 29.4.2011 11:09, Jan Beulich wrote: On 29.04.11 at 10:44, David Millerda...@davemloft.net wrote: Nothing on the system should be hitting modules with unload requests unless the user explicitly asked for that specific module to be

Re: [Bridge] no wireless interfaces?

2011-04-29 Thread Joel Wiramu Pauling
Because 802.11a/b/g/n does odd things with mac headers which make bridging them sometimes not work as expected. On 30 April 2011 04:33, Joe Harvell joe.harv...@tektronix.com wrote: I tried to bridge a wireless interface to a wired Ethernet interface, and it failed with Operation not supported.