[Bridge] RHEL 6 stack corruption bug in bridge code identified

2011-11-02 Thread Daniel Robbins
Hi Stephen, The OpenVZ developers have identified a linux bridging stack corruption bug in the RHEL 6 kernel: http://bugzilla.openvz.org/show_bug.cgi?id=2016#c15 Can you confirm that this appears to be a stack corruption bug? Has it already been fixed? If so, which kernel has it fixed? If not,

Re: [Bridge] [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish()

2011-11-02 Thread Stephen Hemminger
On Wed, 02 Nov 2011 23:08:57 +0400 Vasily Averin v...@parallels.com wrote: if dst is not local br_handle_frame_finish() does not clone original skb and forgets to reset IPCB before return to IP stack. it can lead to stack corruption in icmp_send() Signed-off-by: Vasily Averin v...@sw.ru

Re: [Bridge] [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish()

2011-11-02 Thread Daniel Robbins
On Wed, Nov 2, 2011 at 1:31 PM, Stephen Hemminger shemmin...@vyatta.com wrote: What kernel version are you using? There were several previous fixes in br_netfilter to deal with this type of issue over the last year. It's a kernel from this obscure company called Red Hat, and they include it in

Re: [Bridge] [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish()

2011-11-02 Thread David Miller
From: Vasily Averin v...@parallels.com Date: Wed, 02 Nov 2011 23:08:57 +0400 if dst is not local br_handle_frame_finish() does not clone original skb and forgets to reset IPCB before return to IP stack. it can lead to stack corruption in icmp_send() Signed-off-by: Vasily Averin v...@sw.ru

Re: [Bridge] [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish()

2011-11-02 Thread Stephen Hemminger
On Wed, 2 Nov 2011 13:45:29 -0600 Daniel Robbins drobb...@funtoo.org wrote: On Wed, Nov 2, 2011 at 1:31 PM, Stephen Hemminger shemmin...@vyatta.com wrote: What kernel version are you using? There were several previous fixes in br_netfilter to deal with this type of issue over the last

Re: [Bridge] [PATCH] bridge: Reset IPCB on forward non-local packets in br_handle_frame_finish()

2011-11-02 Thread Daniel Robbins
On Wed, Nov 2, 2011 at 2:14 PM, Stephen Hemminger shemmin...@vyatta.com wrote: The pay for their tech support and have them fix it. BTW - the problem was fixed upstream a long time ago, the upstream kernel moves fast and RHEL probably froze many months before their release. OK, thanks for