Re: [Bridge] [PATCH net-next 0/4] Allow bridge to function in non-promisc mode

2013-03-13 Thread Vlad Yasevich
On 03/13/2013 02:22 AM, "Oleg A. Arkhangelsky" wrote: 13.03.2013, 05:45, "Vlad Yasevich" : The series adds an ability for the bridge to function in non-promiscuous mode. What is the practical applications for such setup? In other words, in which cases I would want to put bridge into non-pro

Re: [Bridge] [PATCH net-next 1/4] bridge: Add sysfs interface to control promisc mode

2013-03-13 Thread Stephen Hemminger
On Tue, 12 Mar 2013 21:45:23 -0400 Vlad Yasevich wrote: > Add an sysfs interface to turn promiscusous mode on and off on > the bridge. By default all interfaces in the bridge > are in promisc mode. When promisc mode is turned off, it is > turned off on all bridge ports and the bridge turns on I

Re: [Bridge] [PATCH net-next 0/4] Allow bridge to function in non-promisc mode

2013-03-13 Thread Stephen Hemminger
On Wed, 13 Mar 2013 08:12:29 -0400 Vlad Yasevich wrote: > On 03/13/2013 02:22 AM, "Oleg A. Arkhangelsky" wrote: > > > > > > 13.03.2013, 05:45, "Vlad Yasevich" : > > > >> The series adds an ability for the bridge to function in non-promiscuous > >> mode. > > > > What is the practical applications

Re: [Bridge] [PATCH net-next 1/4] bridge: Add sysfs interface to control promisc mode

2013-03-13 Thread Vlad Yasevich
On 03/13/2013 11:38 AM, Stephen Hemminger wrote: On Tue, 12 Mar 2013 21:45:23 -0400 Vlad Yasevich wrote: Add an sysfs interface to turn promiscusous mode on and off on the bridge. By default all interfaces in the bridge are in promisc mode. When promisc mode is turned off, it is turned off o

Re: [Bridge] [PATCH net-next 0/4] Allow bridge to function in non-promisc mode

2013-03-13 Thread Vlad Yasevich
On 03/13/2013 11:39 AM, Stephen Hemminger wrote: On Wed, 13 Mar 2013 08:12:29 -0400 Vlad Yasevich wrote: On 03/13/2013 02:22 AM, "Oleg A. Arkhangelsky" wrote: 13.03.2013, 05:45, "Vlad Yasevich" : The series adds an ability for the bridge to function in non-promiscuous mode. What is the

Re: [Bridge] [PATCH net-next 0/4] Allow bridge to function in non-promisc mode

2013-03-13 Thread Stephen Hemminger
On Wed, 13 Mar 2013 11:45:40 -0400 Vlad Yasevich wrote: > On 03/13/2013 11:39 AM, Stephen Hemminger wrote: > > On Wed, 13 Mar 2013 08:12:29 -0400 > > Vlad Yasevich wrote: > > > >> On 03/13/2013 02:22 AM, "Oleg A. Arkhangelsky" wrote: > >>> > >>> > >>> 13.03.2013, 05:45, "Vlad Yasevich" : > >>> >

[Bridge] Problem with multicast traffic when using network bridging

2013-03-13 Thread Adam Baker
After upgrading the kernel on the box that acts as a bridge between my wireless and wired networks I observed that access to my UPnP media servers became unreliable. I tried a number of kernel versions to attempt to establish when things went wrong and got as far as 3.4 - works 3.5.7 - doesn

Re: [Bridge] [PATCH] bridge-utils: Fix compile against linux-3.8.x

2013-03-13 Thread Russell Senior
Linux 3.8 has a header, include/uapi/linux/if_bridge.h that uses a struct in6_addr but doesn't define it. The trivial seeming fix of including the header that does define it causes more problems. The problem was discussed on mailing lists in January 2013. The final suggestion I found was here:

Re: [Bridge] [RFC PATCH net-next 3/3] bridge: Implement IFF_UNICAST_FLT

2013-03-13 Thread John Fastabend
On 03/06/2013 06:31 PM, Vlad Yasevich wrote: Implement IFF_UNICAST_FLT on the bridge. Unicast addresses added to the bridge device are synched to the uplink devices. This allows for uplink devices to change while preserving mac assignment. Signed-off-by: Vlad Yasevich --- [...] diff --git

Re: [Bridge] [Patch net] bridge: do not expire mdb entry when bridge still uses it

2013-03-13 Thread Adam Baker
On 08/03/13 02:07, Cong Wang wrote: From: Cong Wang This is a long-standing bug and reported several times: https://bugzilla.redhat.com/show_bug.cgi?id=880035 http://marc.info/?l=linux-netdev&m=136164389416341&w=2 This bug can be observed in virt environment, when a KVM guest communicates with

[Bridge] [PATCH -next] bridge: using for_each_set_bit_from to simplify the code

2013-03-13 Thread Wei Yongjun
From: Wei Yongjun Using for_each_set_bit_from() to simplify the code. Signed-off-by: Wei Yongjun --- net/bridge/br_fdb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index b0812c9..48fe761 100644 --- a/net/bridge/br_fdb.c +++

[Bridge] [PATCH -next] bridge: using for_each_set_bit to simplify the code

2013-03-13 Thread Wei Yongjun
From: Wei Yongjun Using for_each_set_bit() to simplify the code. Signed-off-by: Wei Yongjun --- net/bridge/br_netlink.c | 5 + net/bridge/br_fdb.c | 10 ++ 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c index 27

[Bridge] [PATCH] bridge: netfilter: use PTR_RET instead of IS_ERR + PTR_ERR

2013-03-13 Thread Silviu-Mihai Popescu
This uses PTR_RET instead of IS_ERR and PTR_ERR in order to increase readability. Signed-off-by: Silviu-Mihai Popescu --- net/bridge/netfilter/ebtable_broute.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/bridge/netfilter/ebtable_broute.c b/net/bridge/netfilter/

Re: [Bridge] [PATCH net-next 0/4] Allow bridge to function in non-promisc mode

2013-03-13 Thread "Oleg A. Arkhangelsky"
13.03.2013, 05:45, "Vlad Yasevich" : > The series adds an ability for the bridge to function in non-promiscuous mode. What is the practical applications for such setup? In other words, in which cases I would want to put bridge into non-promiscuous mode and specify some uplink ports? -- wbr, O

Re: [Bridge] [PATCH net-next 0/4] Allow bridge to function in non-promisc mode

2013-03-13 Thread Vlad Yasevich
On 03/13/2013 12:09 PM, Stephen Hemminger wrote: On Wed, 13 Mar 2013 11:45:40 -0400 Vlad Yasevich wrote: On 03/13/2013 11:39 AM, Stephen Hemminger wrote: On Wed, 13 Mar 2013 08:12:29 -0400 Vlad Yasevich wrote: On 03/13/2013 02:22 AM, "Oleg A. Arkhangelsky" wrote: 13.03.2013, 05:45, "Vla

Re: [Bridge] [PATCH net-next 0/4] Allow bridge to function in non-promisc mode

2013-03-13 Thread Joel Wirāmu Pauling
I agree that this is a useful behavior, often we will use a bridge in the same scenario (multiple virtio tap adapters belonging to VM's) another scenario is when creating a bridge for chaining multiple VPN's together. -Joel On 14 March 2013 06:04, Vlad Yasevich wrote: > On 03/13/2013 12:09 PM, S

Re: [Bridge] [PATCH net-next 0/4] Allow bridge to function in non-promisc mode

2013-03-13 Thread Michael S. Tsirkin
On Wed, Mar 13, 2013 at 01:04:51PM -0400, Vlad Yasevich wrote: > On 03/13/2013 12:09 PM, Stephen Hemminger wrote: > >On Wed, 13 Mar 2013 11:45:40 -0400 > >Vlad Yasevich wrote: > > > >>On 03/13/2013 11:39 AM, Stephen Hemminger wrote: > >>>On Wed, 13 Mar 2013 08:12:29 -0400 > >>>Vlad Yasevich wrote

Re: [Bridge] [PATCH net-next 0/4] Allow bridge to function in non-promisc mode

2013-03-13 Thread Michael S. Tsirkin
On Tue, Mar 12, 2013 at 09:45:22PM -0400, Vlad Yasevich wrote: > The series adds an ability for the bridge to function in non-promiscuous mode. > We do it in 3 steps. > First we add an interface to palce the switch into non-promisc mode. In > this mode, all port of the switch turn promisc off and

Re: [Bridge] [PATCH net-next 2/4] bridge: Allow an ability to designate an uplink port

2013-03-13 Thread Michael S. Tsirkin
On Tue, Mar 12, 2013 at 09:45:24PM -0400, Vlad Yasevich wrote: > Allow a ports to be designated as uplink. Multiple ports > may be designated as uplinks and they will be kept in a > list. > > Signed-off-by: Vlad Yasevich It looks like if you make two links uplink, bridging between them won't wo

Re: [Bridge] [PATCH net-next 2/4] bridge: Allow an ability to designate an uplink port

2013-03-13 Thread Stephen Hemminger
On Wed, 13 Mar 2013 22:33:33 +0200 "Michael S. Tsirkin" wrote: > On Tue, Mar 12, 2013 at 09:45:24PM -0400, Vlad Yasevich wrote: > > Allow a ports to be designated as uplink. Multiple ports > > may be designated as uplinks and they will be kept in a > > list. > > > > Signed-off-by: Vlad Yasevich

Re: [Bridge] [PATCH net-next 2/4] bridge: Allow an ability to designate an uplink port

2013-03-13 Thread Vlad Yasevich
On 03/13/2013 04:33 PM, Michael S. Tsirkin wrote: On Tue, Mar 12, 2013 at 09:45:24PM -0400, Vlad Yasevich wrote: Allow a ports to be designated as uplink. Multiple ports may be designated as uplinks and they will be kept in a list. Signed-off-by: Vlad Yasevich It looks like if you make two