Re: [Bridge] [PATCHv2] bridge: disable snooping if there is no querier

2013-07-25 Thread Linus Lüssing
On Thu, Jul 25, 2013 at 09:01:40AM -0700, Stephen Hemminger wrote: > On Thu, 25 Jul 2013 15:56:20 +0200 > Linus Lüssing wrote: > > > > > +static void br_multicast_update_querier_timer(struct net_bridge *br, > > + unsigned long max_delay) > > +{ > > + if

Re: [Bridge] [PATCHv2] bridge: disable snooping if there is no querier

2013-07-25 Thread Stephen Hemminger
On Thu, 25 Jul 2013 15:56:20 +0200 Linus Lüssing wrote: > > +static void br_multicast_update_querier_timer(struct net_bridge *br, > + unsigned long max_delay) > +{ > + if (!timer_pending(&br->multicast_querier_timer)) > + atomic64_set(&b

[Bridge] [PATCHv2] bridge: disable snooping if there is no querier

2013-07-25 Thread Linus Lüssing
If there is no querier on a link then we won't get periodic reports and therefore won't be able to learn about multicast listeners behind ports, potentially leading to lost multicast packets, especially for multicast listeners that joined before the creation of the bridge. These lost multicast pac

[Bridge] [PATCH] bridge: disable snooping if there is no querier

2013-07-25 Thread Linus Lüssing
If there is no querier on a link then we won't get periodic reports and therefore won't be able to learn about multicast listeners behind ports, potentially leading to lost multicast packets, especially for multicast listeners that joined before the creation of the bridge. These lost multicast pac