[Bridge] [PATCHv2 net-next 2/4] bridge: adhere to querier election mechanism specified by RFCs

2014-05-24 Thread Linus Lüssing
MLDv1 (RFC2710 section 6), MLDv2 (RFC3810 section 7.6.2), IGMPv2 (RFC2236 section 3) and IGMPv3 (RFC3376 section 6.6.2) specify that the querier with lowest source address shall become the selected querier. So far the bridge stopped its querier as soon as it heard another querier regardless of its

[Bridge] [PATCHv2 net-next 4/4] bridge: memorize and export selected IGMP/MLD querier port

2014-05-24 Thread Linus Lüssing
Adding bridge support to the batman-adv multicast optimization requires batman-adv knowing about the existence of bridged-in IGMP/MLD queriers to be able to reliably serve any multicast listener behind this same bridge. Signed-off-by: Linus Lüssing --- include/linux/if_bridge.h |1 + net/bri

[Bridge] [PATCHv2 net-next 3/4] bridge: add export of multicast database adjacent to net_dev

2014-05-24 Thread Linus Lüssing
With this new, exported function br_multicast_list_adjacent(net_dev) a list of IPv4/6 addresses is returned. This list contains all multicast addresses sensed by the bridge multicast snooping feature on all bridge ports of the bridge interface of net_dev, excluding addresses from the specified net_

[Bridge] [PATCHv2 net-next 1/4] bridge: rename struct bridge_mcast_query/querier

2014-05-24 Thread Linus Lüssing
The current naming of these two structs is very random, in that reversing their naming would not make any semantical difference. This patch tries to make the naming less confusing by giving them a more specific, distinguishable naming. This is also useful for the upcoming patches reintroducing th

[Bridge] [PATCHv2 net-next 0/4] bridge: multicast snooping patches / exports

2014-05-24 Thread Linus Lüssing
Changes in v2: * fix a nasty typo in PATCH 1/4, br_multicast_update_query_timer(): "br->multicast_query_interval" vs. "br->multicast_querier_interval" => this accidentally reduced the other querier present timer from 255 to 125 seconds * fix a typo in PATCH 2/4, br_ip{4,6}_multicast_quer

Re: [Bridge] Revert 462fb2af9788a82a534f8184abfde31574e1cfa0 (bridge : Sanitize skb before it enters the IP stack)

2014-05-24 Thread David Miller
From: David Newall Date: Sun, 25 May 2014 12:02:03 +0930 > On 25/05/14 03:13, David Miller wrote: >> This patch was substantially corrupted by your email client. > > We should be sending these things as mime attachments. Having to put > patches inline is brittle, absurd and a waste of everyone'

Re: [Bridge] randconfig build error with next-20140523, in net/bridge/br_netfilter.c

2014-05-24 Thread David Miller
From: Jim Davis Date: Fri, 23 May 2014 13:06:48 -0700 > Building with the attached random configuration file, > > warning: (BRIDGE_NF_EBTABLES) selects NETFILTER_XTABLES which has > unmet direct dependencies (NET && INET && NETFILTER) > warning: (NF_TABLES_BRIDGE && BRIDGE_NF_EBTABLES) selects >

Re: [Bridge] Revert 462fb2af9788a82a534f8184abfde31574e1cfa0 (bridge : Sanitize skb before it enters the IP stack)

2014-05-24 Thread David Miller
From: Bart De Schuymer Date: Thu, 22 May 2014 20:57:13 +0200 > Please apply following patch: This patch was corrupted and wouldn't apply cleanly. But I applied it by hand for you, because clearly (as has been the case for some time) you don't care.

Re: [Bridge] Revert 462fb2af9788a82a534f8184abfde31574e1cfa0 (bridge : Sanitize skb before it enters the IP stack)

2014-05-24 Thread David Miller
From: David Newall Date: Sat, 24 May 2014 15:26:24 +0930 > The patch now reverts the commit and mitigates the original problem by > ensuring bridge's use of cb does not overlap ip's. This patch was substantially corrupted by your email client.