Re: [Bridge] Revert 462fb2af9788a82a534f8184abfde31574e1cfa0 (bridge : Sanitize skb before it enters the IP stack)

2014-06-02 Thread David Newall
On 31/05/14 10:16, David Miller wrote: I don't see why you don't simply keep br_parse_ip_options() around and adjust it as you need, you're just mostly duplicating it's contents into br_nf_pre_routing(). More accurately, I'm *restoring* br_parse_ip_options()'s contents to br_nf_pre_routing().

Re: [Bridge] Revert 462fb2af9788a82a534f8184abfde31574e1cfa0 (bridge : Sanitize skb before it enters the IP stack)

2014-06-02 Thread David Newall
On 30/05/14 08:04, David Miller wrote: You really need to check the return value as this can perform allocations, GFP_ATOMIC ones in fact. Also, why are we not bumping the statistics any more? I didn't see a discussion of that in this thread. I was only restoring the code as it was before the

Re: [Bridge] [PATCH net] bridge: Prevent insertion of FDB entry with disallowed vlan

2014-06-02 Thread David Miller
From: Vlad Yasevich Date: Mon, 02 Jun 2014 10:22:10 -0400 > On 05/30/2014 06:48 PM, David Miller wrote: >> From: Toshiaki Makita >> Date: Mon, 26 May 2014 15:15:53 +0900 >> >>> br_handle_local_finish() is allowing us to insert an FDB entry with >>> disallowed vlan. For example, when port 1 and

[Bridge] [PATCHv3 net-next 0/4] bridge: multicast snooping patches / exports

2014-06-02 Thread Linus Lüssing
Changes in v3: * use EXPORT_SYMBOL_GPL() instead of EXPORT_SYMBOL() Cheers

[Bridge] [PATCHv3 net-next 4/4] bridge: memorize and export selected IGMP/MLD querier port

2014-06-02 Thread Linus Lüssing
Adding bridge support to the batman-adv multicast optimization requires batman-adv knowing about the existence of bridged-in IGMP/MLD queriers to be able to reliably serve any multicast listener behind this same bridge. Signed-off-by: Linus Lüssing --- include/linux/if_bridge.h |1 + net/bri

[Bridge] [PATCHv3 net-next 2/4] bridge: adhere to querier election mechanism specified by RFCs

2014-06-02 Thread Linus Lüssing
MLDv1 (RFC2710 section 6), MLDv2 (RFC3810 section 7.6.2), IGMPv2 (RFC2236 section 3) and IGMPv3 (RFC3376 section 6.6.2) specify that the querier with lowest source address shall become the selected querier. So far the bridge stopped its querier as soon as it heard another querier regardless of its

[Bridge] [PATCHv3 net-next 3/4] bridge: add export of multicast database adjacent to net_dev

2014-06-02 Thread Linus Lüssing
With this new, exported function br_multicast_list_adjacent(net_dev) a list of IPv4/6 addresses is returned. This list contains all multicast addresses sensed by the bridge multicast snooping feature on all bridge ports of the bridge interface of net_dev, excluding addresses from the specified net_

[Bridge] [PATCHv3 net-next 1/4] bridge: rename struct bridge_mcast_query/querier

2014-06-02 Thread Linus Lüssing
The current naming of these two structs is very random, in that reversing their naming would not make any semantical difference. This patch tries to make the naming less confusing by giving them a more specific, distinguishable naming. This is also useful for the upcoming patches reintroducing th

Re: [Bridge] [PATCH net] bridge: Prevent insertion of FDB entry with disallowed vlan

2014-06-02 Thread Vlad Yasevich
On 05/30/2014 06:48 PM, David Miller wrote: > From: Toshiaki Makita > Date: Mon, 26 May 2014 15:15:53 +0900 > >> br_handle_local_finish() is allowing us to insert an FDB entry with >> disallowed vlan. For example, when port 1 and 2 are communicating in >> vlan 10, and even if vlan 10 is disallowe