Re: [Bridge] [PATCH v2 net-next] bridge: Fix incorrect judgment of promisc

2014-06-05 Thread David Miller
From: Toshiaki Makita Date: Thu, 5 Jun 2014 20:53:32 +0900 > br_manage_promisc() incorrectly expects br_auto_port() to return only 0 > or 1, while it actually returns flags, i.e., a subset of BR_AUTO_MASK. > > Signed-off-by: Toshiaki Makita I'm applying this as-is for now, even though I saw t

Re: [Bridge] [PATCHv3 net-next 0/4] bridge: multicast snooping patches / exports

2014-06-05 Thread David Miller
From: Linus Lüssing Date: Thu, 5 Jun 2014 23:20:16 +0200 > Oh, I'm sorry, I thought it'd only be necessary for the v1 > patchset. Going to change that from now on. Anyways, here it is > (copied 'n' pasted): When I ask for changes, you need to make a new fresh submission of your patch(s).

Re: [Bridge] [PATCHv3 net-next 0/4] bridge: multicast snooping patches / exports

2014-06-05 Thread Linus Lüssing
On Thu, Jun 05, 2014 at 12:43:11AM -0700, David Miller wrote: > From: Linus Lüssing > Date: Mon, 2 Jun 2014 20:42:15 +0200 > > > Changes in v3: > > > > * use EXPORT_SYMBOL_GPL() instead of EXPORT_SYMBOL() > > This is not a sufficient header posting. > > You must also describe at a high level

Re: [Bridge] [PATCH net-next] bridge: Fix incorrect judgment of promisc

2014-06-05 Thread Vlad Yasevich
On 06/05/2014 08:55 AM, David Laight wrote: > From: Toshiaki Makita >> (2014/06/05 20:03), David Laight wrote: >>> From: Toshiaki Makita br_manage_promisc() incorrectly expects br_auto_port() to return only 0 or 1, while it actually returns flags, i.e., a subset of BR_AUTO_MASK.

Re: [Bridge] [PATCH v2 net-next] bridge: Fix incorrect judgment of promisc

2014-06-05 Thread Vlad Yasevich
On 06/05/2014 09:01 AM, Toshiaki Makita wrote: > (2014/06/05 21:30), Michael S. Tsirkin wrote: >> On Thu, Jun 05, 2014 at 08:53:32PM +0900, Toshiaki Makita wrote: >>> br_manage_promisc() incorrectly expects br_auto_port() to return only 0 >>> or 1, while it actually returns flags, i.e., a subset of

Re: [Bridge] [PATCH net-next] bridge: Fix incorrect judgment of promisc

2014-06-05 Thread Toshiaki Makita
(2014/06/05 21:55), David Laight wrote: > From: Toshiaki Makita >> (2014/06/05 20:03), David Laight wrote: >>> From: Toshiaki Makita br_manage_promisc() incorrectly expects br_auto_port() to return only 0 or 1, while it actually returns flags, i.e., a subset of BR_AUTO_MASK. Sig

Re: [Bridge] [PATCH v2 net-next] bridge: Fix incorrect judgment of promisc

2014-06-05 Thread Toshiaki Makita
(2014/06/05 21:30), Michael S. Tsirkin wrote: > On Thu, Jun 05, 2014 at 08:53:32PM +0900, Toshiaki Makita wrote: >> br_manage_promisc() incorrectly expects br_auto_port() to return only 0 >> or 1, while it actually returns flags, i.e., a subset of BR_AUTO_MASK. >> >> Signed-off-by: Toshiaki Makita

Re: [Bridge] [PATCH v2 net-next] bridge: Fix incorrect judgment of promisc

2014-06-05 Thread Michael S. Tsirkin
On Thu, Jun 05, 2014 at 08:53:32PM +0900, Toshiaki Makita wrote: > br_manage_promisc() incorrectly expects br_auto_port() to return only 0 > or 1, while it actually returns flags, i.e., a subset of BR_AUTO_MASK. > > Signed-off-by: Toshiaki Makita > --- > net/bridge/br_if.c | 3 ++- > 1 file chan

[Bridge] [PATCH v2 net-next] bridge: Fix incorrect judgment of promisc

2014-06-05 Thread Toshiaki Makita
br_manage_promisc() incorrectly expects br_auto_port() to return only 0 or 1, while it actually returns flags, i.e., a subset of BR_AUTO_MASK. Signed-off-by: Toshiaki Makita --- net/bridge/br_if.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/bridge/br_if.c b/net/brid

Re: [Bridge] [PATCH net-next] bridge: Fix incorrect judgment of promisc

2014-06-05 Thread Toshiaki Makita
(2014/06/05 20:03), David Laight wrote: > From: Toshiaki Makita >> br_manage_promisc() incorrectly expects br_auto_port() to return only 0 >> or 1, while it actually returns flags, i.e., a subset of BR_AUTO_MASK. >> >> Signed-off-by: Toshiaki Makita >> --- >> net/bridge/br_if.c | 2 +- >> 1 file

[Bridge] [PATCH net-next] bridge: Fix incorrect judgment of promisc

2014-06-05 Thread Toshiaki Makita
br_manage_promisc() incorrectly expects br_auto_port() to return only 0 or 1, while it actually returns flags, i.e., a subset of BR_AUTO_MASK. Signed-off-by: Toshiaki Makita --- net/bridge/br_if.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_if.c b/net/bridge

Re: [Bridge] [PATCHv3 net-next 0/4] bridge: multicast snooping patches / exports

2014-06-05 Thread David Miller
From: Linus Lüssing Date: Mon, 2 Jun 2014 20:42:15 +0200 > Changes in v3: > > * use EXPORT_SYMBOL_GPL() instead of EXPORT_SYMBOL() This is not a sufficient header posting. You must also describe at a high level what this patch series is doing, and why you are doing it.