Re: [Bridge] Put virbr0 in promiscuous mode

2014-11-25 Thread Sagar Shedge
Hi Stephen, Extremely sorry for typo. I have made changes and are as follows :- I have two virtual machines VM1 and VM2 on KVM (ubuntu 14.04 LTS 3.13.0-24-generic). Then I have added eth0 of my VM to 'default' network (NAT network). Use case :- I want to monitor all traffic on virbr0('default'

Re: [Bridge] Bridge Consuming LACP PDUs

2014-11-25 Thread Stephen Hemminger
On Tue, 25 Nov 2014 17:07:12 -0800 jogesh panda wrote: > Hello > > Thanks for the reply. This still does not solve my problem for forwarding > LACP PDU ( 01-80-C2-00-00-02 ). LACP PDU's are not supposed to be forwarded. I had some discussion with 802 committee about it.

Re: [Bridge] Bridge Consuming LACP PDUs

2014-11-25 Thread jogesh panda
Hello Thanks for the reply. This still does not solve my problem for forwarding LACP PDU ( 01-80-C2-00-00-02 ). It throws the following error, echo 2 > /sys/class/net/brx/bridge/group_fwd_mask bash: echo: write error: Invalid argument, I suppose this error is from this piece of code in file

Re: [Bridge] Bridge Consuming LACP PDUs

2014-11-25 Thread Stephen Hemminger
On Tue, 25 Nov 2014 10:12:02 -0800 jogesh panda wrote: > Hi > > I have two virtual machine. In side each VM, there is a Switch emulation. > Two create connection between emulated switches, I have create Tutap > Interfaces in the host which are seen as Virtual Interfaces inside the VMs. > The tun

[Bridge] Bridge Consuming LACP PDUs

2014-11-25 Thread jogesh panda
Hi I have two virtual machine. In side each VM, there is a Switch emulation. Two create connection between emulated switches, I have create Tutap Interfaces in the host which are seen as Virtual Interfaces inside the VMs. The tuntap Interfaces are connected by brctl bridge. I am having problem wi

Re: [Bridge] Put virbr0 in promiscuous mode

2014-11-25 Thread Stephen Hemminger
On Mon, 24 Nov 2014 18:59:49 +0530 Sagar Shedge wrote: > Steps followed :- > 1. Add VM1 eth0 to virbr0 > 2. Add VM2 eth1 to virbr0 > 3. brctl setageing ovsbr0 0 ..(To put bridge in promiscuous) ovsbr0 is Open Vswitch not linux bridge

[Bridge] Put virbr0 in promiscuous mode

2014-11-25 Thread Sagar Shedge
Hi , I have two virtual machines VM1 and VM2 on KVM (ubuntu 14.04 LTS 3.13.0-24-generic). Then I have added eth0 of my VM to 'default' network (NAT network). Use case :- I want to monitor all traffic on virbr0('default' network). Steps followed :- 1. Add VM1 eth0 to virbr0 2. Add VM2 eth1 to vi

Re: [Bridge] [PATCH] bridge: fix netfilter/NF_BR_LOCAL_OUT for own, locally generated queries

2014-11-25 Thread Linus Lüssing
On Mon, Nov 03, 2014 at 06:01:46AM +0800, Herbert Xu wrote: > On Mon, Sep 22, 2014 at 01:32:44AM +0200, Linus Lüssing wrote: > > Signed-off-by: Linus Lüssing > > Acked-by: Herbert Xu Hi David, are there any unanswered questions left? Cheers, Linus

Re: [Bridge] [PATCH] bridge: missing null bridge device check causing null pointer dereference (bugfix)

2014-11-25 Thread 박수현
My appologies, I was working on kernel 3.2.30 when I hit the crash. I only looked at the up-to-date kernel for br_handle_frame function where I still found "p->state" reference. Please disregard my patch. Thanks, Su-Hyun Park -Original Message- From: Eric Dumazet [mailto:eric.duma...@

Re: [Bridge] [PATCH] bridge: missing null bridge device check causing null pointer dereference (bugfix)

2014-11-25 Thread 박수현
>-Original Message- >From: Toshiaki Makita [mailto:makita.toshi...@lab.ntt.co.jp] >Sent: Thursday, November 06, 2014 4:07 PM >To: 박수현; Stephen Hemminger; David S. Miller >Cc: bridge@lists.linux-foundation.org; net...@vger.kernel.org; linux- >ker...@vger.kernel.org >Subject: Re: [PATCH] brid

[Bridge] [PATCH] bridge: missing null bridge device check causing null pointer dereference (bugfix)

2014-11-25 Thread Su-Hyun Park
the bridge device can be null if the bridge is being deleted while processing the packet, which causes the null pointer dereference in switch statement. crash dump snippet: <1>BUG: unable to handle kernel NULL pointer dereference at 0021 <1>IP: [] br_handle_frame+0xe6/0x270 <0>Code:

[Bridge] [PATCH] netfilter: nft_reject_bridge: Fix powerpc build error

2014-11-25 Thread Guenter Roeck
Fix: net/bridge/netfilter/nft_reject_bridge.c: In function 'nft_reject_br_send_v6_unreach': net/bridge/netfilter/nft_reject_bridge.c:240:3: error: implicit declaration of function 'csum_ipv6_magic' csum_ipv6_magic(&nip6h->saddr, &nip6h->daddr, ^ make[3]: *** [net/bridge/netfilter/nft_

Re: [Bridge] [PATCH] bridge: fix netfilter/NF_BR_LOCAL_OUT for own, locally generated queries

2014-11-25 Thread Linus Lüssing
On Mon, Sep 22, 2014 at 01:32:44AM +0200, Linus Lüssing wrote: > Ebtables on the OUTPUT chain (NF_BR_LOCAL_OUT) would not work as expected > for both locally generated IGMP and MLD queries. The IP header specific > filter options are off by 14 Bytes for netfilter (actual output on > interfaces is f

Re: [Bridge] arm64 allmodconfig failures in nft_reject_bridge.c

2014-11-25 Thread Mark Brown
On Thu, Nov 13, 2014 at 03:23:53PM -0500, David Miller wrote: > Date: Thu, 13 Nov 2014 19:47:52 + > > On Thu, Nov 13, 2014 at 02:35:13PM -0500, David Miller wrote: > >> I hold changes in my tree for a week or more, because I want them to > >> "cook" there before they go to Linus. > > Hrm. G

Re: [Bridge] arm64 allmodconfig failures in nft_reject_bridge.c

2014-11-25 Thread Mark Brown
On Thu, Nov 13, 2014 at 12:43:57PM +0100, Pablo Neira Ayuso wrote: > I can see this in David's tree: > http://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit/?id=c1207c049b204b0a96535dc5416aee331b51e0e1 > I think this was reported by when -rc4 was already out, so you'll see > this by -

Re: [Bridge] arm64 allmodconfig failures in nft_reject_bridge.c

2014-11-25 Thread Mark Brown
On Thu, Nov 13, 2014 at 02:35:13PM -0500, David Miller wrote: > I hold changes in my tree for a week or more, because I want them to > "cook" there before they go to Linus. Hrm. Guess there must've been some other change in -next that pulled the header in implicitly here :( > So if it takes a w

Re: [Bridge] arm64 allmodconfig failures in nft_reject_bridge.c

2014-11-25 Thread Mark Brown
Since about -rc3 we've been seeing build failures in Linus' tree on arm64 allmodconfig due to: > arm64-allmodconfig > ../net/bridge/netfilter/nft_reject_bridge.c:240:3: error: implicit > declaration of function 'csum_ipv6_magic' > [-Werror=implicit-function-declaration] By the time I look