Re: [Bridge] [PATCH RFCv3 2/4] net: Export IGMP/MLD message validation code

2015-04-07 Thread David Miller
From: Linus Lüssing Date: Tue, 7 Apr 2015 21:57:30 +0200 > With this patch, the IGMP and MLD message validation functions are moved > from the bridge code to the IPv4/IPv6 multicast files. Some small > refactoring was done to enhance readibility and to iron out some > differences in behaviour be

[Bridge] [PATCH RFCv3 3/4] batman-adv: Forward IGMP/MLD reports to selected querier (only)

2015-04-07 Thread Linus Lüssing
With this patch IGMP or MLD reports are only forwarded to the selected IGMP/MLD querier as RFC4541 suggests. This is necessary to avoid multicast packet loss in bridged scenarios later: An IGMPv2/MLDv1 querier does not actively join the multicast group the reports are sent to. Because of this, thi

[Bridge] [PATCH RFCv3 4/4] batman-adv: Increase BATADV_TVLV_MCAST version number to 2

2015-04-07 Thread Linus Lüssing
The multicast optimizations bridge integration will require the just implemented IGMP/MLD report handling later. Therefore bumping the version number. --- net/batman-adv/multicast.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/net/batman-adv/multicast.c b/net/ba

[Bridge] [PATCH RFCv3 2/4] net: Export IGMP/MLD message validation code

2015-04-07 Thread Linus Lüssing
With this patch, the IGMP and MLD message validation functions are moved from the bridge code to the IPv4/IPv6 multicast files. Some small refactoring was done to enhance readibility and to iron out some differences in behaviour between the IGMP and MLD parsing code (e.g. the skb-cloning of MLD mes

[Bridge] [PATCH RFCv3 1/4] bridge: multicast: call skb_checksum_{simple_, }validate

2015-04-07 Thread Linus Lüssing
Let's use these new, neat helpers. Signed-off-by: Linus Lüssing --- net/bridge/br_multicast.c | 28 1 file changed, 4 insertions(+), 24 deletions(-) diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c index c465876..3c630c7 100644 --- a/net/bridge/b

[Bridge] [PATCH RFCv3 0/4] batman-adv: Unicasting multicast reports to querier-node only

2015-04-07 Thread Linus Lüssing
The last round of multicast patches send to the batman-adv mailinglist to add support for the multicast optimizations in bridged scenarios, too, unfortunately had one major conceptual flaw: It could lead to packet loss. It's not sufficient to have the unicasting of reports implemented on bridge-nod