Re: [Bridge] [net-next v3] bridge: trigger RTM_NEWLINK when interface is modified by bridge ioctl

2017-10-11 Thread Vincent Bernat
❦ 21 septembre 2017 08:15 -0700, Stephen Hemminger  : >> Currently, there is a difference in netlink events received when an >> interface is modified through bridge ioctl() or through netlink. This >> patch generates additional events when an interface is added to or

Re: [Bridge] [PATCH 7/7] SUNRPC: make kvec const

2017-10-11 Thread Jeff Layton
On Fri, 2017-08-25 at 19:51 +0530, Bhumika Goyal wrote: > Make this const as it is only used during a copy operation. > > Signed-off-by: Bhumika Goyal > --- > net/sunrpc/xdr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/sunrpc/xdr.c

Re: [Bridge] [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-10-11 Thread Vincent Bernat
❦ 21 septembre 2017 08:09 -0700, Roopa Prabhu  : >>> The one concern is that ports added or removed through ioctl should >>> cause same events as doing the same thing via netlink. Some users use >>> brctl (ioctl) and others use newer bridge (netlink) API. >> >> I'll

Re: [Bridge] [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-10-11 Thread Vincent Bernat
❦ 20 septembre 2017 16:21 -0700, Stephen Hemminger  : > The one concern is that ports added or removed through ioctl should > cause same events as doing the same thing via netlink. Some users use > brctl (ioctl) and others use newer bridge (netlink) API. I'll make a

Re: [Bridge] [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-10-11 Thread Vincent Bernat
❦ 20 septembre 2017 15:57 -0600, David Ahern  : > The DELLINK is for AF_BRIDGE family (ifi_family). Adding family to > print_linkinfo and running the monitor I get: > > > [LINK]family 0: 35: dummy1: mtu 1500 qdisc > noqueue master br0 state

Re: [Bridge] [RFC net-next v2] bridge lwtunnel, VPLS & NVGRE

2017-10-11 Thread Amine Kherbouche
Hi David, What's next ? do you plan to send a v3 or should I do it ? On 09/11/2017 10:02 AM, Amine Kherbouche wrote: Hi David, Do you plan to send a v3? On 21/08/2017 18:15, David Lamparter wrote: Hi all, this is an update on the earlier "[RFC net-next] VPLS support". Note I've changed

[Bridge] Problem with syslog in bridge(?) with ethernet broadcast packets with QinQ

2017-10-11 Thread Andrés Pozo Muñoz
Hi all, I'm facing some problem with ethernet multicast traffic and QinQ (802.3q in both tags) in -apparently- a bridge in Ubuntu 16.04 (4.12.0-041200-generic). My set up is the following: +---+ | VM| +-+-+ | | tag 55 +-++ |OVS

Re: [Bridge] [RFC net-next v2] bridge lwtunnel, VPLS & NVGRE

2017-10-11 Thread Amine Kherbouche
Hi David, Do you plan to send a v3? On 21/08/2017 18:15, David Lamparter wrote: Hi all, this is an update on the earlier "[RFC net-next] VPLS support". Note I've changed the subject lines on some of the patches to better reflect what they really do (tbh the earlier subject lines were crap.)

Re: [Bridge] [PATCH net-next] bridge: add tracepoint in br_fdb_update

2017-10-11 Thread Jesper Dangaard Brouer
On Thu, 31 Aug 2017 11:43:25 -0700 (PDT) David Miller wrote: > From: Roopa Prabhu > Date: Wed, 30 Aug 2017 22:18:13 -0700 > > > From: Roopa Prabhu > > > > This extends bridge fdb table tracepoints to also cover > >

Re: [Bridge] [PATCH net-next] bridge: add tracepoint in br_fdb_update

2017-10-11 Thread Arnaldo Carvalho de Melo
Em Thu, Aug 31, 2017 at 06:20:12PM +0200, Jesper Dangaard Brouer escreveu: > On Thu, 31 Aug 2017 09:30:05 -0600 David Ahern wrote: > > > On Thu, Aug 31, 2017 at 5:38 AM, Jesper Dangaard Brouer > > > wrote: > > > These bridge tracepoints in context are

Re: [Bridge] [PATCH 6/6] mpls: VPLS support

2017-10-11 Thread Amine Kherbouche
any opinion on vpls driver path ? On 08/21/2017 07:15 PM, David Lamparter wrote: [work-in-progress, works but needs changes] [v2: refactored lots of things, e.g. dst_metadata, no more genetlink] [v4: removed pointless include/net/vpls.h, squashed pseudowire control word support, squashed

Re: [Bridge] [PATCH 5/7] RDS: make rhashtable_params const

2017-10-11 Thread Santosh Shilimkar
8/25/2017 7:21 AM, Bhumika Goyal wrote: Make this const as it is either used during a copy operation or passed to a const argument of the function rhltable_init Signed-off-by: Bhumika Goyal --- Acked-by: Santosh Shilimkar

Re: [Bridge] [PATCH 3/7] ieee802154: 6lowpan: make header_ops const

2017-10-11 Thread Stefan Schmidt
Hello. On 08/25/2017 04:21 PM, Bhumika Goyal wrote: Make this const as it is only stored as a reference in a const field of a net_device structure. Signed-off-by: Bhumika Goyal --- net/ieee802154/6lowpan/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Bridge] [PATCH 7/7] SUNRPC: make kvec const

2017-10-11 Thread Bhumika Goyal
Make this const as it is only used during a copy operation. Signed-off-by: Bhumika Goyal --- net/sunrpc/xdr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c index e34f4ee..a096025 100644 --- a/net/sunrpc/xdr.c +++

[Bridge] [PATCH 5/7] RDS: make rhashtable_params const

2017-10-11 Thread Bhumika Goyal
Make this const as it is either used during a copy operation or passed to a const argument of the function rhltable_init Signed-off-by: Bhumika Goyal --- net/rds/bind.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/rds/bind.c b/net/rds/bind.c index

[Bridge] [PATCH 6/7] netfilter: nat: make rhashtable_params const

2017-10-11 Thread Bhumika Goyal
Make this const as it is either used during a copy operation or passed to a const argument of the function rhltable_init. Signed-off-by: Bhumika Goyal --- net/netfilter/nf_nat_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Bridge] [PATCH 4/7] ipv4: make net_protocol const

2017-10-11 Thread Bhumika Goyal
Make these const as they are only passed to a const argument of the function inet_add_protocol. Signed-off-by: Bhumika Goyal --- net/ipv4/af_inet.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index

[Bridge] [PATCH 2/7] bridge: make ebt_table const

2017-10-11 Thread Bhumika Goyal
Make this const as it is only passed to a const argument of the function ebt_register_table. Signed-off-by: Bhumika Goyal --- net/bridge/netfilter/ebtable_nat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/netfilter/ebtable_nat.c

[Bridge] [PATCH 1/7] Bluetooth: 6lowpan: make header_ops const

2017-10-11 Thread Bhumika Goyal
Make this const as it is only stored as a reference in a const field of a net_device structure. Signed-off-by: Bhumika Goyal --- net/bluetooth/6lowpan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c

[Bridge] [PATCH] netfilter: ebtables: use audit_log()

2017-10-11 Thread Geliang Tang
Use audit_log() instead of open-coding it. Signed-off-by: Geliang Tang --- net/bridge/netfilter/ebtables.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/net/bridge/netfilter/ebtables.c b/net/bridge/netfilter/ebtables.c index

[Bridge] [PATCH 0/7] net: make some structures const

2017-10-11 Thread Bhumika Goyal
Make these const as they are not modified. Bhumika Goyal (7): Bluetooth: 6lowpan: make header_ops const bridge: make ebt_table const ieee802154: 6lowpan: make header_ops const ipv4: make net_protocol const RDS: make rhashtable_params const netfilter: nat: make rhashtable_params const

Re: [Bridge] [PATCH 00/17] v3 net generic subsystem refcount conversions

2017-10-11 Thread Levin, Alexander (Sasha Levin) via Bridge
On Mon, Jul 03, 2017 at 02:28:56AM -0700, Eric Dumazet wrote: >On Fri, 2017-06-30 at 13:07 +0300, Elena Reshetova wrote: >> Changes in v3: >> Rebased on top of the net-next tree. >> >> Changes in v2: >> No changes in patches apart from rebases, but now by >> default refcount_t = atomic_t (*) and

[Bridge] [PATCH] net: bridge: constify attribute_group structures.

2017-10-11 Thread Arvind Yadav
attribute_groups are not supposed to change at runtime. All functions working with attribute_groups provided by work with const attribute_group. So mark the non-const structs as const. File size before: textdata bss dec hex filename 2645 896 03541 dd5

[Bridge] [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-10-11 Thread Vincent Bernat
Currently, when an interface is released from a bridge via ioctl(), we get a RTM_DELLINK event through netlink: Deleted 2: dummy0: mtu 1500 master bridge0 state UNKNOWN link/ether 6e:23:c2:54:3a:b3 Userspace has to interpret that as a removal from the bridge,

Re: [Bridge] [PATCH net-next v1] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-10-11 Thread Vincent Bernat
❦ 15 septembre 2017 21:38 +0200, Vincent Bernat  : > Currently, when an interface is released from a bridge, we get a > RTM_DELLINK event through netlink: > > Deleted 2: dummy0: mtu 1500 master bridge0 > state UNKNOWN > link/ether

[Bridge] [PATCH net-next v1] bridge: also trigger RTM_NEWLINK when interface is released from bridge

2017-10-11 Thread Vincent Bernat
Currently, when an interface is released from a bridge, we get a RTM_DELLINK event through netlink: Deleted 2: dummy0: mtu 1500 master bridge0 state UNKNOWN link/ether 6e:23:c2:54:3a:b3 Userspace has to interpret that as a removal from the bridge, not as a

Re: [Bridge] [PATCH net-next] bridge: add tracepoint in br_fdb_update

2017-10-11 Thread Jesper Dangaard Brouer
On Thu, 31 Aug 2017 09:30:05 -0600 David Ahern wrote: > On 8/31/17 9:21 AM, Roopa Prabhu wrote: > > On Thu, Aug 31, 2017 at 5:38 AM, Jesper Dangaard Brouer > > wrote: > >> On Wed, 30 Aug 2017 22:18:13 -0700 > >> Roopa Prabhu

[Bridge] bug report: hairpin NAT doesn't work across bridges

2017-10-11 Thread Russell Stuart
Configuration =   A box running Debian stretch is acting as a NAT'ing router.   It has a single Ethernet NIC and a wireless NIC servicing the local   LAN.  These devices are bridged.  Since it has only one wired NIC   it is used to connect to both the LAN and internet via a switch.  

Re: [Bridge] bug report: hairpin NAT doesn't work across bridges

2017-10-11 Thread Russell Stuart
I don't know how the unicode non-breaking spaces leaked into the previous version. Sorry about that. Configuration = A box running Debian stretch is acting as a NAT'ing router. It has a single Ethernet NIC and a wireless NIC servicing the local LAN. These devices are bridged.