Re: [Bridge] [PATCH net-next 0/7] net: bridge: Notify about bridge VLANs

2018-05-24 Thread Florian Fainelli
On 05/24/2018 08:09 AM, Petr Machata wrote: > In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap > mirror"), mlxsw got support for offloading mirror-to-gretap such that > the underlay packet path involves a bridge. In that case, the offload is > also influenced by PVID setting

Re: [Bridge] [PATCH net-next 0/7] net: bridge: Notify about bridge VLANs

2018-05-24 Thread Florian Fainelli
On 05/24/2018 10:20 AM, Florian Fainelli wrote: > Hi Petr, > > On 05/24/2018 08:09 AM, Petr Machata wrote: >> In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap >> mirror"), mlxsw got support for offloading mirror-to-gretap such that >> the underlay packet path involves a bri

Re: [Bridge] [PATCH net-next] net: bridge: add support for port isolation

2018-05-24 Thread Toshiaki Makita
On 2018/05/24 17:56, Nikolay Aleksandrov wrote: > This patch adds support for a new port flag - BR_ISOLATED. If it is set > then isolated ports cannot communicate between each other, but they can > still communicate with non-isolated ports. The same can be achieved via > ACLs but they can't scale w

Re: [Bridge] [PATCH net-next 0/7] net: bridge: Notify about bridge VLANs

2018-05-24 Thread Florian Fainelli
Hi Petr, On 05/24/2018 08:09 AM, Petr Machata wrote: > In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap > mirror"), mlxsw got support for offloading mirror-to-gretap such that > the underlay packet path involves a bridge. In that case, the offload is > also influenced by PVID

[Bridge] [PATCH net-next 7/7] mlxsw: spectrum_switchdev: Schedule respin during trans prepare

2018-05-24 Thread Petr Machata
Since there's no special support for the bridge events, the driver returns -EOPNOTSUPP, and thus the commit never happens. Therefore schedule respin during the prepare stage: there's no real difference one way or another. This fixes the problem that mirror-to-gretap offload wouldn't adapt to chang

[Bridge] [PATCH net-next 6/7] net: bridge: Notify about bridge VLANs

2018-05-24 Thread Petr Machata
A driver might need to react to changes in settings of brentry VLANs. Therefore send switchdev port notifications for these as well. Reuse SWITCHDEV_OBJ_ID_PORT_VLAN for this purpose. Listeners should use netif_is_bridge_master() on orig_dev to determine whether the notification is about a bridge p

[Bridge] [PATCH net-next 5/7] staging: fsl-dpaa2: ethsw: Ignore bridge VLAN events

2018-05-24 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata --- drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index c723a04..a

[Bridge] [PATCH net-next 4/7] dsa: port: Ignore bridge VLAN events

2018-05-24 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata --- net/dsa/port.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/dsa/port.c b/net/dsa/port.c index 2413beb..ed05954 100644 --- a/net/dsa/port.c +++ b/net/dsa/port.c @@ -252,6 +252,9 @@

[Bridge] [PATCH net-next 3/7] rocker: rocker_main: Ignore bridge VLAN events

2018-05-24 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata --- drivers/net/ethernet/rocker/rocker_main.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c index e73e

[Bridge] [PATCH net-next 2/7] mlxsw: spectrum_switchdev: Ignore bridge VLAN events

2018-05-24 Thread Petr Machata
Ignore VLAN events where the orig_dev is the bridge device itself. Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.

[Bridge] [PATCH net-next 1/7] net: bridge: Extract boilerplate around switchdev_port_obj_*()

2018-05-24 Thread Petr Machata
A call to switchdev_port_obj_add() or switchdev_port_obj_del() involves initializing a struct switchdev_obj_port_vlan, a piece of code that repeats on each call site almost verbatim. While in the current codebase there is just one duplicated add call, the follow-up patches add more of both add and

[Bridge] [PATCH net-next 0/7] net: bridge: Notify about bridge VLANs

2018-05-24 Thread Petr Machata
In commit 946a11e7408e ("mlxsw: spectrum_span: Allow bridge for gretap mirror"), mlxsw got support for offloading mirror-to-gretap such that the underlay packet path involves a bridge. In that case, the offload is also influenced by PVID setting of said bridge. However, changes to VLAN configuratio

[Bridge] [PATCH net-next] net: bridge: add support for port isolation

2018-05-24 Thread Nikolay Aleksandrov
This patch adds support for a new port flag - BR_ISOLATED. If it is set then isolated ports cannot communicate between each other, but they can still communicate with non-isolated ports. The same can be achieved via ACLs but they can't scale with large number of ports and also the complexity of the