Re: [Bridge] [PATCH net-next 2/2] net: bridge: add support for backup port

2018-07-22 Thread Toshiaki Makita
On 2018/07/21 1:41, Roopa Prabhu wrote: > On Fri, Jul 20, 2018 at 9:02 AM, Stephen Hemminger > wrote: >> Trying to understand this. >> >> Is it the case that what you are trying to solve is the way MLAG >> and bridging interact on the Linux side or more a limitation of how >> switches operate? Wo

[Bridge] [PATCH net-next v2 2/2] net: bridge: add support for backup port

2018-07-22 Thread Nikolay Aleksandrov
This patch adds a new port attribute - IFLA_BRPORT_BACKUP_PORT, which allows to set a backup port to be used for known unicast traffic if the port has gone carrier down. The backup pointer is rcu protected and set only under RTNL, a counter is maintained so when deleting a port we know how many oth

[Bridge] [PATCH net-next v2 0/2] net: bridge: add support for backup port

2018-07-22 Thread Nikolay Aleksandrov
Hi, This set introduces a new bridge port option that allows any port to have any other port (in the same bridge of course) as its backup and traffic will be forwarded to the backup port when the primary goes down. This is mainly used in MLAG and EVPN setups where we have peerlink path which is a b

[Bridge] [PATCH net-next v2 1/2] net: bridge: add support for raw sysfs port options

2018-07-22 Thread Nikolay Aleksandrov
This patch adds a new alternative store callback for port sysfs options which takes a raw value (buf) and can use it directly. It is needed for the backup port sysfs support since we have to pass the device by its name. Signed-off-by: Nikolay Aleksandrov --- There are a few checkpatch warnings he

Re: [Bridge] [PATCH net-next 1/2] net: bridge: add support for raw sysfs port options

2018-07-22 Thread Nikolay Aleksandrov
On 22/07/18 09:27, David Miller wrote: > From: Nikolay Aleksandrov > Date: Fri, 20 Jul 2018 17:48:25 +0300 > >> +spin_lock_bh(&p->br->lock); >> +ret = brport_attr->store_raw(p, (char *)buf); >> +spin_unlock_bh(&p->br->lock); > > Please respect the const here.