Re: [Bridge] [RFC net-next v3 00/10] net: bridge: mrp: Add support for Media Redundancy Protocol (MRP)

2020-01-25 Thread Vinicius Costa Gomes
Hi, "Allan W. Nielsen" writes: > Hi Vinicius, > > On 24.01.2020 13:05, Vinicius Costa Gomes wrote: >>I have one idea and one question. > > Let me answer the question before dicussing the idea. > >>The question that I have is: what's the relation of IEC 62439-2 to IEEE >>802.1CB? > HSR and 802.1C

Re: [Bridge] [RFC net-next v3 04/10] net: bridge: mrp: Add generic netlink interface to configure MRP

2020-01-25 Thread Allan W. Nielsen
On 25.01.2020 16:34, Andrew Lunn wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On Fri, Jan 24, 2020 at 05:18:22PM +0100, Horatiu Vultur wrote: Implement the generic netlink interface to configure MRP. The implementation will do sanity checks

Re: [Bridge] [RFC net-next v3 03/10] net: bridge: mrp: Add MRP interface used by netlink

2020-01-25 Thread Allan W. Nielsen
On 25.01.2020 16:20, Andrew Lunn wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe On Sat, Jan 25, 2020 at 12:37:26PM +0100, Horatiu Vultur wrote: The 01/24/2020 18:43, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments u

Re: [Bridge] [RFC net-next v3 00/10] net: bridge: mrp: Add support for Media Redundancy Protocol (MRP)

2020-01-25 Thread Allan W. Nielsen
On 25.01.2020 17:23, Andrew Lunn wrote: EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe Lets say that the link between H1 and H2 goes down: +--+ | | +-->|H1|

Re: [Bridge] [RFC net-next v3 06/10] net: bridge: mrp: switchdev: Extend switchdev API to offload MRP

2020-01-25 Thread Andrew Lunn
> SWITCHDEV_OBJ_ID_RING_TEST_MRP: This is used when to start/stop sending > MRP_Test frames on the mrp ring ports. This is called only on nodes that > have > the role Media Redundancy Manager. How do you handle the 'headless chicken' scenario? User space tells the port to start sending MRP_Te

Re: [Bridge] [RFC net-next v3 00/10] net: bridge: mrp: Add support for Media Redundancy Protocol (MRP)

2020-01-25 Thread Andrew Lunn
> Lets say that the link between H1 and H2 goes down: > > +--+ > | | > +-->|H1|<--- / --->|H2|<-->|H3|<--+ > eth0eth1eth0eth1eth0eth1 > > H1 will now observe that the test

Re: [Bridge] [RFC net-next v3 09/10] net: bridge: mrp: Integrate MRP into the bridge

2020-01-25 Thread Andrew Lunn
> br_netif_receive_skb(struct net *net, struct sock *sk, struct sk_buff *skb) > @@ -338,6 +341,17 @@ rx_handler_result_t br_handle_frame(struct sk_buff > **pskb) > return RX_HANDLER_CONSUMED; > } > } > +#ifdef CONFIG_BRIDGE_MRP > + /* If there is no M

Re: [Bridge] [RFC net-next v3 03/10] net: bridge: mrp: Add MRP interface used by netlink

2020-01-25 Thread Andrew Lunn
On Sat, Jan 25, 2020 at 12:37:26PM +0100, Horatiu Vultur wrote: > The 01/24/2020 18:43, Andrew Lunn wrote: > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > > content is safe > > > > > br_mrp_flush - will flush the FDB. > > > > How does this differ from a normal br

Re: [Bridge] [RFC net-next v3 09/10] net: bridge: mrp: Integrate MRP into the bridge

2020-01-25 Thread Andrew Lunn
On Fri, Jan 24, 2020 at 05:18:27PM +0100, Horatiu Vultur wrote: > To integrate MRP into the bridge, the bridge needs to do the following: > - initialized and destroy the generic netlink used by MRP > - detect if the MRP frame was received on a port that is part of a MRP ring. > In > case it was

Re: [Bridge] [RFC net-next v3 04/10] net: bridge: mrp: Add generic netlink interface to configure MRP

2020-01-25 Thread Andrew Lunn
On Fri, Jan 24, 2020 at 05:18:22PM +0100, Horatiu Vultur wrote: > Implement the generic netlink interface to configure MRP. The implementation > will do sanity checks over the attributes and then eventually call the MRP > interface which eventually will call the switchdev API. Hi Horatiu What was

Re: [Bridge] [RFC net-next v3 03/10] net: bridge: mrp: Add MRP interface used by netlink

2020-01-25 Thread Horatiu Vultur
The 01/24/2020 18:43, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > > br_mrp_flush - will flush the FDB. > > How does this differ from a normal bridge flush? I assume there is a > way for user space to flush the bridge FDB.

Re: [Bridge] [RFC net-next v3 02/10] net: bridge: mrp: Expose function br_mrp_port_open

2020-01-25 Thread Horatiu Vultur
The 01/24/2020 18:37, Andrew Lunn wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, Jan 24, 2020 at 05:18:20PM +0100, Horatiu Vultur wrote: > > In case the HW is capable to detect when the MRP ring is open or closed. It > > is > > e

Re: [Bridge] [RFC net-next v3 00/10] net: bridge: mrp: Add support for Media Redundancy Protocol (MRP)

2020-01-25 Thread Allan W. Nielsen
Hi Vinicius, On 24.01.2020 13:05, Vinicius Costa Gomes wrote: I have one idea and one question. Let me answer the question before dicussing the idea. The question that I have is: what's the relation of IEC 62439-2 to IEEE 802.1CB? HSR and 802.1CB (often called FRER - Frame Replication and E

Re: [Bridge] [RFC net-next v3 00/10] net: bridge: mrp: Add support for Media Redundancy Protocol (MRP)

2020-01-25 Thread Vinicius Costa Gomes
Hi, "Allan W. Nielsen" writes: > On 24.01.2020 17:18, Horatiu Vultur wrote: >>Media Redundancy Protocol is a data network protocol standardized by >>International Electrotechnical Commission as IEC 62439-2. It allows rings of >>Ethernet switches to overcome any single failure with recovery time