[Bridge] [PATCH net] bridge: mcast: Fix MLD2 Report IPv6 payload length check

2020-07-05 Thread Linus Lüssing
Commit e57f61858b7c ("net: bridge: mcast: fix stale nsrcs pointer in igmp3/mld2 report handling") introduced a small bug which would potentially lead to accepting an MLD2 Report with a broken IPv6 header payload length field. The check needs to take into account the 2 bytes for the "Number of Sour

Re: [Bridge] [PATCH net] bridge: mcast: Fix MLD2 Report IPv6 payload length check

2020-07-05 Thread Nikolay Aleksandrov
On 05/07/2020 21:22, Linus Lüssing wrote: > Commit e57f61858b7c ("net: bridge: mcast: fix stale nsrcs pointer in > igmp3/mld2 report handling") introduced a small bug which would potentially > lead to accepting an MLD2 Report with a broken IPv6 header payload length > field. > > The check needs to

Re: [Bridge] [PATCH net] bridge: mcast: Fix MLD2 Report IPv6 payload length check

2020-07-05 Thread Linus Lüssing
On Sun, Jul 05, 2020 at 09:33:13PM +0300, Nikolay Aleksandrov wrote: > On 05/07/2020 21:22, Linus Lüssing wrote: > > Commit e57f61858b7c ("net: bridge: mcast: fix stale nsrcs pointer in > > igmp3/mld2 report handling") introduced a small bug which would potentially > > lead to accepting an MLD2 Rep

[Bridge] [PATCH net v2] bridge: mcast: Fix MLD2 Report IPv6 payload length check

2020-07-05 Thread Linus Lüssing
Commit e57f61858b7c ("net: bridge: mcast: fix stale nsrcs pointer in igmp3/mld2 report handling") introduced a bug in the IPv6 header payload length check which would potentially lead to rejecting a valid MLD2 Report: The check needs to take into account the 2 bytes for the "Number of Sources" fie

Re: [Bridge] [PATCH net] bridge: mcast: Fix MLD2 Report IPv6 payload length check

2020-07-05 Thread Nikolay Aleksandrov
On 7/5/20 10:08 PM, Linus Lüssing wrote: On Sun, Jul 05, 2020 at 09:33:13PM +0300, Nikolay Aleksandrov wrote: On 05/07/2020 21:22, Linus Lüssing wrote: Commit e57f61858b7c ("net: bridge: mcast: fix stale nsrcs pointer in igmp3/mld2 report handling") introduced a small bug which would potentiall

Re: [Bridge] [PATCH net] bridge: mcast: Fix MLD2 Report IPv6 payload length check

2020-07-05 Thread Linus Lüssing
On Sun, Jul 05, 2020 at 10:11:39PM +0300, Nikolay Aleksandrov wrote: > On 7/5/20 10:08 PM, Linus Lüssing wrote: > > On Sun, Jul 05, 2020 at 09:33:13PM +0300, Nikolay Aleksandrov wrote: > > > On 05/07/2020 21:22, Linus Lüssing wrote: > > > > Commit e57f61858b7c ("net: bridge: mcast: fix stale nsrcs

Re: [Bridge] [PATCH net] bridge: mcast: Fix MLD2 Report IPv6 payload length check

2020-07-05 Thread Nikolay Aleksandrov
On 7/5/20 10:49 PM, Linus Lüssing wrote: On Sun, Jul 05, 2020 at 10:11:39PM +0300, Nikolay Aleksandrov wrote: On 7/5/20 10:08 PM, Linus Lüssing wrote: On Sun, Jul 05, 2020 at 09:33:13PM +0300, Nikolay Aleksandrov wrote: On 05/07/2020 21:22, Linus Lüssing wrote: Commit e57f61858b7c ("net: brid