Re: [Bridge] [PATCH net-next v3 05/15] net: bridge: mcast: factor out port group del

2020-09-06 Thread Jakub Kicinski
On Mon, 7 Sep 2020 00:29:10 +0300 Nikolay Aleksandrov wrote: > >> @@ -1641,16 +1647,7 @@ br_multicast_leave_group(struct net_bridge *br, > >>if (p->flags & MDB_PG_FLAGS_PERMANENT) > >>break; > >> > >> - rcu_assign_pointer(*pp,

Re: [Bridge] [PATCH net-next v3 06/15] net: bridge: mcast: add support for group query retransmit

2020-09-06 Thread Jakub Kicinski
On Mon, 7 Sep 2020 00:14:51 +0300 Nikolay Aleksandrov wrote: > On 9/7/20 12:01 AM, Jakub Kicinski wrote: > > On Sat, 5 Sep 2020 11:24:01 +0300 Nikolay Aleksandrov wrote: > >> We need to be able to retransmit group-specific and group-and-source > >> specific queries. The new timer takes care of

Re: [Bridge] [PATCH net-next v3 05/15] net: bridge: mcast: factor out port group del

2020-09-06 Thread Nikolay Aleksandrov
On 9/7/20 12:29 AM, Nikolay Aleksandrov wrote: On 9/6/20 11:56 PM, Jakub Kicinski wrote: On Sat,  5 Sep 2020 11:24:00 +0300 Nikolay Aleksandrov wrote: @@ -843,24 +843,11 @@ static int __br_mdb_del(struct net_bridge *br, struct br_mdb_entry *entry)   if (!p->port ||

Re: [Bridge] [PATCH net-next v3 05/15] net: bridge: mcast: factor out port group del

2020-09-06 Thread Nikolay Aleksandrov
On 9/6/20 11:56 PM, Jakub Kicinski wrote: On Sat, 5 Sep 2020 11:24:00 +0300 Nikolay Aleksandrov wrote: @@ -843,24 +843,11 @@ static int __br_mdb_del(struct net_bridge *br, struct br_mdb_entry *entry) if (!p->port || p->port->dev->ifindex != entry->ifindex)

Re: [Bridge] [PATCH net-next v3 06/15] net: bridge: mcast: add support for group query retransmit

2020-09-06 Thread Nikolay Aleksandrov
On 9/7/20 12:01 AM, Jakub Kicinski wrote: On Sat, 5 Sep 2020 11:24:01 +0300 Nikolay Aleksandrov wrote: We need to be able to retransmit group-specific and group-and-source specific queries. The new timer takes care of those. What guarantees that timer will not use pg after free? Do timer

Re: [Bridge] [PATCH net-next v3 06/15] net: bridge: mcast: add support for group query retransmit

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 11:24:01 +0300 Nikolay Aleksandrov wrote: > We need to be able to retransmit group-specific and group-and-source > specific queries. The new timer takes care of those. What guarantees that timer will not use pg after free? Do timer callbacks hold the RCU read lock?

Re: [Bridge] [PATCH net-next v3 05/15] net: bridge: mcast: factor out port group del

2020-09-06 Thread Jakub Kicinski
On Sat, 5 Sep 2020 11:24:00 +0300 Nikolay Aleksandrov wrote: > @@ -843,24 +843,11 @@ static int __br_mdb_del(struct net_bridge *br, struct > br_mdb_entry *entry) > if (!p->port || p->port->dev->ifindex != entry->ifindex) > continue; > > - if

Re: [Bridge] [PATCH RFC 0/7] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-09-06 Thread Horatiu Vultur via Bridge
The 09/04/2020 15:44, Stephen Hemminger wrote: > > On Fri, 4 Sep 2020 09:15:20 + > Henrik Bjoernlund wrote: > > > Connectivity Fault Management (CFM) is defined in 802.1Q section 12.14. > > > > Connectivity Fault Management (CFM) comprises capabilities for > > detecting, verifying, and