[Bridge] [PATCH 7/7 net-next] net: bridge: delete duplicated words

2020-09-17 Thread Randy Dunlap
ions(+), 2 deletions(-) --- linux-next-20200917.orig/net/bridge/br_ioctl.c +++ linux-next-20200917/net/bridge/br_ioctl.c @@ -103,7 +103,7 @@ static int add_del_if(struct net_bridge /* * Legacy ioctl's through SIOCDEVPRIVATE - * This interface is deprecated because it was too diffic

[Bridge] [PATCH RFC 4/7] bridge: cfm: Kernel space implementation of CFM.

2020-09-17 Thread Henrik Bjoernlund via Bridge
This is the implementation of the CFM protocol according to 802.1Q section 12.14. Connectivity Fault Management (CFM) comprises capabilities for detecting, verifying, and isolating connectivity failures in Virtual Bridged Networks. These capabilities can be used in networks operated by multiple in

Re: [Bridge] [PATCH RFC 5/7] bridge: cfm: Netlink Interface.

2020-09-17 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. Comments below. The 09/08/2020 13:47, Nikolay Aleksandrov wrote: > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote: > > This is the implementation of CFM netlink configuration > > and status information interface. > > > > Add new nested netlink attributes. Thes

Re: [Bridge] [PATCH RFC 7/7] bridge: cfm: Bridge port remove.

2020-09-17 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. I will update the next version as suggested. The 09/08/2020 13:58, Nikolay Aleksandrov wrote: > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote: > > This is addition of CFM functionality to delete MEP instances > > on a port that is removed from the bridge. > >

Re: [Bridge] [PATCH RFC 0/7] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-09-17 Thread Henrik.Bjoernlund--- via Bridge
Hi Nik, Thanks a lot for reviewing. -Original Message- From: Nikolay Aleksandrov Sent: 7. september 2020 15:56 To: step...@networkplumber.org; Horatiu Vultur - M31836 Cc: bridge@lists.linux-foundation.org; Henrik Bjoernlund - M31679 ; da...@davemloft.net; linux-ker...@vger.kernel.or

Re: [Bridge] [PATCH RFC 2/7] bridge: cfm: Add BRIDGE_CFM to Kconfig.

2020-09-17 Thread henrik.bjoernlund--- via Bridge
Thanks for your review. I will update in the next version as suggested. Regards Henrik The 09/08/2020 12:18, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote:

Re: [Bridge] [PATCH RFC 1/7] net: bridge: extend the process of special frames

2020-09-17 Thread henrik.bjoernlund--- via Bridge
Thanks for your review. I will update in the next version as suggested. Regards Henrik The 09/08/2020 12:12, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote:

[Bridge] [PATCH RFC 3/7] bridge: uapi: cfm: Added EtherType used by the CFM protocol.

2020-09-17 Thread Henrik Bjoernlund via Bridge
This EtherType is used by all CFM protocal frames transmitted according to 802.1Q section 12.14. Signed-off-by: Henrik Bjoernlund --- include/uapi/linux/if_ether.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/linux/if_ether.h b/include/uapi/linux/if_ether.h index d6de2b16744

[Bridge] [PATCH net-next] netfilter: ebt_stp: Remove unused macro BPDU_TYPE_TCN

2020-09-17 Thread Wang Hai
BPDU_TYPE_TCN is never used after it was introduced. So better to remove it. Reported-by: Hulk Robot Signed-off-by: Wang Hai --- net/bridge/netfilter/ebt_stp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/bridge/netfilter/ebt_stp.c b/net/bridge/netfilter/ebt_stp.c index 0d6d20c9105e..

Re: [Bridge] [PATCH RFC 4/7] bridge: cfm: Kernel space implementation of CFM.

2020-09-17 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. Comments below. The 09/08/2020 13:16, Nikolay Aleksandrov wrote: > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote: > > This is the implementation of the CFM protocol according to > > 802.1Q section 12.14. > > > > Connectivity Fault Management (CFM) comprises c

[Bridge] [PATCH RFC 2/7] bridge: cfm: Add BRIDGE_CFM to Kconfig.

2020-09-17 Thread Henrik Bjoernlund via Bridge
This makes it possible to include or exclude the CFM protocol according to 802.1Q section 12.14. Signed-off-by: Henrik Bjoernlund --- net/bridge/Kconfig | 11 +++ net/bridge/br_device.c | 3 +++ net/bridge/br_private.h | 3 +++ 3 files changed, 17 insertions(+) diff --git a/net

[Bridge] [PATCH RFC 5/7] bridge: cfm: Netlink Interface.

2020-09-17 Thread Henrik Bjoernlund via Bridge
This is the implementation of CFM netlink configuration and status information interface. Add new nested netlink attributes. These attributes are used by the user space to create/delete/configure CFM instances and get status. Also they are used by the kernel to notify the user space when changes i

[Bridge] [PATCH RFC 0/7] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-09-17 Thread Henrik Bjoernlund via Bridge
Connectivity Fault Management (CFM) is defined in 802.1Q section 12.14. Connectivity Fault Management (CFM) comprises capabilities for detecting, verifying, and isolating connectivity failures in Virtual Bridged Networks. These capabilities can be used in networks operated by multiple independent

[Bridge] [PATCH RFC 7/7] bridge: cfm: Bridge port remove.

2020-09-17 Thread Henrik Bjoernlund via Bridge
This is addition of CFM functionality to delete MEP instances on a port that is removed from the bridge. A MEP can only exist on a port that is related to a bridge. Signed-off-by: Henrik Bjoernlund --- net/bridge/br_cfm.c | 13 + net/bridge/br_if.c | 1 + net/bridge/br_pri

[Bridge] [PATCH RFC 1/7] net: bridge: extend the process of special frames

2020-09-17 Thread Henrik Bjoernlund via Bridge
This patch extends the processing of frames in the bridge. Currently MRP frames needs special processing and the current implementation doesn't allow a nice way to process different frame types. Therefore try to improve this by adding a list that contains frame types that need special processing. T

[Bridge] [PATCH RFC 6/7] bridge: cfm: Netlink Notifications.

2020-09-17 Thread Henrik Bjoernlund via Bridge
This is the implementation of Netlink notifications out of CFM. Notifications are initiated whenever a state change happens in CFM. IFLA_BRIDGE_CFM: Points to the CFM information. IFLA_BRIDGE_CFM_MEP_STATUS_INFO: This indicate that the MEP instance status are following. IFLA_BRIDGE_CFM_C

Re: [Bridge] [PATCH RFC 6/7] bridge: cfm: Netlink Notifications.

2020-09-17 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. Comments below. The 09/08/2020 13:54, Nikolay Aleksandrov wrote: > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote: > > This is the implementation of Netlink notifications out of CFM. > > > > Notifications are initiated whenever a state change happens in CFM. >

Re: [Bridge] [PATCH RFC 6/7] bridge: cfm: Netlink Notifications.

2020-09-17 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. Comments below. The 09/08/2020 13:54, Nikolay Aleksandrov wrote: > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote: > > This is the implementation of Netlink notifications out of CFM. > > > > Notifications are initiated whenever a state change happens in CFM. >

Re: [Bridge] [PATCH RFC 4/7] bridge: cfm: Kernel space implementation of CFM.

2020-09-17 Thread Henrik Bjoernlund via Bridge
Thanks for the review. Comments below. The 09/04/2020 08:02, Jakub Kicinski wrote: > > On Fri, 4 Sep 2020 09:15:24 + Henrik Bjoernlund wrote: > > + rcu_read_lock(); > > + b_port = rcu_dereference(mep->b_port); > > + if (!b_port) > > + return NULL; > > + skb = dev_a