Re: [Bridge] [PATCH net] net: bridge: mcast: Do not allow users to set IGMP counter/timer to zero

2021-10-18 Thread Hangbin Liu
Hi Nikolay, On Mon, Oct 18, 2021 at 01:28:14PM +0300, Nikolay Aleksandrov wrote: > On 18/10/2021 11:26, Hangbin Liu wrote: > > There is no meaning to set an IGMP counter/timer to 0. Or it will cause > > unexpected behavior. E.g. if set multicast_membership_interval to 0, > > bridge will remove

Re: [Bridge] [PATCH v3 net-next] net: make use of helper netif_is_bridge_master()

2021-10-18 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (master) by David S. Miller : On Sat, 16 Oct 2021 20:21:36 +0900 you wrote: > Make use of netdev helper functions to improve code readability. > Replace 'dev->priv_flags & IFF_EBRIDGE' with netif_is_bridge_master(dev). > > Signed-off-by:

Re: [Bridge] [PATCH net] net: bridge: mcast: Do not allow users to set IGMP counter/timer to zero

2021-10-18 Thread Nikolay Aleksandrov via Bridge
On 18/10/2021 11:26, Hangbin Liu wrote: > There is no meaning to set an IGMP counter/timer to 0. Or it will cause > unexpected behavior. E.g. if set multicast_membership_interval to 0, > bridge will remove the mdb immediately after adding. > > Fixes: 79b859f573d6 ("bridge: netlink: add support

[Bridge] [PATCH net] net: bridge: mcast: Do not allow users to set IGMP counter/timer to zero

2021-10-18 Thread Hangbin Liu
There is no meaning to set an IGMP counter/timer to 0. Or it will cause unexpected behavior. E.g. if set multicast_membership_interval to 0, bridge will remove the mdb immediately after adding. Fixes: 79b859f573d6 ("bridge: netlink: add support for multicast_last_member_count") Fixes: