[Bridge] [PATCH v4a 17/38] timers: net: Use timer_shutdown_sync() before freeing timer

2022-11-04 Thread Steven Rostedt
From: "Steven Rostedt (Google)" Before a timer is freed, timer_shutdown_sync() must be called. And if synchronization is already done, then at least timer_shutdown() needs to be called. Link: https://lore.kernel.org/all/20221104054053.431922...@goodmis.org/ Cc: Jesse Brandeburg Cc: Tony Nguye

[Bridge] [PATCH v4a 00/38] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Steven Rostedt
Back in April, I posted an RFC patch set to help mitigate a common issue where a timer gets armed just before it is freed, and when the timer goes off, it crashes in the timer code without any evidence of who the culprit was. I got side tracked and never finished up on that patch set. Since this

Re: [Bridge] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Guenter Roeck
On Fri, Nov 04, 2022 at 01:40:53AM -0400, Steven Rostedt wrote: > > Back in April, I posted an RFC patch set to help mitigate a common issue > where a timer gets armed just before it is freed, and when the timer > goes off, it crashes in the timer code without any evidence of who the > culprit was

Re: [Bridge] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Guenter Roeck
On Fri, Nov 04, 2022 at 04:38:34PM -0400, Steven Rostedt wrote: > On Fri, 4 Nov 2022 15:42:09 -0400 > Steven Rostedt wrote: > [ ... ] > > > drivers/clocksource/timer-fttmr010.c: fttmr010->timer_shutdown(evt); > > drivers/clocksource/timer-fttmr010.c: fttmr010->timer_shutdown(evt); > > driver

Re: [Bridge] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Guenter Roeck
On Fri, Nov 04, 2022 at 03:42:09PM -0400, Steven Rostedt wrote: > On Fri, 4 Nov 2022 12:22:32 -0700 > Guenter Roeck wrote: > > > Unfortunately the renaming caused some symbol conflicts. > > > > Global definition: timer_shutdown > > > > File Line > > 0 time.c93 static i

Re: [Bridge] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Steven Rostedt
On Fri, 4 Nov 2022 15:42:09 -0400 Steven Rostedt wrote: > $ git grep '\btimer_shutdown' > arch/arm/mach-spear/time.c:static inline void timer_shutdown(struct > clock_event_device *evt) > arch/arm/mach-spear/time.c: timer_shutdown(evt); > arch/arm/mach-spear/time.c: timer_shutdown(evt); >

Re: [Bridge] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Linus Torvalds
On Fri, Nov 4, 2022 at 12:42 PM Steven Rostedt wrote: > > Linus, should I also add any patches that has already been acked by the > respective maintainer? No, I'd prefer to keep only the ones that are 100% unambiguously not changing any semantics. Linus

Re: [Bridge] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Steven Rostedt
On Fri, 4 Nov 2022 12:22:32 -0700 Guenter Roeck wrote: > Unfortunately the renaming caused some symbol conflicts. > > Global definition: timer_shutdown > > File Line > 0 time.c93 static inline void timer_shutdown(struct > clock_event_device *evt) > 1 arm_arch_timer.c

Re: [Bridge] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Guenter Roeck
On Fri, Nov 04, 2022 at 01:40:53AM -0400, Steven Rostedt wrote: > > Back in April, I posted an RFC patch set to help mitigate a common issue > where a timer gets armed just before it is freed, and when the timer > goes off, it crashes in the timer code without any evidence of who the > culprit was

Re: [Bridge] [RFC][PATCH v3 00/33] timers: Use timer_shutdown*() before freeing timers

2022-11-04 Thread Linus Torvalds
On Thu, Nov 3, 2022 at 10:48 PM Steven Rostedt wrote: > > Ideally, I would have the first patch go into this rc cycle, which is mostly > non functional as it will allow the other patches to come in via the > respective > subsystems in the next merge window. Ack. I also wonder if we could do the

Re: [Bridge] [RFC][PATCH v2 19/31] timers: net: Use del_timer_shutdown() before freeing timer

2022-11-04 Thread Guenter Roeck
On Fri, Nov 04, 2022 at 01:51:39AM -0400, Steven Rostedt wrote: > On Thu, 3 Nov 2022 17:00:20 -0700 > Eric Dumazet wrote: > > > inet_csk_clear_xmit_timers() can be called multiple times during TCP > > socket lifetime. > > > > (See tcp_disconnect(), which can be followed by another connect() ...

Re: [Bridge] [PATCH net-next 1/2] bridge: Add MAC Authentication Bypass (MAB) support

2022-11-04 Thread Vladimir Oltean
On Fri, Nov 04, 2022 at 12:23:07PM +0100, net...@kapio-technology.com wrote: > On 2022-11-04 00:18, Vladimir Oltean wrote: > > > 3. Forwarding: Locked FDB entries forward traffic like regular entries. > > >If user space detects an unauthorized MAC behind a locked port and > > >wishes to pre

Re: [Bridge] [PATCH net-next 1/2] bridge: Add MAC Authentication Bypass (MAB) support

2022-11-04 Thread netdev
On 2022-11-04 00:18, Vladimir Oltean wrote: On Tue, Nov 01, 2022 at 09:39:21PM +0200, Ido Schimmel wrote: From: "Hans J. Schultz" Hosts that support 802.1X authentication are able to authenticate themselves by exchanging EAPOL frames with an authenticator (Ethernet bridge, in this case) and an