Re: [Bridge] [PATCH v2 net-next 6/6] selftests: forwarding: add dynamic FDB test

2023-03-30 Thread Hans Schultz
On Thu, Mar 30, 2023 at 09:37, Ido Schimmel wrote: > On Tue, Mar 28, 2023 at 09:30:08PM +0200, Hans Schultz wrote: >> >> Sorry, but I have sent you several emails telling you about the problems >> I have with running the selftests due to changes in the phy etc. Maybe >> you have just not received

Re: [Bridge] [PATCH v2 net-next 6/6] selftests: forwarding: add dynamic FDB test

2023-03-30 Thread Nikolay Aleksandrov
On 30/03/2023 13:29, Hans Schultz wrote: > On Thu, Mar 30, 2023 at 09:37, Ido Schimmel wrote: >> On Tue, Mar 28, 2023 at 09:30:08PM +0200, Hans Schultz wrote: >>> >>> Sorry, but I have sent you several emails telling you about the problems >>> I have with running the selftests due to changes in th

Re: [Bridge] [PATCH v2 net-next 2/6] net: dsa: propagate flags down towards drivers

2023-03-30 Thread Vladimir Oltean
On Tue, Mar 28, 2023 at 09:45:26PM +0200, Hans Schultz wrote: > So the solution would be to not let the DSA layer send the > SWITCHDEV_FDB_OFFLOADED event in the case when the new dynamic flag is > set? I have never said that.

Re: [Bridge] [PATCH v2 net-next 2/6] net: dsa: propagate flags down towards drivers

2023-03-30 Thread Hans Schultz
On Thu, Mar 30, 2023 at 15:43, Vladimir Oltean wrote: > On Tue, Mar 28, 2023 at 09:45:26PM +0200, Hans Schultz wrote: >> So the solution would be to not let the DSA layer send the >> SWITCHDEV_FDB_OFFLOADED event in the case when the new dynamic flag is >> set? > > I have never said that. No, I w

Re: [Bridge] [PATCH v2 net-next 2/6] net: dsa: propagate flags down towards drivers

2023-03-30 Thread Vladimir Oltean
On Thu, Mar 30, 2023 at 02:59:04PM +0200, Hans Schultz wrote: > On Thu, Mar 30, 2023 at 15:43, Vladimir Oltean wrote: > > On Tue, Mar 28, 2023 at 09:45:26PM +0200, Hans Schultz wrote: > >> So the solution would be to not let the DSA layer send the > >> SWITCHDEV_FDB_OFFLOADED event in the case whe

Re: [Bridge] [PATCH v2 net-next 2/6] net: dsa: propagate flags down towards drivers

2023-03-30 Thread Hans Schultz
On Thu, Mar 30, 2023 at 16:09, Vladimir Oltean wrote: > On Thu, Mar 30, 2023 at 02:59:04PM +0200, Hans Schultz wrote: >> On Thu, Mar 30, 2023 at 15:43, Vladimir Oltean wrote: >> > On Tue, Mar 28, 2023 at 09:45:26PM +0200, Hans Schultz wrote: >> >> So the solution would be to not let the DSA layer

Re: [Bridge] [PATCH v2 net-next 2/6] net: dsa: propagate flags down towards drivers

2023-03-30 Thread Vladimir Oltean
On Thu, Mar 30, 2023 at 04:54:19PM +0200, Hans Schultz wrote: > I don't know if you have a solution in mind wrt the behaviour of the > offloaded flag if it is not to do as it does now and let the bridge age > out dynamic entries. That led me to conclude that this patch-set cannot > use the offloade

Re: [Bridge] [PATCH v2 net-next 2/6] net: dsa: propagate flags down towards drivers

2023-03-30 Thread Hans Schultz
On Thu, Mar 30, 2023 at 18:07, Vladimir Oltean wrote: > > Then, make DSA decide whether to handle the "added_by_user && !is_static" > combination or not, based on the presence of the DSA_FDB_FLAG_DYNAMIC > flag, which will be set in ds->supported_fdb_flags only for the mv88e6xxx > driver. Okay, s

Re: [Bridge] [PATCH v2 net-next 2/6] net: dsa: propagate flags down towards drivers

2023-03-30 Thread Vladimir Oltean
On Thu, Mar 30, 2023 at 05:34:44PM +0200, Hans Schultz wrote: > On Thu, Mar 30, 2023 at 18:07, Vladimir Oltean wrote: > > > > Then, make DSA decide whether to handle the "added_by_user && !is_static" > > combination or not, based on the presence of the DSA_FDB_FLAG_DYNAMIC > > flag, which will be

Re: [Bridge] [PATCH v2 net-next 6/6] selftests: forwarding: add dynamic FDB test

2023-03-30 Thread Hans Schultz
On Tue, Mar 28, 2023 at 19:40, Ido Schimmel wrote: > On Sun, Mar 26, 2023 at 05:41:06PM +0200, Hans Schultz wrote: >> On Mon, Mar 20, 2023 at 10:44, Ido Schimmel wrote: >> >> + $MZ $swp1 -c 1 -p 128 -t udp "sp=54321,dp=12345" \ >> >> + -a $mac -b `mac_get $h2` -A 192.0.2.1 -B 192.0.2.2 -q

Re: [Bridge] [PATCH v2 net-next 6/6] selftests: forwarding: add dynamic FDB test

2023-03-30 Thread Vladimir Oltean
On Thu, Mar 30, 2023 at 09:07:53PM +0200, Hans Schultz wrote: > Not true, it reveals that I forgot to put it in the patch, that's all. As > I cannot run several of these tests because of memory constraints I link > the file to a copy in a rw area where I modify the list and just run one > of the su