Re: [Bridge] [PATCH net-next 1/5] skbuff: bridge: Add layer 2 miss indication

2023-05-19 Thread Jakub Kicinski
On Fri, 19 May 2023 16:51:48 +0300 Ido Schimmel wrote: > diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c > index fc17b9fd93e6..274e55455b15 100644 > --- a/net/bridge/br_input.c > +++ b/net/bridge/br_input.c > @@ -46,6 +46,8 @@ static int br_pass_frame_up(struct sk_buff *skb) > *

Re: [Bridge] [PATCH net-next 3/5] flow_offload: Reject matching on layer 2 miss

2023-05-19 Thread Simon Horman
On Fri, May 19, 2023 at 05:10:58PM +0300, Ido Schimmel wrote: > On Fri, May 19, 2023 at 01:33:00PM +0200, Simon Horman wrote: > > On Thu, May 18, 2023 at 02:33:26PM +0300, Ido Schimmel wrote: > > > Adjust drivers that support the 'FLOW_DISSECTOR_KEY_META' key to reject > > > filters that try to mat

Re: [Bridge] [PATCH net-next 3/5] flow_offload: Reject matching on layer 2 miss

2023-05-19 Thread Ido Schimmel via Bridge
On Fri, May 19, 2023 at 01:33:00PM +0200, Simon Horman wrote: > On Thu, May 18, 2023 at 02:33:26PM +0300, Ido Schimmel wrote: > > Adjust drivers that support the 'FLOW_DISSECTOR_KEY_META' key to reject > > filters that try to match on the newly added layer 2 miss option. Add an > > extack message t

Re: [Bridge] [PATCH net-next 1/5] skbuff: bridge: Add layer 2 miss indication

2023-05-19 Thread Ido Schimmel via Bridge
On Thu, May 18, 2023 at 07:08:47PM +0300, Nikolay Aleksandrov wrote: > On 18/05/2023 14:33, Ido Schimmel wrote: > > diff --git a/net/bridge/br_input.c b/net/bridge/br_input.c > > index fc17b9fd93e6..d8ab5890cbe6 100644 > > --- a/net/bridge/br_input.c > > +++ b/net/bridge/br_input.c > > @@ -334,6 +3

Re: [Bridge] [PATCH net-next 4/5] mlxsw: spectrum_flower: Add ability to match on layer 2 miss

2023-05-19 Thread Simon Horman
On Thu, May 18, 2023 at 02:33:27PM +0300, Ido Schimmel wrote: > Add the 'dmac_type' key element to supported key blocks and make use of > it to match on layer 2 miss. > > This is a two bits key in hardware with the following values: > 00b - Known multicast. > 01b - Broadcast. > 10b - Known unicast

Re: [Bridge] [PATCH net-next 3/5] flow_offload: Reject matching on layer 2 miss

2023-05-19 Thread Simon Horman
On Thu, May 18, 2023 at 02:33:26PM +0300, Ido Schimmel wrote: > Adjust drivers that support the 'FLOW_DISSECTOR_KEY_META' key to reject > filters that try to match on the newly added layer 2 miss option. Add an > extack message to clearly communicate the failure reason to user space. Hi Ido, FLOW

Re: [Bridge] [PATCH net-next 2/5] net/sched: flower: Allow matching on layer 2 miss

2023-05-19 Thread Simon Horman
On Thu, May 18, 2023 at 02:33:25PM +0300, Ido Schimmel wrote: > Add the 'TCA_FLOWER_L2_MISS' netlink attribute that allows user space to > match on packets that encountered a layer 2 miss. The miss indication is > set as metadata in the skb by the bridge driver upon FDB/MDB lookup > miss. > > Sign