Re: [Bridge] [PATCH net-next v4 4/6] net: bridge: Add netlink knobs for number / max learned FDB entries

2023-09-21 Thread Nikolay Aleksandrov
On 9/21/23 15:41, Nikolay Aleksandrov wrote: On 9/19/23 11:12, Johannes Nixdorf wrote: The previous patch added accounting and a limit for the number of dynamically learned FDB entries per bridge. However it did not provide means to actually configure those bounds or read back the count. This pa

Re: [Bridge] [PATCH net-next v4 4/6] net: bridge: Add netlink knobs for number / max learned FDB entries

2023-09-21 Thread Nikolay Aleksandrov
On 9/19/23 11:12, Johannes Nixdorf wrote: The previous patch added accounting and a limit for the number of dynamically learned FDB entries per bridge. However it did not provide means to actually configure those bounds or read back the count. This patch does that. Two new netlink attributes are

Re: [Bridge] [PATCH net-next v4 1/6] net: bridge: Set BR_FDB_ADDED_BY_USER early in fdb_add_entry

2023-09-21 Thread Ido Schimmel
On Tue, Sep 19, 2023 at 10:12:48AM +0200, Johannes Nixdorf wrote: > In preparation of the following fdb limit for dynamically learned entries, > allow fdb_create to detect that the entry was added by the user. This > way it can skip applying the limit in this case. > > Signed-off-by: Johannes Nixd

Re: [Bridge] [PATCH net-next v4 5/6] net: bridge: Add a configurable default FDB learning limit

2023-09-21 Thread Nikolay Aleksandrov
On 9/21/23 11:06, Johannes Nixdorf wrote: On Wed, Sep 20, 2023 at 02:00:27PM +0300, Nikolay Aleksandrov wrote: On 9/19/23 11:12, Johannes Nixdorf wrote: Add a Kconfig option to configure a default FDB learning limit system wide, so a distributor building a special purpose kernel can limit all c

Re: [Bridge] [PATCH net-next v4 2/6] net: bridge: Set strict_start_type for br_policy

2023-09-21 Thread Nikolay Aleksandrov
On 9/21/23 10:23, Johannes Nixdorf wrote: On Wed, Sep 20, 2023 at 01:46:02PM +0300, Nikolay Aleksandrov wrote: On 9/19/23 11:12, Johannes Nixdorf wrote: Set any new attributes added to br_policy to be parsed strictly, to prevent userspace from passing garbage. Signed-off-by: Johannes Nixdorf

Re: [Bridge] [PATCH net-next v4 5/6] net: bridge: Add a configurable default FDB learning limit

2023-09-21 Thread Johannes Nixdorf via Bridge
On Wed, Sep 20, 2023 at 02:00:27PM +0300, Nikolay Aleksandrov wrote: > On 9/19/23 11:12, Johannes Nixdorf wrote: > > Add a Kconfig option to configure a default FDB learning limit system > > wide, so a distributor building a special purpose kernel can limit all > > created bridges by default. > >

Re: [Bridge] [PATCH net-next v4 4/6] net: bridge: Add netlink knobs for number / max learned FDB entries

2023-09-21 Thread Johannes Nixdorf via Bridge
On Wed, Sep 20, 2023 at 01:50:32PM +0300, Nikolay Aleksandrov wrote: > On 9/19/23 11:12, Johannes Nixdorf wrote: > > [...] > > diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c > > index 505683ef9a26..f5d49a05e61b 100644 > > --- a/net/bridge/br_netlink.c > > +++ b/net/bridge/br_netlink

Re: [Bridge] [PATCH net-next v4 2/6] net: bridge: Set strict_start_type for br_policy

2023-09-21 Thread Johannes Nixdorf via Bridge
On Wed, Sep 20, 2023 at 01:46:02PM +0300, Nikolay Aleksandrov wrote: > On 9/19/23 11:12, Johannes Nixdorf wrote: > > Set any new attributes added to br_policy to be parsed strictly, to > > prevent userspace from passing garbage. > > > > Signed-off-by: Johannes Nixdorf > > --- > > net/bridge/br_