Re: [PATCH iproute2-next v2 2/2] bridge: vlan: fix compressvlans usage

2024-03-22 Thread Stephen Hemminger
On Fri, 22 Mar 2024 20:39:23 +0800 Date Huang wrote: > diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 > index eeea4073..bb02bd27 100644 > --- a/man/man8/bridge.8 > +++ b/man/man8/bridge.8 > @@ -22,6 +22,7 @@ bridge \- show / manipulate bridge addresses and devices > \fB\-s\fR[\fItatistics\fR

Re: [PATCH iproute2-next v2 0/2] bridge: vlan: add compressvlans manpage

2024-03-22 Thread Nikolay Aleksandrov
On 3/22/24 14:39, Date Huang wrote: Hi maintainers I followed Nikolay and Jiri's comment and updated the patch to v2. Please check it. Your cover letter should contain an overview of what the set is doing. Date Huang (2): bridge: vlan: fix compressvlans usage bridge: vlan: add compres

Re: [PATCH iproute2-next v2 1/2] bridge: vlan: fix compressvlans usage

2024-03-22 Thread Nikolay Aleksandrov
On 3/22/24 14:39, Date Huang wrote: Fix the incorrect short opt for compressvlans and color in usage Signed-off-by: Date Huang --- bridge/bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bridge/bridge.c b/bridge/bridge.c index f4805092..ef592815 100644 --- a/bridg

Re: [PATCH iproute2-next v2 2/2] bridge: vlan: fix compressvlans usage

2024-03-22 Thread Nikolay Aleksandrov
On 3/22/24 14:39, Date Huang wrote: Add the missing 'compressvlans' to man page Signed-off-by: Date Huang --- man/man8/bridge.8 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 index eeea4073..bb02bd27 100644 --- a/man/man8/bridge.8 +++ b/man/ma

[PATCH iproute2-next v2 2/2] bridge: vlan: fix compressvlans usage

2024-03-22 Thread Date Huang
Add the missing 'compressvlans' to man page Signed-off-by: Date Huang --- man/man8/bridge.8 | 6 ++ 1 file changed, 6 insertions(+) diff --git a/man/man8/bridge.8 b/man/man8/bridge.8 index eeea4073..bb02bd27 100644 --- a/man/man8/bridge.8 +++ b/man/man8/bridge.8 @@ -22,6 +22,7 @@ bridge \-

[PATCH iproute2-next v2 1/2] bridge: vlan: fix compressvlans usage

2024-03-22 Thread Date Huang
Fix the incorrect short opt for compressvlans and color in usage Signed-off-by: Date Huang --- bridge/bridge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bridge/bridge.c b/bridge/bridge.c index f4805092..ef592815 100644 --- a/bridge/bridge.c +++ b/bridge/bridge.c @@ -39,

[PATCH iproute2-next v2 0/2] bridge: vlan: add compressvlans manpage

2024-03-22 Thread Date Huang
Hi maintainers I followed Nikolay and Jiri's comment and updated the patch to v2. Please check it. Date Huang (2): bridge: vlan: fix compressvlans usage bridge: vlan: add compressvlans manpage bridge/bridge.c | 2 +- man/man8/bridge.8 | 6 ++ 2 files changed, 7 insertions(+), 1 deleti

Re: [PATCH] bridge: vlan: fix compressvlans manpage and usage

2024-03-22 Thread Date Huang
Hi Jiri On 3/22/2024 5:40 PM, Jiri Pirko wrote: Fri, Mar 22, 2024 at 09:56:29AM CET, tjjh89...@hotmail.com wrote: Add the missing 'compressvlans' to man page. Fix the incorrect short opt for compressvlans and color in usage. Split to 2 patches please. Please fix your prefix to be in format "

Re: [PATCH] bridge: vlan: fix compressvlans manpage and usage

2024-03-22 Thread Date Huang
Hi Nikolay On 3/22/2024 5:25 PM, Nikolay Aleksandrov wrote: On 3/22/24 10:56, Date Huang wrote: Add the missing 'compressvlans' to man page. Fix the incorrect short opt for compressvlans and color in usage. Signed-off-by: Date Huang --- Hi, This should be targeted at iproute2. Nit below,

Re: [PATCH] bridge: vlan: fix compressvlans manpage and usage

2024-03-22 Thread Jiri Pirko
Fri, Mar 22, 2024 at 09:56:29AM CET, tjjh89...@hotmail.com wrote: >Add the missing 'compressvlans' to man page. >Fix the incorrect short opt for compressvlans and color >in usage. Split to 2 patches please. Please fix your prefix to be in format "[patch iproute2-next] xxx" to properly indicate th

Re: [PATCH] bridge: vlan: fix compressvlans manpage and usage

2024-03-22 Thread Nikolay Aleksandrov
On 3/22/24 10:56, Date Huang wrote: Add the missing 'compressvlans' to man page. Fix the incorrect short opt for compressvlans and color in usage. Signed-off-by: Date Huang --- Hi, This should be targeted at iproute2. Nit below, bridge/bridge.c | 2 +- man/man8/bridge.8 | 5 + 2 f

[PATCH] bridge: vlan: fix compressvlans manpage and usage

2024-03-22 Thread Date Huang
Add the missing 'compressvlans' to man page. Fix the incorrect short opt for compressvlans and color in usage. Signed-off-by: Date Huang --- bridge/bridge.c | 2 +- man/man8/bridge.8 | 5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/bridge/bridge.c b/bridge/bridge.c inde