Re: [Bridge] [PATCH RFC 6/7] bridge: cfm: Netlink Notifications.

2020-09-17 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. Comments below. The 09/08/2020 13:54, Nikolay Aleksandrov wrote: > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote: > > This is the implementation of Netlink notifications out of CFM. > > > > Notifications are initiated whenever a state change happens in CFM. >

Re: [Bridge] [PATCH RFC 6/7] bridge: cfm: Netlink Notifications.

2020-09-17 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. Comments below. The 09/08/2020 13:54, Nikolay Aleksandrov wrote: > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote: > > This is the implementation of Netlink notifications out of CFM. > > > > Notifications are initiated whenever a state change happens in CFM. >

Re: [Bridge] [PATCH RFC 4/7] bridge: cfm: Kernel space implementation of CFM.

2020-09-17 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. Comments below. The 09/08/2020 13:16, Nikolay Aleksandrov wrote: > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote: > > This is the implementation of the CFM protocol according to > > 802.1Q section 12.14. > > > > Connectivity Fault Management (CFM) comprises c

Re: [Bridge] [PATCH RFC 7/7] bridge: cfm: Bridge port remove.

2020-09-17 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. I will update the next version as suggested. The 09/08/2020 13:58, Nikolay Aleksandrov wrote: > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote: > > This is addition of CFM functionality to delete MEP instances > > on a port that is removed from the bridge. > >

Re: [Bridge] [PATCH RFC 0/7] net: bridge: cfm: Add support for Connectivity Fault Management(CFM)

2020-09-17 Thread Henrik.Bjoernlund--- via Bridge
Hi Nik, Thanks a lot for reviewing. -Original Message- From: Nikolay Aleksandrov Sent: 7. september 2020 15:56 To: step...@networkplumber.org; Horatiu Vultur - M31836 Cc: bridge@lists.linux-foundation.org; Henrik Bjoernlund - M31679 ; da...@davemloft.net; linux-ker...@vger.kernel.or

Re: [Bridge] [PATCH RFC 2/7] bridge: cfm: Add BRIDGE_CFM to Kconfig.

2020-09-17 Thread henrik.bjoernlund--- via Bridge
Thanks for your review. I will update in the next version as suggested. Regards Henrik The 09/08/2020 12:18, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote:

Re: [Bridge] [PATCH RFC 1/7] net: bridge: extend the process of special frames

2020-09-17 Thread henrik.bjoernlund--- via Bridge
Thanks for your review. I will update in the next version as suggested. Regards Henrik The 09/08/2020 12:12, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote:

Re: [Bridge] [PATCH RFC 5/7] bridge: cfm: Netlink Interface.

2020-09-17 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. Comments below. The 09/08/2020 13:47, Nikolay Aleksandrov wrote: > > On Fri, 2020-09-04 at 09:15 +, Henrik Bjoernlund wrote: > > This is the implementation of CFM netlink configuration > > and status information interface. > > > > Add new nested netlink attributes. Thes

Re: [Bridge] [PATCH net-next v4 01/10] net: bridge: extend the process of special frames

2020-10-12 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. Comments below. The 10/12/2020 09:12, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > > This patch extends the processing of frames i

Re: [Bridge] [PATCH net-next v4 07/10] bridge: cfm: Netlink SET configuration Interface.

2020-10-12 Thread henrik.bjoernlund--- via Bridge
The 10/09/2020 21:53, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > > This is the implementation of CFM netlink configuration > > set information interface

Re: [Bridge] [PATCH net-next v4 10/10] bridge: cfm: Netlink Notifications.

2020-10-12 Thread henrik.bjoernlund--- via Bridge
The 10/09/2020 22:03, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > > This is the implementation of Netlink notifications out of CFM. > > > > Notifications

Re: [Bridge] [PATCH net-next v4 09/10] bridge: cfm: Netlink GET status Interface.

2020-10-12 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. Comments below. The 10/09/2020 22:00, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > > This is the implementation of CFM netlink sta

Re: [Bridge] [PATCH net-next v4 08/10] bridge: cfm: Netlink GET configuration Interface.

2020-10-12 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. Comments below. The 10/09/2020 21:59, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Sat, 2020-10-10 at 00:56 +0300, Nikolay Aleksandrov wrote: > > On Fri, 2020-10-09 at 14:35 +, Henrik B

Re: [Bridge] [PATCH net-next v4 08/10] bridge: cfm: Netlink GET configuration Interface.

2020-10-12 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. The 10/09/2020 21:56, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > > This is the implementation of CFM netlink configuration > > g

Re: [Bridge] [PATCH net-next v4 05/10] bridge: cfm: Kernel space implementation of CFM. CCM frame TX added.

2020-10-12 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. The 10/09/2020 21:49, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > > This is the second commit of the implementation of the CFM pr

Re: [Bridge] [PATCH net-next v4 06/10] bridge: cfm: Kernel space implementation of CFM. CCM frame RX added.

2020-10-12 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. The 10/09/2020 21:52, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > > This is the third commit of the implementation of the CFM pro

Re: [Bridge] [PATCH net-next v4 04/10] bridge: cfm: Kernel space implementation of CFM. MEP create/delete.

2020-10-12 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. The 10/09/2020 21:42, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > > This is the first commit of the implementation of the CFM pro

Re: [Bridge] [PATCH net-next v4 03/10] bridge: uapi: cfm: Added EtherType used by the CFM protocol.

2020-10-12 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. The 10/09/2020 21:41, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > > This EtherType is used by all CFM protocal frames transmitted

Re: [Bridge] [PATCH net-next v4 02/10] bridge: cfm: Add BRIDGE_CFM to Kconfig.

2020-10-12 Thread henrik.bjoernlund--- via Bridge
Thanks for the review. The 10/09/2020 21:39, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote: > > This makes it possible to include or exclude the CFM > > prot

Re: [Bridge] [PATCH net-next v5 08/10] bridge: cfm: Netlink GET configuration Interface.

2020-10-15 Thread henrik.bjoernlund--- via Bridge
Thanks for your review. Regards Henrik The 10/14/2020 10:54, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 2020-10-12 at 14:04 +, Henrik Bjoernlund wrote: > > This is the implementation of CFM netlink con

Re: [Bridge] [PATCH net-next v5 09/10] bridge: cfm: Netlink GET status Interface.

2020-10-15 Thread henrik.bjoernlund--- via Bridge
Thanks for your review. Regards Henrik The 10/14/2020 11:24, Nikolay Aleksandrov wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Mon, 2020-10-12 at 14:04 +, Henrik Bjoernlund wrote: > > This is the implementation of CFM netlink sta