multicast traffic as the
bridge did not learn about these listeners.
Reported-by: Jan Stancek
Signed-off-by: Linus Lüssing
---
net/bridge/br_multicast.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index fb0e36f
On Wed, Mar 05, 2014 at 07:10:07AM -0500, Jan Stancek wrote:
>
>
> - Original Message -
> > From: "Linus Lüssing"
> > To: "Jan Stancek"
> > Cc: net...@vger.kernel.org, "Florian Westphal" ,
> > bridge@lists.linux-foundati
On Tue, Mar 04, 2014 at 06:06:29AM -0500, Jan Stancek wrote:
>
>
> - Original Message -
> > From: "Linus Lüssing"
> > To: "Jan Stancek"
> > Cc: net...@vger.kernel.org, "Florian Westphal" ,
> > bridge@lists.linux-foundati
Hi Jan,
On Tue, Mar 04, 2014 at 03:02:36AM -0500, Jan Stancek wrote:
> > For the broken query, ok, it's your manually crafted query. But
> > did you see a query with such a bogus source address "in the
> > wild", too? (I'm curious how urgent this sanity check is)
>
> It's real packet I managed to
On Tue, Mar 04, 2014 at 10:06:14AM +0100, Hannes Frederic Sowa wrote:
> > diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
> > index ef66365..fb0e36f 100644
> > --- a/net/bridge/br_multicast.c
> > +++ b/net/bridge/br_multicast.c
> > @@ -1235,6 +1235,12 @@ static int br_ip6_multica
about these listeners.
Reported-by: Jan Stancek
Signed-off-by: Linus Lüssing
---
net/bridge/br_multicast.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index ef66365..fb0e36f 100644
--- a/net/bridge/br_multicast.c
+++ b/net
Hi Jan,
On Mon, Mar 03, 2014 at 05:45:49PM -0500, Jan Stancek wrote:
> There is also bridge on host B. I assume that doesn't matter
> but I could set up host B without bridge if needed.
It can matter, but in this case it doesn't :).
> > What I'm curious about is, whether the guest receives
> > t
On Mon, Mar 03, 2014 at 04:40:40PM -0500, Vlad Yasevich wrote:
> I did notice a minor issue in the bridge code. The following
> code:
>/* Prevent flooding this packet if there is no listener present */
> if (!ipv6_addr_is_ll_all_nodes(&ip6h->daddr))
> BR_INPUT_SKB_C
Hi Jan,
On Mon, Mar 03, 2014 at 02:47:15PM -0500, Jan Stancek wrote:
> I'm seeing an issue where bridge (sometimes) stops forwarding ICMP6
> neighbor solicitation packets to KVM guest and as result KVM guest doesn't
> respond with neighbor advertisement.
Hm, okay, that's not supposed to happen.
The multicast snooping code should have matured enough to be safely
applicable to IPv6 link-local multicast addresses (excluding the
link-local all nodes address, ff02::1), too.
Signed-off-by: Linus Lüssing
---
net/bridge/br_mdb.c |3 ++-
net/bridge/br_multicast.c |7 ---
net
("bridge: Only flood unregistered groups
to routers") did for IPv4, let's do the same for IPv6 with the same
reasoning.
Signed-off-by: Linus Lüssing
---
net/bridge/br_multicast.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/net/bridge/br_multicast
Hi,
Here are two, small feature changes I would like to submit to increase
the usefulness of the multicast snooping of the bridge code.
The first patch is an unaltered one I had submitted before, but since it
got no feedback I'm resubmitting it here for net-next. With the recently
added patch to
pecific by using separate timers for the snooped IGMP and MLD queries
as well as separate timers for our internal IGMP and MLD queriers.
Signed-off-by: Linus Lüssing
---
net/bridge/br_device.c|2 +-
net/bridge/br_input.c |2 +-
net/bridge/br_mdb.c | 14 ++-
net/bridge/br_m
pecific by using separate timers for the snooped IGMP and MLD queries
as well as separate timers for our internal IGMP and MLD queriers.
Signed-off-by: Linus Lüssing
---
net/bridge/br_device.c|2 +-
net/bridge/br_input.c |2 +-
net/bridge/br_mdb.c | 14 +-
net/bridge/br_m
On Mon, Aug 05, 2013 at 03:42:22PM -0700, Stephen Hemminger wrote:
> On Tue, 6 Aug 2013 00:32:05 +0200
> Linus Lüssing wrote:
>
> > Currently we are reading an uninitialized value for the max_delay
> > variable when snooping an MLD query message of invalid length and would
his patch we are flooding multicast packets if our querier is
> > > disabled and if we didn't detect any other querier.
> > >
> > > A grace period of the Maximum Response Delay of the querier is added to
> > > give multicast responses enough time to arrive an
:
"bridge: disable snooping if there is no querier" (b00589af3b04)
Reported-by: Paul Bolle
Signed-off-by: Linus Lüssing
---
net/bridge/br_multicast.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 61c5e8
mum Response Delay of the querier is added to
give multicast responses enough time to arrive and to be learned from
before disabling the flooding behaviour again.
Signed-off-by: Linus Lüssing
---
v3: changed type of multicast_querier_delay_time from
atomic64_t to unsigned long
On Fri, Jul 26, 2013 at 11:19:00PM +0100, Adam Baker wrote:
> On 25/07/13 14:56, Linus Lüssing wrote:
> >If there is no querier on a link then we won't get periodic reports and
> >therefore won't be able to learn about multicast listeners behind ports,
> >potent
On Thu, Jul 25, 2013 at 09:01:40AM -0700, Stephen Hemminger wrote:
> On Thu, 25 Jul 2013 15:56:20 +0200
> Linus Lüssing wrote:
>
> >
> > +static void br_multicast_update_querier_timer(struct net_bridge *br,
> > +
mum Response Delay of the querier is added to
give multicast responses enough time to arrive and to be learned from
before disabling the flooding behaviour again.
Signed-off-by: Linus Lüssing
---
v2: added missing, empty br_multicast_querier_exists() to avoid
build failures if CONFIG_BRIDGE_IGMP_S
mum Response Delay of the querier is added to
give multicast responses enough time to arrive and to be learned from
before disabling the flooding behaviour again.
Signed-off-by: Linus Lüssing
---
net/bridge/br_device.c|3 ++-
net/bridge/br_input.c |3 ++-
net/bri
Hi Herbert,
Were there any reasons I might not be aware of which prevented you
from adding the same change you introduced in
"bridge: Only flood unregistered groups to routers" for IPv6, too?
If not and if no one else comes up with any objection, then I'd
still be happy if this patch could find i
("bridge: Only flood unregistered groups
to routers") did for IPv4, let's do the same for IPv6 with the same
reasoning.
Signed-off-by: Linus Lüssing
---
net/bridge/br_multicast.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/net/bridge/br_multicast
on 7.3+7.8)
Signed-off-by: Linus Lüssing
---
net/bridge/br_multicast.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 81f2389..d6448e3 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -46
net_device itself.
A multicast optimization currently implemented for batman-adv requires
this data.
Signed-off-by: Linus Lüssing
---
include/linux/if_bridge.h | 17 +
net/bridge/br_multicast.c | 59 +
net/bridge/br_private.h | 11
Hmm, if so, then I don't know how to test and verify that now though.
Cheers, Linus
On Sun, Mar 27, 2011 at 02:37:49PM +0800, Herbert Xu wrote:
> On Sun, Mar 27, 2011 at 08:27:23AM +0200, Linus Lüssing wrote:
> > In contrast to IGMP, the MLDv1/2 message checksum needs to include
underrun when substracting the offset and therefore to a very
high new value of 'len' due to its unsignedness. This will ultimately
lead to the pskb_trim_rcsum() practically never being called, even in
the cases where it should.
Signed-off-by: Linus Lüssing
---
net/bridge/br_multica
ion for the checksum validation when
parsing a snooped IPv6 MLDv1/2 message of another host, leading to
possibly ignored, though valid MLDv1/2 messages. This commit shall fix
this issue.
Signed-off-by: Linus Lüssing
---
net/bridge/br_multicast.c |5 -
1 files changed, 4 insertions(+), 1 deleti
Hi everyone,
The following two patches are fixing two issues, related to the parsing of
IPv6 MLD messages.
The first one fixes an observed issue which lead to ignored MLD messages.
In the tests this patch fixes the issue in my scenario. However I'm not
so familiar with the checksumming functions
Hi everyone,
Somehow I'm having trouble with the IPv6 bridge snooping again:
MLDv2 Reports are dropped by the multicast snooping feature, looks
like it has something to do with checksums. Wireshark does not
display any weirdness, it at least reports the MLD reports
checksum as correct.
The setup
> One unrelated other observation with this change of yours:
> daddr is an input argument to ipv6_dev_get_saddr(), yet
> it gets initialized only after the function was called. Is that
> really correct?
Hmm, that wasn't intentional. I tested that again and so far I still always
got the right source
and only after that fetching the source address.
Reported-by: Jan Beulich
Signed-off-by: Linus Lüssing
---
net/bridge/br_multicast.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 030a002..f61eb2e 100644
eries destination MAC should always be 33:33:00:00:00:01 which
matches the IPv6 header's multicast destination ff02::1.
Signed-off-by: Linus Lüssing
---
net/bridge/br_multicast.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multica
with a MLD response (which
was not the case before).
Signed-off-by: Linus Lüssing
---
net/bridge/br_multicast.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index f904a2e..2d88861 100644
--- a/net/bridge/br_multica
> These look correct. Did you test them with real traffic?
Yes, I did. With these patches the hashlist and linked lists per port
are being filled correctly for IPv6 - initially. Verified that with
both some printk()s for the per port mglists as well as with vlc. With
patch 5/5 this also worked fin
transient multicast addresses instead of non-link-local
addresses.
Signed-off-by: Linus Lüssing
---
net/bridge/br_multicast.c |9 -
1 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index e8fdaab..b5eb28a 100644
--- a
The nsrcs number is 2 Byte wide, therefore we need to call ntohs()
before using it.
Signed-off-by: Linus Lüssing
---
net/bridge/br_multicast.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 45dcf10
This commit adds the missing IPv6 multicast address flag defines to
complement the already existing multicast address scope defines and to
be able to check these flags nicely in the future.
Signed-off-by: Linus Lüssing
---
include/net/ipv6.h | 12
1 files changed, 12 insertions
The protocol type for IPv6 entries in the hash table for multicast
bridge snooping is falsely set to ETH_P_IP, marking it as an IPv4
address, instead of setting it to ETH_P_IPV6, which results in negative
look-ups in the hash table later.
Signed-off-by: Linus Lüssing
---
net/bridge
Hello everyone,
While testing the (very awesome!) bridge igmp/mld snooping support I came across
two issues which are breaking IPv6 multicast snooping and IPv6
non-link-local multicast on bridges with multicast snooping support enabled
in general. The first two patches shall fix these issues.
The
-by: Linus Lüssing
---
net/bridge/br_multicast.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/bridge/br_multicast.c b/net/bridge/br_multicast.c
index 135d929..45dcf10 100644
--- a/net/bridge/br_multicast.c
+++ b/net/bridge/br_multicast.c
@@ -1014,7 +1014,7 @@ static
201 - 242 of 242 matches
Mail list logo
