Re: [Bridge] [PATCH] net: bridge: fix signature of stub br_multicast_is_router

2021-05-15 Thread Randy Dunlap
On 5/15/21 1:38 PM, t...@redhat.com wrote: > From: Tom Rix > > Building with CONFIG_IPV6 off causes this build error > > br_input.c:135:8: error: too many arguments to function > ‘br_multicast_is_router’ > br_multicast_is_router(br, skb)) { > ^~ > In file in

Re: [Bridge] [PATCH net-next] net/bridge: fix misspellings using codespell tool

2021-01-07 Thread Randy Dunlap
Fix typos found by codespell. > > Signed-off-by: Menglong Dong LGTM. Thanks. Acked-by: Randy Dunlap > --- > net/bridge/br.c | 2 +- > net/bridge/br_input.c | 2 +- > net/bridge/br_mrp.c | 6 +++--- > net/bridge/br_stp.c | 4 ++-- > 4 files changed, 7 in

[Bridge] [PATCH 7/7 net-next] net: bridge: delete duplicated words

2020-09-17 Thread Randy Dunlap
Drop repeated words in net/bridge/. Signed-off-by: Randy Dunlap Cc: "David S. Miller" Cc: Jakub Kicinski Cc: Roopa Prabhu Cc: Nikolay Aleksandrov Cc: bridge@lists.linux-foundation.org --- net/bridge/br_ioctl.c |2 +- net/bridge/br_vlan.c |2 +- 2 files changed, 2 insert

Re: [Bridge] [PATCH net-next] Documentation: networking: Clarify switchdev devices behavior

2020-07-22 Thread Randy Dunlap
Hi, This mostly looks good to me. I have a few edits below. On 7/22/20 3:52 PM, Florian Fainelli wrote: > This patch provides details on the expected behavior of switchdev > enabled network devices when operating in a "stand alone" mode, as well > as when being bridge members. This clarifies a n

Re: [Bridge] linux-next: Tree for Aug 7 (net/bridge/netfilter/nf_conntrack_bridge.c)

2019-08-07 Thread Randy Dunlap
On 8/7/19 1:36 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190806: > on i386: when CONFIG_NF_TABLES is not set/enabled: CC net/bridge/netfilter/nf_conntrack_bridge.o In file included from ../net/bridge/netfilter/nf_conntrack_bridge.c:21:0: ../include/net/netfilter/nf_tables

Re: [Bridge] [PATCH net-next v4] Documentation: networking: Clarify switchdev devices behavior

2019-01-10 Thread Randy Dunlap
up during a bug fixing session on the b53 DSA switch > driver. > > Signed-off-by: Florian Fainelli Reviewed-by: Randy Dunlap Thanks. > --- > Changes in v4: > > - more spelling/grammar/sentence fixes (Randy) > > Changes in v3: > > - spell checks, past vs. pres

Re: [Bridge] [PATCH net-next v3] Documentation: networking: Clarify switchdev devices behavior

2019-01-09 Thread Randy Dunlap
Hi Florian, Just a few more comments... On 1/8/19 8:39 PM, Florian Fainelli wrote: > This patch provides details on the expected behavior of switchdev > enabled network devices when operating in a "stand alone" mode, as well > as when being bridge members. This clarifies a number of things that

Re: [Bridge] [PATCH net-next v2] Documentation: networking: Clarify switchdev devices behavior

2019-01-03 Thread Randy Dunlap
Hi, Comments below. On 1/3/19 2:47 PM, Florian Fainelli wrote: > This patch provides details on the expected behavior of switchdev > enabled network devices when operating in a "stand alone" mode, as well > as when being bridge members. This clarifies a number of things that > recently came up d

Re: [Bridge] [PATCH v1] bridge: Use helpers to handle MAC address

2017-12-24 Thread Randy Dunlap
On 12/19/2017 10:10 AM, Andy Shevchenko wrote: > Use > %pM to print MAC > mac_pton() to convert it from ASCII to binary format, and > ether_addr_copy() to copy. > > Signed-off-by: Andy Shevchenko (same) select GENERIC_NET_UTILS ? > --- > net/bridge/br_sysfs_br.c | 13

Re: [Bridge] [PATCH -next] bridge: depends on INET

2010-03-08 Thread Randy Dunlap
On 03/03/10 19:18, Ingo Molnar wrote: > > * David Miller wrote: > >> From: Randy Dunlap >> Date: Tue, 02 Mar 2010 09:08:23 -0800 >> >>> From: Randy Dunlap >>> >>> br_multicast calls ip_send_check(), so it should depend on INET. >>&

[Bridge] [PATCH -next] bridge: depends on INET

2010-03-03 Thread Randy Dunlap
From: Randy Dunlap br_multicast calls ip_send_check(), so it should depend on INET. built-in: br_multicast.c:(.text+0x88cf4): undefined reference to `ip_send_check' or modular: ERROR: "ip_send_check" [net/bridge/bridge.ko] undefined! Signed-off-by: Randy Dunlap Cc: Stephe