Re: [Bridge] [PATCH net-next 0/3] net: vlan: fix bridge binding behavior and add selftests

On 7/30/22 09:48, Sevinj Aghayeva wrote: (Resending this because the first email was rejected due to being in HTML.) On Sat, Jul 30, 2022 at 12:46 PM Sevinj Aghayeva wrote: On Sat, Jul 30, 2022 at 12:22 PM Nikolay Aleksandrov wrote: On 7/30/22 19:03, Sevinj Aghayeva wrote: When

Re: [Bridge] [PATCH net-next v7 2/2] net: vxlan: Add extack support to vxlan_fdb_delete

On 5/12/22 09:47, Jakub Kicinski wrote: On Thu, 12 May 2022 09:22:17 -0700 Roopa Prabhu wrote: On 5/12/22 02:55, Alaa Mohamed wrote: This patch adds extack msg support to vxlan_fdb_delete and vxlan_fdb_parse. extack is used to propagate meaningful error msgs to the user of vxlan fdb netlink

Re: [Bridge] [PATCH net-next v7 2/2] net: vxlan: Add extack support to vxlan_fdb_delete

On 5/12/22 02:55, Alaa Mohamed wrote: This patch adds extack msg support to vxlan_fdb_delete and vxlan_fdb_parse. extack is used to propagate meaningful error msgs to the user of vxlan fdb netlink api Signed-off-by: Alaa Mohamed --- changes in V2: - fix spelling vxlan_fdb_delete

Re: [Bridge] [PATCH net-next v2 0/8] net: bridge: add flush filtering support

On 4/11/22 11:31, Nikolay Aleksandrov wrote: On 11/04/2022 21:18, Nikolay Aleksandrov wrote: On 11/04/2022 21:08, Roopa Prabhu wrote: On 4/11/22 10:29, Nikolay Aleksandrov wrote: Hi, This patch-set adds support to specify filtering conditions for a flush operation. This version has entirely

Re: [Bridge] [PATCH net-next v2 0/8] net: bridge: add flush filtering support

On 4/11/22 10:29, Nikolay Aleksandrov wrote: Hi, This patch-set adds support to specify filtering conditions for a flush operation. This version has entirely different entry point (v1 had bridge-specific IFLA attribute, here I add new RTM_FLUSHNEIGH msg and netdev ndo_fdb_flush op) so I'll

Re: [Bridge] [PATCH v2 net-next 03/10] net: bridge: mst: Support setting and reporting MST port states

On 3/1/22 15:19, Nikolay Aleksandrov wrote: On 1 March 2022 11:03:14 CET, Tobias Waldekranz wrote: Make it possible to change the port state in a given MSTI. This is done through a new netlink interface, since the MSTIs are objects in their own right. The proposed iproute2 interface would

Re: [Bridge] [PATCH net-next v2 0/2] net: bridge: multicast: per-port EHT hosts limit

On 1/28/21 10:52 AM, Jakub Kicinski wrote: On Thu, 28 Jan 2021 11:12:26 +0200 Nikolay Aleksandrov wrote: On 28/01/2021 03:42, Jakub Kicinski wrote: On Tue, 26 Jan 2021 11:35:31 +0200 Nikolay Aleksandrov wrote: From: Nikolay Aleksandrov Hi, This set adds a simple configurable per-port EHT

Re: [Bridge] Bridge port userspace events broken?

On Wed, Oct 16, 2019 at 2:16 PM Richard Weinberger wrote: > > Roopa, Nikolay, > > - Ursprüngliche Mail - > > +1, this can be fixedbut in general all new bridge and link > > attributes have better support with netlink. > > In this case its IFLA_BRPORT_GROUP_FWD_MASK link attribute

Re: Bridge port userspace events broken?

On Tue, Oct 15, 2019 at 3:53 AM wrote: > > On 15 October 2019 12:48:58 CEST, niko...@cumulusnetworks.com wrote: > >On 14 October 2019 22:33:22 CEST, Richard Weinberger > > wrote: > >>Hi! > >> > >>My userspace needs /sys/class/net/eth0/brport/group_fwd_mask, so I set > >>up udev rules > >>to wait

Re: [PATCH net v4] net: bridge: move default pvid init/deinit to NETDEV_REGISTER/UNREGISTER

urn 0 in > the br_vlan_bridge_event stub when bridge vlans are disabled > > [0] https://bugzilla.kernel.org/show_bug.cgi?id=204389 > > Reported-by: michael-dev > Fixes: 5be5a2df40f0 ("bridge: Add filtering support for default_pvid") > Signed-off-by: Nikolay Aleksandrov Acked-by: Roopa Prabhu

Re: [Bridge] [PATCH net] net: rtnetlink: address is mandatory for rtnl_fdb_get

On Sun, Dec 30, 2018 at 4:33 AM Nikolay Aleksandrov wrote: > > We must have an address to lookup otherwise we'll derefence a null > pointer in the ndo_fdb_get callbacks. > > CC: Roopa Prabhu > CC: David Ahern > Reported-by: syzbot+017b1f61c82a1c3e7...@syzkaller.ap

Re: [Bridge] [PATCH net-next] net: bridge: add support for sticky fdb entries

On Mon, Sep 10, 2018 at 2:18 PM, Stephen Hemminger wrote: > On Mon, 10 Sep 2018 13:16:01 +0300 > Nikolay Aleksandrov wrote: > >> Add support for entries which are "sticky", i.e. will not change their port >> if they show up from a different one. A new ndm flag is introduced for that >> purpose -

Re: [Bridge] [RFC PATCH net-next 3/5] bridge: allow switchdev port to handle flooding by itself

On Mon, Mar 12, 2018 at 6:11 PM, Andrew Lunn wrote: >> The flag was introduced to enable hardware switch capabilities of >> drivers/net/wireless/quantenna/qtnfmac wifi driver. It does not have any >> switchdev functionality in upstream tree at this moment, and this patchset >> was

Re: [Bridge] [PATCH net] net: bridge: add vlan_tunnel to bridge port policies

On Mon, Nov 13, 2017 at 8:30 AM, Nikolay Aleksandrov <niko...@cumulusnetworks.com> wrote: > Found another missing port flag policy entry for IFLA_BRPORT_VLAN_TUNNEL > so add it now. > > CC: Roopa Prabhu <ro...@cumulusnetworks.com> > Fixes: efa5356b0d97 ("bridg

Re: [Bridge] [PATCH net-next] net: bridge: add neigh_suppress to bridge port policies

t;) > Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> Acked-by: Roopa Prabhu <ro...@cumulusnetworks.com> Thanks Nikolay.

Re: [Bridge] [PATCH net] net: bridge: fix returning of vlan range op errors

; Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") > Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> > --- Acked-by: Roopa Prabhu <ro...@cumulusnetworks.com> thanks

[Bridge] [PATCH net-next v6 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/bridge/br_arp_nd_proxy.c | 249 +++ net/bridge

[Bridge] [PATCH net-next v6 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu <ro...@cumulusnet

[Bridge] [PATCH net-next v6 0/3] bridge: neigh msg proxy and flood suppression support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP*

[Bridge] [PATCH net-next v6 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the ex

Re: [Bridge] [PATCH net-next v5 0/3] bridge: neigh msg proxy and flood suppression support

On Fri, Oct 6, 2017 at 11:34 AM, Roopa Prabhu <ro...@cumulusnetworks.com> wrote: > From: Roopa Prabhu <ro...@cumulusnetworks.com> > > This series implements arp and nd suppression in the bridge > driver for ethernet vpns. It implements rfc7432, section 10 > https://

[Bridge] [PATCH net-next v5 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/bridge/br_arp_nd_proxy.c | 249 +++ net/bridge

[Bridge] [PATCH net-next v5 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the ex

[Bridge] [PATCH net-next v5 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu <ro...@cumulusnet

[Bridge] [PATCH net-next v5 0/3] bridge: neigh msg proxy and flood suppression support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_PROXYARP*

Re: [Bridge] [PATCH net-next v4 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

On Wed, Oct 4, 2017 at 3:52 PM, David Miller <da...@davemloft.net> wrote: > From: Roopa Prabhu <ro...@cumulusnetworks.com> > Date: Tue, 3 Oct 2017 22:12:31 -0700 > >> BR_ARP_PROXY flag but has a few semantic differences to conform > > This should be "BR_PRO

Re: [Bridge] [PATCH net-next v4 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

On Wed, Oct 4, 2017 at 12:21 AM, Toshiaki Makita <makita.toshi...@lab.ntt.co.jp> wrote: > On 2017/10/04 14:12, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to >> su

[Bridge] [PATCH net-next v4 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/bridge/br_arp_nd_proxy.c | 246 +++ net/bridge

[Bridge] [PATCH net-next v4 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu <ro...@cumulusnet

[Bridge] [PATCH net-next v4 0/3] bridge: neigh msg proxy and flood suppression support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROX

[Bridge] [PATCH net-next v4 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the ex

Re: [Bridge] [PATCH net-next v2 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

On Tue, Oct 3, 2017 at 11:29 AM, Stephen Hemminger <step...@networkplumber.org> wrote: > On Tue, 3 Oct 2017 11:21:14 -0700 > Roopa Prabhu <ro...@cumulusnetworks.com> wrote: > >> diff --git a/net/bridge/br_forward.c b/net/bridge/br_forward.c >> index 48fb174..7

[Bridge] [PATCH net-next v3 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/bridge/br_arp_nd_proxy.c | 246 +++ net/bridge

[Bridge] [PATCH net-next v3 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the ex

[Bridge] [PATCH net-next v3 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu <ro...@cumulusnet

[Bridge] [PATCH net-next v3 0/3] bridge: neigh msg proxy and flood suppression support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROX

[Bridge] [PATCH net-next v2 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu <ro...@cumulusnet

[Bridge] [PATCH net-next v2 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/bridge/br_arp_nd_proxy.c | 246 +++ net/bridge

[Bridge] [PATCH net-next v2 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the ex

[Bridge] [PATCH net-next v2 0/3] bridge: neigh msg proxy and flood suppression support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROX

Re: [Bridge] [PATCH net-next 0/3] bridge: neigh msg proxy and flood suppression support

On Sun, Oct 1, 2017 at 9:36 PM, Roopa Prabhu <ro...@cumulusnetworks.com> wrote: > From: Roopa Prabhu <ro...@cumulusnetworks.com> > > This series implements arp and nd suppression in the bridge > driver for ethernet vpns. It implements rfc7432, section 10 > https://

[Bridge] [PATCH net-next 1/3] bridge: add new BR_NEIGH_SUPPRESS port flag to suppress arp and nd flood

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch adds a new bridge port flag BR_NEIGH_SUPPRESS to suppress arp and nd flood on bridge ports. It implements rfc7432, section 10. https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the ex

[Bridge] [PATCH net-next 3/3] bridge: suppress nd pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies ndisc packets for BR_NEIGH_SUPPRESS ports. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- net/bridge/br_arp_nd_proxy.c | 246 +++ net/bridge

[Bridge] [PATCH net-next 0/3] bridge: neigh msg proxy and flood suppression support

From: Roopa Prabhu <ro...@cumulusnetworks.com> This series implements arp and nd suppression in the bridge driver for ethernet vpns. It implements rfc7432, section 10 https://tools.ietf.org/html/rfc7432#section-10 for ethernet VPN deployments. It is similar to the existing BR_ARP_PROX

[Bridge] [PATCH net-next 2/3] bridge: suppress arp pkts on BR_NEIGH_SUPPRESS ports

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch avoids flooding and proxies arp packets for BR_NEIGH_SUPPRESS ports. Moves existing br_do_proxy_arp to br_do_proxy_suppress_arp to support both proxy arp and neigh suppress. Signed-off-by: Roopa Prabhu <ro...@cumulusnet

Re: [Bridge] [PATCH net-next] net: bridge: add per-port group_fwd_mask with less restrictions

On Fri, Sep 29, 2017 at 3:11 PM, Nikolay Aleksandrov wrote: > On 30/09/17 00:51, Stephen Hemminger wrote: >> On Sat, 30 Sep 2017 00:01:24 +0300 >> Nikolay Aleksandrov wrote: >> >>> On 29/09/17 18:14, Stephen Hemminger wrote: On Wed,

Re: [Bridge] [net-next v3] bridge: trigger RTM_NEWLINK when interface is modified by bridge ioctl

On Thu, Sep 21, 2017 at 9:43 AM, David Ahern wrote: > On 9/21/17 4:05 AM, Vincent Bernat wrote: >> Currently, there is a difference in netlink events received when an >> interface is modified through bridge ioctl() or through netlink. This >> patch generates additional events

Re: [Bridge] [PATCH net-next v2] bridge: also trigger RTM_NEWLINK when interface is released from bridge

On Thu, Sep 21, 2017 at 3:04 AM, Vincent Bernat wrote: > ❦ 20 septembre 2017 16:21 -0700, Stephen Hemminger > : > >> The one concern is that ports added or removed through ioctl should >> cause same events as doing the same thing via netlink. Some

Re: [Bridge] [PATCH net-next] bridge: add tracepoint in br_fdb_update

On Thu, Aug 31, 2017 at 5:38 AM, Jesper Dangaard Brouer <bro...@redhat.com> wrote: > On Wed, 30 Aug 2017 22:18:13 -0700 > Roopa Prabhu <ro...@cumulusnetworks.com> wrote: > >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> This extends bridge fdb t

[Bridge] [PATCH net-next] bridge: add tracepoint in br_fdb_update

From: Roopa Prabhu <ro...@cumulusnetworks.com> This extends bridge fdb table tracepoints to also cover learned fdb entries in the br_fdb_update path. Note that unlike other tracepoints I have moved this to when the fdb is modified because this is in the datapath and can generate a lot of

[Bridge] [PATCH net-next v3] bridge: fdb add and delete tracepoints

From: Roopa Prabhu <ro...@cumulusnetworks.com> A few useful tracepoints to trace bridge forwarding database updates. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- v2: address comments from florian v3: remove stray character '=' in print (pointed out by florian) i

Re: [Bridge] [PATCH net-next v2] bridge: fdb add and delete tracepoints

On Tue, Aug 29, 2017 at 9:46 AM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 08/28/2017 09:22 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> A few useful tracepoints to trace bridge forwarding >> database updates

Re: [Bridge] [PATCH net-next] bridge: fdb add and delete tracepoints

On Sun, Aug 27, 2017 at 7:11 PM, Florian Fainelli <f.faine...@gmail.com> wrote: > On 08/27/2017 02:33 PM, Roopa Prabhu wrote: >> From: Roopa Prabhu <ro...@cumulusnetworks.com> >> >> Tracepoints to trace bridge forwarding database updates. > > Thanks for ad

[Bridge] [PATCH net-next] bridge: fdb add and delete tracepoints

From: Roopa Prabhu <ro...@cumulusnetworks.com> Tracepoints to trace bridge forwarding database updates. Signed-off-by: Roopa Prabhu <ro...@cumulusnetworks.com> --- include/trace/events/bridge.h | 98 +++ net/bridge/br_fdb.c | 7 ++

Re: [Bridge] [RFC net-next v2] bridge lwtunnel, VPLS & NVGRE

On Mon, Aug 21, 2017 at 10:15 AM, David Lamparter wrote: > Hi all, > > > this is an update on the earlier "[RFC net-next] VPLS support". Note > I've changed the subject lines on some of the patches to better reflect > what they really do (tbh the earlier subject lines were

Re: [Bridge] [PATCH net] net: bridge: fix a null pointer dereference in br_afspec

, so check if p is null > first. > > Reported-by: Gustavo A. R. Silva <garsi...@embeddedor.com> > Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") > Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> Acked-by: Roopa Prabhu <ro...@cumulusnetworks.com> Thanks Nikolay.

Re: [Bridge] [PATCH net] bridge: Fix error path in nbp_vlan_init

On 3/1/17, 6:50 AM, Yotam Gigi wrote: > Fix error path order in nbp_vlan_init, so if switchdev_port_attr_set > call failes, the vlan_hash wouldn't be destroyed before inited. > > Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") > CC: Roopa Prabhu &

[Bridge] [PATCH net-next] bridge: remove unnecessary check for vtbegin in br_fill_vlan_tinfo_range

From: Roopa Prabhu <ro...@cumulusnetworks.com> vtbegin should not be NULL in this function, Its already checked by the caller. this should silence the below smatch complaint: net/bridge/br_netlink_tunnel.c:144 br_fill_vlan_tinfo_range() error: we previously assumed 'vtbegin' could b

Re: [Bridge] [PATCH net-next] bridge: tunnel: fix attribute checks in br_parse_vlan_tunnel_info

On 2/7/17, 3:46 AM, Nikolay Aleksandrov wrote: > These checks should go after the attributes have been parsed otherwise > we're using tb uninitialized. > > Fixes: efa5356b0d97 ("bridge: per vlan dst_metadata netlink support") > Reported-by: Colin Ian King >

Re: [Bridge] [PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device

On 8/4/16, 1:15 AM, Toshiaki Makita wrote: > On 2016/08/04 16:24, Roopa Prabhu wrote: >> On 8/3/16, 7:11 PM, Toshiaki Makita wrote: >>> Adding fdb entries pointing to the bridge device uses fdb_insert(), >>> which lacks various checks and does not respect added_by_use

Re: [Bridge] [PATCH net] bridge: Fix problems around fdb entries pointing to the bridge device

On 8/3/16, 7:11 PM, Toshiaki Makita wrote: > Adding fdb entries pointing to the bridge device uses fdb_insert(), > which lacks various checks and does not respect added_by_user flag. > > As a result, some inconsistent behavior can happen: > * Adding temporary entries succeeds but results in

[Bridge] [PATCH net-next] bridge: allow adding of fdb entries pointing to the bridge device

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch enables adding of fdb entries pointing to the bridge device. This can be used to propagate mac address of vlan interfaces configured on top of the vlan filtering bridge. Before: $bridge fdb add 44:38:39:00:27:9f dev bridge RTN

[Bridge] [PATCH net-next v2] bridge: allow adding of fdb entries pointing to the bridge device

From: Roopa Prabhu <ro...@cumulusnetworks.com> This patch enables adding of fdb entries pointing to the bridge device. This can be used to propagate mac address of vlan interfaces configured on top of the vlan filtering bridge. Before: $bridge fdb add 44:38:39:00:27:9f dev bridge RTN