Re: [Bridge] [PATCH net-next v4 02/11] bridge: mrp: Update Kconfig

Hello! On 26.04.2020 16:21, Horatiu Vultur wrote: Add the option BRIDGE_MRP to allow to build in or not MRP support. The default value is N. Reviewed-by: Nikolay Aleksandrov Signed-off-by: Horatiu Vultur --- net/bridge/Kconfig | 12 1 file changed, 12 insertions(+) diff

Re: [Bridge] [PATCH net v2] net: bridge: Fix ethernet header pointer before check skb forwardable

On 15.01.2019 6:12, wangyunjian wrote: From: Yunjian Wang The skb header should be set to ethernet header before using is_skb_forwardable. Because the ethernet header length has been considered in is_skb_forwardable(including dev->hard_header_len length). To reproduce the issue: 1, add 2

Re: [Bridge] [PATCH] netfilter: fix indent on in statements

Hello! On 8/15/2017 9:50 AM, Colin King wrote: From: Colin Ian King The returns on some if statements are not indented correctly, s/in/if/ in the subject? add in the missing tab. Signed-off-by: Colin Ian King [...] MBR, Sergei

Re: [Bridge] [PATCH net-next 13/27] bridge: use __vlan_hwaccel helpers

Hello! On 12/13/2016 3:12 AM, Michał Mirosław wrote: This removes assumption than vlan_tci != 0 when tag is present. Signed-off-by: Michał Mirosław --- net/bridge/br_netfilter_hooks.c | 14 -- net/bridge/br_private.h | 2 +- net/bridge/br_vlan.c

Re: [Bridge] [PATCH] bridge: Fix format string for %ul

Hello. On 8/27/2016 6:58 PM, Oleg Drokin wrote: %ul would print an unsigned value and a letter l, likely it was %lu that was meant to print the long int, but in reality the values printed there are just regular signed Signed? Then you need probably "%d" or "%i"… They are signed in the

Re: [Bridge] [PATCH net] bridge: notify user space after fdb update

Hello. On 05/28/2014 02:45 AM, Jon Maxwell wrote: There has been a number incidents recently where customers running KVM have reported that VM hosts on different Hypervisors are unreachable. Based on pcap traces we found that the bridge was broadcasting the ARP request out onto the network.

Re: [Bridge] [PATCH net-next 8/8] bridge: Automatically manage promisc mode when vlan filtering is on.

Hello. On 05/14/2014 07:09 PM, Vlad Yasevich wrote: If the user doesn't enable vlan filtering, we have to place all bridge ports in promsic mode so that we retain the capability of of receiving tagged frames. When vlan filtering is enabled, the each port will be provided with necessary vlan

Re: [Bridge] [PATCH net-next 5/8] bridge: Add addresses from static fdbs to non-promisc ports

On 05/14/2014 07:09 PM, Vlad Yasevich wrote: When a static fdb entry is created, add the mac address from this fdb entry to any ports that are currently running in non-promiscuous mode. These ports need this data so that they can receive traffic destined to these addresses. By default ports

Re: [Bridge] [PATCH net-next 3/8] bridge: Add functionality to sync static fdb entries to hw

On 05/14/2014 07:09 PM, Vlad Yasevich wrote: Add code that allows static fdb entires to be synced to the hw list for a specified port. This will be used later to program ports that can function in non-promiscuous mode. Signed-off-by: Vlad Yasevich vyase...@redhat.com ---

Re: [Bridge] [PATCH net] bridge: Add port flap detection

Hello. On 05/05/2014 01:29 AM, Jon Maxwell wrote: There has been a number incidents recently where customers running KVM have reported that VM hosts on different Hypervisors are unreachable. Based on pcap traces we found that the bridge was broadcasting the ARP request out onto the network.

Re: [Bridge] [PATCH][RFC] bridge: mark packets sent to any local mac address as PACKET_HOST

Hello. On 04/22/2014 09:50 PM, Maxime Bizon wrote: The bridge code only set PACKET_HOST on packets sent to the bridge mac address, packets sent to other local mac addresses are sent to upper layer, but ignored because they are marked as PACKET_OTHERHOST. You forgot to sign off. WBR,

Re: [Bridge] [PATCH] bridge: Fix crash with vlan filtering and tcpdump

Hello. On 03/27/2014 11:27 PM, Vlad Yasevich wrote: When the vlan filtering is enabled on the bridge, but the filter is not configured on the bridge device itself, running tcpdump on the bridge device will result in a an Oops with NULL pointer dereference. The reason is that

Re: [Bridge] [PATCH v2 net 1/2] net: Allow modules to use is_skb_forwardable

Hello. On 03/26/2014 07:14 PM, Vlad Yasevich wrote: Signed-off-by: Vlad Yasevich vyase...@redhat.com [...] diff --git a/net/core/dev.c b/net/core/dev.c index b1b0c8d..a98f7fa 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1645,7 +1645,7 @@ static inline void net_timestamp_set(struct

Re: [Bridge] [PATCH 1/1] bridge: fix message_age_timer calculation

Hello. On 09/09/2013 08:56 PM, Chris Healy wrote: This changes the message_age_timer calculation to use the BPDU's max age as opposed to the local bridge's max age. This is in accordance with section 8.6.2.3.2 Step 2 of the 802.1D-1998 sprecification. You should wrap your changelog

Re: [Bridge] [PATCHv4 net-next 0/2] Add two new flags to bridge.

Hello. On 05-06-2013 18:07, Vlad Yasevich wrote: The following series adds 2 new flags to bridge. One flag allows the user to control whether mac learning is performed on the interface or not. By default mac learning is on. The other flag allows the user to control whether unicast traffic is

Re: [Bridge] [PATCH net-next] bridge: avoid br_ifinfo_notify when nothing changed

Hello. On 23-03-2013 9:14, Hong Zhiguo wrote: When neither IFF_BRIDGE_PORT or IFF_BRIDGE_PORT is set, That is the same flag repeated twice. and afspec == NULL but protinfo != NULL, we run into if (err == 0) br_ifinfo_notify(RTM_NEWLINK, p); with random value in ret. Signed-off-by:

Re: [Bridge] [PATCH net-next] bridge: avoid br_ifinfo_notify when nothing changed

Hello. On 03/24/2013 04:26 PM, Hong Zhiguo wrote: When neither IFF_BRIDGE nor IFF_BRIDGE_PORT is set, and afspec == NULL but protinfo != NULL, we run into if (err == 0) br_ifinfo_notify(RTM_NEWLINK, p); with random value in ret. Thanks to Sergei for pointing out the error in commit comments.

Re: [Bridge] [PATCH net-next] bridge: avoid br_ifinfo_notify when nothing changed

Hello. On 25-03-2013 20:08, David Miller wrote: Sorry, I don't usuallly ACK patches in an area I'm not closely familiar with. Though I can add: If you feel confident enough to ask for corrections, you better be ready to ACK the result when your requests have been met. Come on, I