[Bridge] [PATCH] bridge: fix "entering disabled state" logging

2012-03-10 Thread Paulius Zaleckas
Now we have: eth0: link down br0: port 1(eth0) entering forwarding state State should be logged *after* it was changed, not before. Reported-by: Zilvinas Valinskas Signed-off-by: Paulius Zaleckas --- net/bridge/br_stp_if.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --g

Re: [Bridge] [PATCH] bridge: fix "entering disabled state" logging

2012-03-06 Thread Stephen Hemminger
On Tue, 06 Mar 2012 16:34:54 +0200 Paulius Zaleckas wrote: > On 03/06/2012 04:22 PM, Paulius Zaleckas wrote: > > Now we have: > > eth0: link down > > br0: port 1(eth0) entering forwarding state > > > > State should be logged *after* it was changed, not before. > > The funny thing is that it was

Re: [Bridge] [PATCH] bridge: fix "entering disabled state" logging

2012-03-06 Thread David Miller
From: Paulius Zaleckas Date: Tue, 06 Mar 2012 16:22:19 +0200 > Now we have: > eth0: link down > br0: port 1(eth0) entering forwarding state > > State should be logged *after* it was changed, not before. > > Reported-by: Zilvinas Valinskas > Signed-off-by: Paulius Zaleckas This is intentional

Re: [Bridge] [PATCH] bridge: fix "entering disabled state" logging

2012-03-06 Thread David Miller
From: Paulius Zaleckas Date: Tue, 06 Mar 2012 16:34:54 +0200 > On 03/06/2012 04:22 PM, Paulius Zaleckas wrote: >> Now we have: >> eth0: link down >> br0: port 1(eth0) entering forwarding state >> >> State should be logged *after* it was changed, not before. > > The funny thing is that it was int

Re: [Bridge] [PATCH] bridge: fix "entering disabled state" logging

2012-03-07 Thread David Lamparter
On Wed, Mar 07, 2012 at 10:04:04AM +0200, Paulius Zaleckas wrote: > On 03/06/2012 09:33 PM, David Miller wrote: > > From: Paulius Zaleckas > > Date: Tue, 06 Mar 2012 16:22:19 +0200 > > > >> Now we have: > >> eth0: link *down* > >> br0: port 1(eth0) entering *forwarding* state > >> > >> State should

Re: [Bridge] [PATCH] bridge: fix "entering disabled state" logging

2012-03-10 Thread Paulius Zaleckas
On 03/06/2012 04:22 PM, Paulius Zaleckas wrote: Now we have: eth0: link down br0: port 1(eth0) entering forwarding state State should be logged *after* it was changed, not before. The funny thing is that it was introduced: 2010-05-16 stephen hemminger bridge: change console message interf

Re: [Bridge] [PATCH] bridge: fix "entering disabled state" logging

2012-03-10 Thread Paulius Zaleckas
On 03/06/2012 09:33 PM, David Miller wrote: From: Paulius Zaleckas Date: Tue, 06 Mar 2012 16:22:19 +0200 Now we have: eth0: link *down* br0: port 1(eth0) entering *forwarding* state State should be logged *after* it was changed, not before. Reported-by: Zilvinas Valinskas Signed-off-by: Pauli